Revision dc342a25d1b48cb53448fe0e5dde578edce3122c authored by Jonathan Nieder on 24 January 2013, 23:21:46 UTC, committed by Junio C Hamano on 25 January 2013, 18:41:49 UTC
An earlier conversion from fgets() to strbuf_getline() in the codepath to read from /etc/mailname to learn the default host-part of the ident e-mail address forgot that strbuf_getline() stores the line at the beginning of the buffer just like fgets(). The "username@" the caller has prepared in the strbuf, expecting the function to append the host-part to it, was lost because of this. Reported-by: Mihai Rusu <dizzy@google.com> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> Acked-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 7e20105
File | Mode | Size |
---|---|---|
.gitignore | -rw-r--r-- | 52 bytes |
add-plain.diff | -rw-r--r-- | 180 bytes |
add-with backslash.diff | -rw-r--r-- | 184 bytes |
add-with quote.diff | -rw-r--r-- | 188 bytes |
add-with spaces.diff | -rw-r--r-- | 184 bytes |
add-with tab.diff | -rw-r--r-- | 184 bytes |
damaged-tz.diff | -rw-r--r-- | 290 bytes |
damaged.diff | -rw-r--r-- | 188 bytes |
diff-plain.diff | -rw-r--r-- | 146 bytes |
diff-with backslash.diff | -rw-r--r-- | 148 bytes |
diff-with quote.diff | -rw-r--r-- | 150 bytes |
diff-with spaces.diff | -rw-r--r-- | 148 bytes |
diff-with tab.diff | -rw-r--r-- | 148 bytes |
funny-tz.diff | -rw-r--r-- | 290 bytes |
git-plain.diff | -rw-r--r-- | 146 bytes |
git-with backslash.diff | -rw-r--r-- | 158 bytes |
git-with quote.diff | -rw-r--r-- | 164 bytes |
git-with spaces.diff | -rw-r--r-- | 150 bytes |
git-with tab.diff | -rw-r--r-- | 158 bytes |
make-patches | -rwxr-xr-x | 965 bytes |
Computing file changes ...