Revision dd2a35f13f53304b2e62b41d3fe501dd8473ea51 authored by Andrew Kryczka on 11 September 2019, 21:11:38 UTC, committed by Facebook Github Bot on 11 September 2019, 21:13:38 UTC
Summary: - In `db_stress`, support choosing index type and whether to enable filter partitioning, and randomly set those options in crash test - When partitioned filter is enabled by crash test, force partitioned index to also be enabled since it's a prerequisite Pull Request resolved: https://github.com/facebook/rocksdb/pull/4020 Test Plan: currently this is blocked on fixing the bug that crash test caught: ``` $ TEST_TMPDIR=/data/compaction_bench python ./tools/db_crashtest.py blackbox --simple --interval=10 --max_key=10000000 ... Verification failed for column family 0 key 937501: Value not found: NotFound: Crash-recovery verification failed :( ``` Differential Revision: D8508683 Pulled By: maysamyabandeh fbshipit-source-id: 0337e5d0558bcef26b1f3699f47265a2c1e99629
1 parent 20dd828
hash_map.h
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
// This source code is licensed under both the GPLv2 (found in the
// COPYING file in the root directory) and Apache 2.0 License
// (found in the LICENSE.Apache file in the root directory).
//
#pragma once
#include <algorithm>
#include <array>
#include <utility>
#include "util/autovector.h"
namespace rocksdb {
// This is similar to std::unordered_map, except that it tries to avoid
// allocating or deallocating memory as much as possible. With
// std::unordered_map, an allocation/deallocation is made for every insertion
// or deletion because of the requirement that iterators remain valid even
// with insertions or deletions. This means that the hash chains will be
// implemented as linked lists.
//
// This implementation uses autovector as hash chains insteads.
//
template <typename K, typename V, size_t size = 128>
class HashMap {
std::array<autovector<std::pair<K, V>, 1>, size> table_;
public:
bool Contains(K key) {
auto& bucket = table_[key % size];
auto it = std::find_if(
bucket.begin(), bucket.end(),
[key](const std::pair<K, V>& p) { return p.first == key; });
return it != bucket.end();
}
void Insert(K key, V value) {
auto& bucket = table_[key % size];
bucket.push_back({key, value});
}
void Delete(K key) {
auto& bucket = table_[key % size];
auto it = std::find_if(
bucket.begin(), bucket.end(),
[key](const std::pair<K, V>& p) { return p.first == key; });
if (it != bucket.end()) {
auto last = bucket.end() - 1;
if (it != last) {
*it = *last;
}
bucket.pop_back();
}
}
V& Get(K key) {
auto& bucket = table_[key % size];
auto it = std::find_if(
bucket.begin(), bucket.end(),
[key](const std::pair<K, V>& p) { return p.first == key; });
return it->second;
}
};
} // namespace rocksdb
Computing file changes ...