dd3f718 | Mike Pennisi | 23 December 2017, 00:01:51 UTC | [wptserve] Expand syntax to support fn invocation | 23 April 2018, 17:11:42 UTC |
18ee2b4 | Mike Pennisi | 20 December 2017, 00:05:18 UTC | [wptserve] Correct typo in documentation | 23 April 2018, 17:11:42 UTC |
cc236aa | Mike Pennisi | 20 December 2017, 00:04:32 UTC | [wptserve] Add tests | 23 April 2018, 17:11:42 UTC |
c873caf | Xida Chen | 23 April 2018, 15:57:51 UTC | Fix some layout tests that calls createPseudo In my previous CL I changed createPseudo function to getPseudoElement without updating some of the callers. This CL fixes that. NOTRY=true Bug: None Change-Id: I7a1f4bcc83736234e8bec2f16656cd72c39fd51d Reviewed-on: https://chromium-review.googlesource.com/1023974 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#552709} | 23 April 2018, 16:07:07 UTC |
d858d20 | Simon Pieters | 23 April 2018, 14:41:10 UTC | [innerText] add OWNERS | 23 April 2018, 15:03:28 UTC |
51a30a7 | L. David Baron | 21 April 2018, 15:59:23 UTC | Sync Mozilla tests as of https://hg.mozilla.org/mozilla-central/rev/dd0e54d786743974a50a338059bcd68a09b6d5b2 . | 23 April 2018, 14:52:50 UTC |
133d71d | Xida Chen | 23 April 2018, 13:55:24 UTC | Do not check type of a pseudo element in layout tests Currently the createPseudo checks the type of a pseudo element and that is not yet defined in the spec. This CL drops that to pass two tests. Bug: None Change-Id: Ib623b5f7ad2ff9059400a12aa12c459d6a7ddcb5 Reviewed-on: https://chromium-review.googlesource.com/1018538 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#552680} | 23 April 2018, 14:21:24 UTC |
5ac29d8 | Moritz Kneilmann | 23 April 2018, 13:13:35 UTC | Fetch: handling bad gzip content For https://github.com/whatwg/fetch/pull/710. | 23 April 2018, 13:13:35 UTC |
7827e00 | Chris Nardi | 23 April 2018, 11:51:18 UTC | Correct serialization in css-flexbox getComputedStyle tests 2 getComputedStyle tests in the css-flexbox testsuite were failing, as the default values of align-items and align-self were incorrect. Fix the default values so the tests pass. Bug: 467127 Change-Id: I4a23563d523d3da0201db591e51e1375dfa0d44f Reviewed-on: https://chromium-review.googlesource.com/1023342 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#552670} | 23 April 2018, 12:11:06 UTC |
4adba42 | James Graham | 21 April 2018, 00:18:33 UTC | Add wss port to wptrunner environment config bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1455566 gecko-commit: 1ed16f971ff0eaca7035dcfe35e6489d00778ec3 gecko-integration-branch: mozilla-inbound gecko-reviewers: gsnedders | 23 April 2018, 11:59:37 UTC |
a8a8377 | Matt Falkenhagen | 23 April 2018, 05:26:49 UTC | service worker: Upstream Service-Worker-Allowed test to WPT. Also add test cases for Service-Worker-Allowed header values that are absolute URLs. Currently Chrome accepts SWA header values that are cross-origin to the script URL since it seems to only care about the path of the URL. It seems strange but that seems to agree with the spec: https://github.com/w3c/ServiceWorker/issues/1307 Bug: 688116 Change-Id: I6dca55ea8525803efd2e55bf4166c863d62d31fa Reviewed-on: https://chromium-review.googlesource.com/1023672 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#552639} | 23 April 2018, 05:34:39 UTC |
d187735 | Matt Falkenhagen | 23 April 2018, 04:00:27 UTC | service worker: Add importScripts() to worker interception test. Also remove the Firefox-specific comment as they fixed the mentioned bug. Bug: 829720 Change-Id: I76727361ff9c7d61931fbf018035917ac5aa71d8 Reviewed-on: https://chromium-review.googlesource.com/1023616 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#552629} | 23 April 2018, 04:07:56 UTC |
f6d0423 | Emilio Cobos Álvarez | 21 April 2018, 19:26:17 UTC | Merge pull request #10535 from csnardi/font-variation-settings-serialization Flip serialization of two font-variation-settings tests | 21 April 2018, 19:26:17 UTC |
899579b | Emilio Cobos Álvarez | 21 April 2018, 19:25:22 UTC | Merge pull request #10538 from jfkthame/patch-1 Fix a couple of typos in test messages | 21 April 2018, 19:25:22 UTC |
1c36217 | Domenic Denicola | 17 November 2017, 00:07:58 UTC | Test active script, via import(), in promise jobs Follows https://github.com/whatwg/html/pull/3163. | 21 April 2018, 19:25:01 UTC |
aa55fee | James Graham | 21 April 2018, 00:18:59 UTC | Increase timeout in unstable-in-debug onload test, a=testonly bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1455532 gecko-commit: 0605371779f857836f6900435720db4444f64996 gecko-integration-branch: mozilla-inbound gecko-reviewers: testonly | 21 April 2018, 09:35:51 UTC |
738b52f | James Graham | 21 April 2018, 01:27:47 UTC | Give link-upgrade test a long timeout This test was frequently timing out in debug due to a short timeout in the test. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1454390 gecko-commit: fdb7b761a45a2fa3f154126cb5418f9dcd0e29bd gecko-integration-branch: central gecko-reviewers: ato | 21 April 2018, 01:46:34 UTC |
0628e2e | Dominic Farolino | 20 April 2018, 21:22:39 UTC | Add Console historical test for markTimeline ...and also generalize the file already containing historical tests to house any future historical tests asserting the non-existence of certain legacy Console methods. Part of whatwg/console#27. | 20 April 2018, 21:22:39 UTC |
26bb715 | James Graham | 19 April 2018, 14:29:22 UTC | Unbreak external reftests on wpt The (fast) internal reftest runner wasn't affected by this, so we didn't notice the breakage since it only happened on platforms still using the older broken runner. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1454471 gecko-commit: 16bb3f3c01cbaf2ec6990cb4499dfbe096d994fc gecko-integration-branch: autoland gecko-reviewers: ato | 20 April 2018, 19:56:31 UTC |
24fc87c | Raymond Toy | 20 April 2018, 18:43:05 UTC | Move BiquadFilter tests to WPT Move the BiquadFilter tests to WPT. The tail-time-*.html tests can't be moved because they test Chrome's implementation of tail time and is thus specific to Chrome. Firefox fails biquad-automation.html because Firefox hasn't implemented a-rate parameters for the filters. Firefox also fails biquad-basic.html because it doesn't throw errors if the array lengths for getFrequencyResponse have different lengths. Bug: 745778 Change-Id: I0c729038670931d4a47f6c28ae0b688c89320f49 Reviewed-on: https://chromium-review.googlesource.com/994056 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#552399} | 20 April 2018, 18:52:40 UTC |
43cf85f | James Graham | 10 April 2018, 18:36:46 UTC | Add an infrastructure test for wdspec. This just tries to load a file to check things aren't totally broken. In theory we could test each fixture this way. | 20 April 2018, 15:53:08 UTC |
564cfb3 | James Graham | 10 April 2018, 18:35:53 UTC | Fix WebDriverProtocol to have a base ProtocolPart. Without this we error when trying to wait(). In practice we could improve this to checkc if there's a current session and use that, but this minimally unbreaks things. | 20 April 2018, 15:53:08 UTC |
8261946 | James Graham | 10 April 2018, 18:34:29 UTC | Allow wdspec tests in infrastructure/webdriver | 20 April 2018, 15:53:08 UTC |
a9b3bb7 | Jinho Bang | 20 April 2018, 14:06:41 UTC | PaymentHandler: Add [SameObject] to paymentManager and instruments attr Related spec change: https://github.com/w3c/payment-handler/pull/293 Bug: 833535 Change-Id: Id7d0cad0f150a73e2932bd8f81f9e5650830a2c0 Reviewed-on: https://chromium-review.googlesource.com/1013660 Reviewed-by: Ganggui Tang <gogerald@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#552319} | 20 April 2018, 14:16:42 UTC |
1aa52b3 | Chris Nardi | 19 April 2018, 16:09:55 UTC | Clear font-variation-settings before testing This caused some tests to fail before the first commit simply due to font-variation-settings having already been set when the value shouldn't have been parsed. | 20 April 2018, 14:07:04 UTC |
55d647f | Dominic Farolino | 20 April 2018, 14:02:36 UTC | Fetch: update default Request credentials mode See https://github.com/whatwg/fetch/pull/585. | 20 April 2018, 14:02:36 UTC |
ff8a559 | Chris Nardi | 19 April 2018, 14:50:44 UTC | Flip serialization of two font-variation-settings tests The expected computed valid of two font variation settings tests was opposite to the specified order (and per https://drafts.csswg.org/css-fonts-4/#propdef-font-variation-settings, the computed value is "as specified"). Reverse the two axis in order to match the specified order. | 20 April 2018, 13:58:14 UTC |
f56ee9d | Rob Buis | 20 April 2018, 12:24:26 UTC | Make border-image use real initial values for its longhands Make border-image use real initial values for its longhands, instead of just "initial". Note that this fixes the problems left by r551310. Behavior matches Firefox. Bug: 825568, 772772 Change-Id: Ic4eda9db5ec370059578ca87e1512fae5b373cbd Reviewed-on: https://chromium-review.googlesource.com/1013806 Commit-Queue: Rob Buis <rob.buis@samsung.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#552306} | 20 April 2018, 12:33:00 UTC |
4736f3f | Javier Fernandez | 20 April 2018, 10:13:24 UTC | [css-align] Simple syntax for the Alignment shorthands Now that the issue [1] about the syntax ambiguity has been resolved we don´t need to use the custom syntax anymore. The Alignment shorthands use now the simple syntax, defined based on the longhands' syntax. Since we allow all the values valid for each longhand, we'll update in this CL the corresponding web platform tests. Additionally, this CL updates also the shorthand serialization tests [2], which didn't consider the new value 'legacy' for justify-items (and place-items) due to the bug [3] Firefox still has pending to be fixed. [1] https://github.com/w3c/csswg-drafts/issues/1001 [2] css/css-align/default-alignment/shorthand-serialization-001.html [3] https://bugzilla.mozilla.org/show_bug.cgi?id=1363875 Bug: 832503, 829806 Change-Id: I53f803b384cc55b0b38292540262e54f803586da Reviewed-on: https://chromium-review.googlesource.com/1013710 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#552293} | 20 April 2018, 10:40:09 UTC |
7f19b63 | Anthony Ramine | 20 April 2018, 09:09:10 UTC | Fix ssl_config | 20 April 2018, 09:45:18 UTC |
50ba192 | Ben Kelly | 20 April 2018, 09:06:34 UTC | Update fetch and service worker tests to allow same-origin no-cors redirects #9039 wasn't quite aligned with the specification. | 20 April 2018, 09:06:34 UTC |
7d0018e | Emilio Cobos Álvarez | 19 April 2018, 10:57:52 UTC | Update font-weight property and descriptor to css-fonts-4. Need to change the tests still, but that should be trivial. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1454596 gecko-commit: 3330e2fce16d05eaad1e28101ed843b2383adcb8 gecko-integration-branch: mozilla-inbound gecko-reviewers: xidorn | 20 April 2018, 08:53:12 UTC |
19aab25 | Yoav Weiss | 19 April 2018, 20:02:31 UTC | [Resource Timing] Align TAO parsing to spec TAO parsing had two issues: * It was splitting the host values on whitespace rather than a comma. This used to be the specified behavior, but changed in https://github.com/w3c/resource-timing/pull/68 * When it was checking the different hosts in the host list, it was not checking for "*" as a possible value. This CL fixes those two issues and aligns the test expectations accordingly. Bug: 651861, 833032, 626703 Change-Id: I8a3b7e705ed7089719ad0f52607363392c7de934 Reviewed-on: https://chromium-review.googlesource.com/1013409 Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Yoav Weiss <yoav@yoav.ws> Cr-Commit-Position: refs/heads/master@{#552127} | 19 April 2018, 20:13:18 UTC |
9824114 | Alex Moshchuk | 19 April 2018, 17:55:30 UTC | Fix incorrect unreachable_func in CSP layout tests. Credit goes to nick@ for spotting it in https://chromium-review.googlesource.com/c/chromium/src/+/999182 Change-Id: I278234762e4ca8ced592c0b63636c6dc6b981e6f Reviewed-on: https://chromium-review.googlesource.com/1010473 Reviewed-by: Nick Carter <nick@chromium.org> Commit-Queue: Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#552077} | 19 April 2018, 18:07:05 UTC |
d71db90 | jfkthame | 19 April 2018, 17:33:23 UTC | Fix a couple of typos in test messages | 19 April 2018, 17:33:23 UTC |
d516af2 | youennf | 19 April 2018, 13:38:00 UTC | fetch()'s redirect feature combined with "no-cors" For https://github.com/whatwg/fetch/pull/663. (WebKit export of https://bugs.webkit.org/show_bug.cgi?id=180347.) | 19 April 2018, 13:38:00 UTC |
1b8ef0c | Anthony Ramine | 19 April 2018, 13:24:15 UTC | Merge pull request #10533 from w3c/sync_9baf12e103c9b77498c9869cc666aa063f6e3237 Merge pull request #10533 from sync_9baf12e103c9b77498c9869cc666aa063f6e3237 | 19 April 2018, 13:24:15 UTC |
9baf12e | Connor Brewster | 19 April 2018, 13:23:07 UTC | Remove entries for removed iframes Notify history changed after a navigation Add history drop test Upstreamed from https://github.com/servo/servo/pull/20629 [ci skip] | 19 April 2018, 13:23:08 UTC |
c51dc5e | Chris Nardi | 19 April 2018, 11:33:21 UTC | Remove duplicate CSS tests that exist in WPT For css-style-attribute-modifications.html and child-indexed-pseudo-class.html, copy our local modifications over to the shared WPT copy. For the others, they are exact duplicates of tests in external/wpt/css/css-logical. Remove these duplicate tests. Change-Id: I1c5b461315efd8f75ed1a636328b877550eeac25 Reviewed-on: https://chromium-review.googlesource.com/1016163 Reviewed-by: Robert Ma <robertma@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#551978} | 19 April 2018, 11:44:20 UTC |
faf4c1d | Manish Goregaokar | 19 April 2018, 10:01:31 UTC | Add reftest bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1451724 gecko-commit: a993e6e8d14c75545a59b18ba32c821801d6f124 gecko-integration-branch: central gecko-reviewers: emilio | 19 April 2018, 10:20:29 UTC |
f78410b | Luke Bjerring | 18 April 2018, 22:18:14 UTC | Cleanup several idlharness tests Change-Id: I388e2a9605096886291fafdae428b78bfe21dea9 Reviewed-on: https://chromium-review.googlesource.com/992880 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Commit-Queue: Luke Bj <lukebjerring@chromium.org> Cr-Commit-Position: refs/heads/master@{#551840} | 18 April 2018, 22:32:51 UTC |
0a537e6 | youennf | 18 April 2018, 21:09:58 UTC | Merge pull request #10527 from youennf/wpt-export-for-webkit-184746 WebKit export of https://bugs.webkit.org/show_bug.cgi?id=184746 | 18 April 2018, 21:09:58 UTC |
a4c4257 | Anne van Kesteren | 18 April 2018, 18:58:15 UTC | DOM: test composed/composedPath via IDL (#9968) | 18 April 2018, 18:58:15 UTC |
a42f9ee | Youenn Fablet | 18 April 2018, 18:50:32 UTC | WebKit export of https://bugs.webkit.org/show_bug.cgi?id=184746 | 18 April 2018, 18:50:32 UTC |
4a7f047 | Ms2ger | 18 April 2018, 17:53:25 UTC | Avoid FutureWarnings in test_sourcefile.py. (#10518) These lines of code triggered the following warning: > FutureWarning: The behavior of this method will change in future versions. > Use specific 'len(elem)' or 'elem is not None' test instead. | 18 April 2018, 17:53:25 UTC |
e2c839d | Anne van Kesteren | 18 April 2018, 11:59:14 UTC | Fetch: MediaSource blob: URLs For https://github.com/whatwg/fetch/pull/708. | 18 April 2018, 11:59:14 UTC |
f70fcac | Cameron McCormack | 18 April 2018, 10:51:47 UTC | Add WPT test for white space between adjacent elements in the same anonymous table cell. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1452870 gecko-commit: b06fe2f80ddfc8baa9af24ac5ad5a9e4b98940a8 gecko-integration-branch: central gecko-reviewers: dholbert | 18 April 2018, 11:03:48 UTC |
53d666c | Andrea Marchesini | 18 April 2018, 10:27:07 UTC | WorkerRef should make APIs able to work until the worker is completely terminated - part 2 - BroadcastChannel bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1450644 gecko-commit: f2341e59a4b58d36766806dab967a24526a35368 gecko-integration-branch: mozilla-inbound gecko-reviewers: asuth | 18 April 2018, 10:54:25 UTC |
b4e3ffb | Ms2ger | 18 April 2018, 09:55:48 UTC | URL.createObjectURL should not work with MediaStream (#10515) Change the one existing test to no longer rely on it (and clearly mark it as manual) and add an entry to historical.html for it. | 18 April 2018, 09:55:48 UTC |
13f0fff | Anne van Kesteren | 18 April 2018, 09:48:50 UTC | nit | 18 April 2018, 09:48:50 UTC |
816c2ec | Anne van Kesteren | 18 April 2018, 09:36:43 UTC | URL.createObjectURL should not work with MediaStream Change the one existing test to no longer rely on it (and clearly mark it as manual) and add an entry to historical.html for it. | 18 April 2018, 09:36:43 UTC |
412b403 | Anne van Kesteren | 12 April 2018, 09:58:43 UTC | Test vertical tab for base64 Apparently Rust's base64 crate strips this, so it would be good to test. Safari is also an outlier here. | 18 April 2018, 08:07:22 UTC |
6030898 | jgraham | 18 April 2018, 00:02:33 UTC | Install Ahem for Safari on Sauce (#10491) This just gets the latest master version of the font; we could change things to get the version for the current revision, but it isn't necessarily worth the extra complexity given how rarely this changes. | 18 April 2018, 00:02:33 UTC |
f76bdbf | jugglinmike | 18 April 2018, 00:02:14 UTC | [wptrunner] Install Ahem in Sauce Labs Windows VM (#10499) | 18 April 2018, 00:02:14 UTC |
4a0df34 | Morten Stenshorne | 17 April 2018, 20:09:59 UTC | Fix wpt/css/CSS2/floats-clear/clear-on-parent-with-margins-no-clearance.html The test was incorrect, which is why it failed in legacy layout. It passed in LayoutNG because of a bug there. Add an (invisible) top border on the outer DIV to prevent clearance on the child. Otherwise the outer DIV and the child with 'clear' would have adjacent margins, which in turn would enable the child with 'clear' to pull the float along with itself, which in turn would guarantee clearance, which is precisely what this test wanted to avoid. Still passes in LayoutNG. Change-Id: I6b36d8196b93720453d6e398509705d2cf32f8e4 Reviewed-on: https://chromium-review.googlesource.com/1014975 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#551443} | 17 April 2018, 20:22:44 UTC |
32b05c8 | Simon Stewart | 17 April 2018, 18:15:40 UTC | Merge pull request #10401 from jimevans/script-user-prompts Updating WebDriver execute[Async]Script tests for unhandled user prompts | 17 April 2018, 18:15:40 UTC |
558c8b5 | Simon Pieters | 17 April 2018, 15:45:03 UTC | [css-contain] add OWNERS | 17 April 2018, 16:23:56 UTC |
b1ddc9a | Simon Pieters | 17 April 2018, 15:36:20 UTC | Fix README.md command: python wpt run | 17 April 2018, 15:52:23 UTC |
4358fc0 | Emilio Cobos Álvarez | 16 April 2018, 11:47:06 UTC | css-display] Move unboxing to style, and handle display: contents before other suppressions. This also adopts the resolution of [1] while at it, and switches XUL to not support display: contents until a use case appears. This makes our behavior consistent both with the spec and also in terms of handling dynamic changes to stuff that would otherwise get suppressed. Also makes us consistent with both Blink and WebKit in terms of computed style. We were the only ones respecting "behaves as display: none" without actually computing to display: none. Will file a spec issue to get that changed. It also makes us match Blink and WebKit in terms of respecting display: contents before other suppressions, see the reftest which I didn't write as a WPT (because there's no spec supporting neither that or the opposite of what we do), where a <g> element respects display: contents even though if it had any other kind of display value we'd suppress the frame for it and all the descendants since it's an SVG element in a non-SVG subtree. Also, this removes the page-break bit from the display: contents loop, which I think is harmless. As long as the tests under style are based in namespace id / node name / traversal parent, this should not make style sharing go wrong in any way, since that's the first style sharing check we do at [2]. The general idea under this change is making all nodes with computed style of display: contents actually honor it. Otherwise there's no way of making the setup sound except re-introducing something similar to all the state tracking removed in bug 1303605. [1]: https://github.com/w3c/csswg-drafts/issues/2167 [2]: https://searchfox.org/mozilla-central/rev/fca4426325624fecbd493c31389721513fc49fef/servo/components/style/sharing/mod.rs#700 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1453702 gecko-commit: 43862b2ee72eec858f509ce3b9cb5c6fa96194ba gecko-integration-branch: mozilla-inbound gecko-reviewers: mats, xidorn | 17 April 2018, 15:13:30 UTC |
4bf2fa8 | James Graham | 22 August 2017, 14:43:51 UTC | Don't wrap HTTPExceptions in FunctionHandler.__call__(). Extracted from https://github.com/w3c/web-platform-tests/pull/6792. | 17 April 2018, 13:27:35 UTC |
8824132 | Ahilya Sinha | 17 April 2018, 09:37:50 UTC | Fixed config.json not being used in TestEnvironment (#10494) Added a check in the TestEnvironment load_config so it overrides the default config when present. Closes https://github.com/w3c/web-platform-tests/issues/8181 | 17 April 2018, 09:37:50 UTC |
16e3f3e | Brendan McLoughlin | 17 April 2018, 09:31:37 UTC | Do not print logs twice when running wpt lint (#10148) | 17 April 2018, 09:31:37 UTC |
ae41496 | Anne van Kesteren | 17 April 2018, 08:50:02 UTC | Add more XMLHttpRequest overrideMimeType() tests For https://github.com/whatwg/xhr/issues/157, https://github.com/whatwg/xhr/pull/174, and https://github.com/whatwg/mimesniff/issues/42. | 17 April 2018, 08:50:02 UTC |
e0d1004 | Geoffrey Sneddon | 17 April 2018, 07:23:46 UTC | Add backwards compatibility for external_host and host_ip (#10409) | 17 April 2018, 07:23:46 UTC |
e08f214 | Jinho Bang | 17 April 2018, 04:55:09 UTC | PaymentHandler: Not allow to call operation if event is not trusted Related spec change: https://github.com/w3c/payment-handler/pull/294 Bug: 833530 Change-Id: I65d0e01bb5b6bfdd44925b90ba98837161cc136b Reviewed-on: https://chromium-review.googlesource.com/1013664 Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#551238} | 17 April 2018, 05:05:29 UTC |
727a813 | Anne van Kesteren | 17 April 2018, 05:01:58 UTC | Meta: certificate advice for macOS (Chrome/Safari) (#10486) | 17 April 2018, 05:01:58 UTC |
7eed33a | Hongchan Choi | 17 April 2018, 03:09:48 UTC | Apply automatic pull for AudioWorkletNode with zero output Spec: https://webaudio.github.io/web-audio-api/#rendering-loop (Step 9.5) The AudioWorkletNode with zero output must be pulled by the renderer. The actual output will be ignored just like AnalyserNode. Bug: 831245 Test: LayoutTests/external/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-automatic-pull.https.html Change-Id: If9bd27d6c4bfeecdcd2dd4c8445459afd8593e85 Reviewed-on: https://chromium-review.googlesource.com/1014388 Reviewed-by: Raymond Toy <rtoy@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551210} | 17 April 2018, 03:21:38 UTC |
e48e26a | Philip Jägenstedt | 17 April 2018, 01:03:04 UTC | Remove old drawCustomFocusRing test (#10487) Added in https://github.com/w3c/web-platform-tests/pull/406. Removed from HTML in https://github.com/whatwg/html/commit/ff07c6d630fb986f6c4f64b2fb87387b4f89647d and historical test added in https://github.com/w3c/web-platform-tests/pull/3801. Fixes https://github.com/w3c/web-platform-tests/issues/547. | 17 April 2018, 01:03:04 UTC |
0324a6e | James Graham | 16 April 2018, 17:58:17 UTC | Add long timeout to cache-abort tests, a=testonly These were previously timing out regularly on OSX debug builds. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1454362 gecko-commit: e2f68d3b03c2fe2c8f489ba179e7dc871acda245 gecko-integration-branch: mozilla-inbound gecko-reviewers: testonly | 16 April 2018, 23:59:07 UTC |
25b6727 | pyup.io bot | 16 April 2018, 23:20:44 UTC | Update mozprofile from 0.29 to 1.0.0 (#10453) | 16 April 2018, 23:20:44 UTC |
c5a68bd | Domenic Denicola | 16 April 2018, 03:50:36 UTC | null is not the correct origin for createDocument() See https://dom.spec.whatwg.org/#dom-domimplementation-createdocument | 16 April 2018, 14:29:56 UTC |
88a9970 | James Graham | 15 April 2018, 09:22:37 UTC | Fix prefs getter call in wptrunner Firefox executor bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1452952 gecko-commit: 55b99481fab156381335b6887fca26b6a8f0c0b3 gecko-integration-branch: mozilla-inbound gecko-reviewers: ato | 16 April 2018, 11:44:42 UTC |
84e7972 | Anne van Kesteren | 16 April 2018, 09:52:07 UTC | Adjust XMLHttpRequest Content-Type handling See https://github.com/whatwg/xhr/pull/176 and https://github.com/whatwg/mimesniff/pull/36. | 16 April 2018, 09:52:07 UTC |
b4cdc8f | Marcos Cáceres | 16 April 2018, 07:19:19 UTC | fix: ApplePay PMI is wrong (#10485) | 16 April 2018, 07:19:19 UTC |
fa62ac0 | Anne van Kesteren | 16 April 2018, 06:36:02 UTC | Fetch: align about:blank handling with the standard See https://github.com/whatwg/fetch/commit/72fc2e787be663f5bc39c88665dd3c356abbca0f. Closes https://github.com/whatwg/xhr/issues/194. | 16 April 2018, 06:36:02 UTC |
691673d | Anne van Kesteren | 16 April 2018, 04:56:38 UTC | Ensure cloneNode() does not preserve the prototype Closes https://github.com/whatwg/dom/issues/565. | 16 April 2018, 04:56:38 UTC |
6736e3f | jgraham | 15 April 2018, 20:55:04 UTC | Improve handling of harness-level errors in wptrunner (#10444) Split the internal handling of errors during a test into two cases; INTERNAL-ERROR that is produced if there's an exception in the harness and ERROR that is for exceptions reported by the test. Both are still reported as ERROR to the user, but in the INTERNAL-ERROR case the runner is always restarted, just like EXTERNAL-TIMEOUT, since we assume that the internal state is compromised somehow. | 15 April 2018, 20:55:04 UTC |
ff4cf69 | Eric Willigers | 15 April 2018, 11:01:13 UTC | CSS: Remove support for position values with 3 parts Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/oBKMVCOX1sY/BLsXXiukAgAJ BUG=804187 Change-Id: I94e79b2b426250c521d0ebae1492571fde078f31 Reviewed-on: https://chromium-review.googlesource.com/1013459 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#550915} | 15 April 2018, 11:30:16 UTC |
b3c7910 | Kerem Kat | 15 April 2018, 09:31:12 UTC | Add web-platform tests for StyleRule selectorText property setter. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=37468 gecko-commit: 7343e39bf9854651c4f8c2525767b825666d38fd gecko-integration-branch: central gecko-reviewers: xidorn | 15 April 2018, 09:54:19 UTC |
ca418bd | Robert Longson | 14 April 2018, 16:20:39 UTC | support ping, rel, referrerPolicy, relList, hreflang, type and text on SVG a elements bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1451823 gecko-commit: a1d4a3e6c77a29e7e63d5e88f5b4859b113df943 gecko-integration-branch: mozilla-inbound gecko-reviewers: mystor | 15 April 2018, 09:23:10 UTC |
fd2badf | Fuqiao Xue | 14 April 2018, 19:47:57 UTC | [css-values] Typo fixes (#10383) | 14 April 2018, 19:47:57 UTC |
da5837a | Stephen McGruer | 14 April 2018, 15:31:17 UTC | Reland "Web Animations: Fix bugs in procedure to process a keyframes argument" This is a reland of 0ade0386aa4168b48234bc7f33d30a62140b95ea Original change's description: > Web Animations: Fix bugs in procedure to process a keyframes argument > > There were three minor bugs left in the implementation: > > - We threw on lists-in-custom-iterators instead of just ignoring them. > - We returned all properties on the keyframe rather than just those > defined on the keyframe itself (e.g. we would include prototype > properties, against spec). > - We didn't access the properties in ascending unicode order. > > Bug: 827573 > Change-Id: I213ae5b24e1f35d7f28d16625025122950a6ba88 > Reviewed-on: https://chromium-review.googlesource.com/989261 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550641} Bug: 827573 Change-Id: I6c49fa6ca36db16ecddfb520e0964bd231565a0b Reviewed-on: https://chromium-review.googlesource.com/1012897 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#550895} | 14 April 2018, 15:47:16 UTC |
6f621ca | L. David Baron | 14 April 2018, 15:33:30 UTC | Sync Mozilla tests as of https://hg.mozilla.org/mozilla-central/rev/37b8862d354e0014a72715462dd2102dd5b599cc . (#10470) | 14 April 2018, 15:33:30 UTC |
0e0344a | Emilio Cobos Álvarez | 14 April 2018, 11:37:26 UTC | Merge pull request #10422 from emilio/cssom-woes [cssom] Add tests for some recent CSSWG resolutions. | 14 April 2018, 11:37:26 UTC |
c53d084 | Alex Moshchuk | 13 April 2018, 23:12:06 UTC | Reland 2: Use PostTask to schedule cross-process postMessage forwarding. Changes from first reland attempt at https://crrev.com/c/1011287: - fix an additional source of flakiness in ChromeOS login tests Changes from original attempt at https://crrev.com/c/999182: - fix flakiness in two additional ChromeOS login tests - fix CSP WPT tests to not depend on ordering between iframe's onload and postMessage - see https://crbug.com/832319. Previously, we sent the IPC to forward a cross-process postMessage immediately. This caused a behavioral difference from the same-process case where the postMessage is always scheduled. Namely, in a scenario like this: frame.postMessage(...); doSomethingThatSendsIPCsToFrame(frame); the IPCs from JS following the postMessage would've been ordered incorrectly, causing |frame| to see their side effects after the postMessage dispatch in the cross-process case, whereas they would be seen before the postMessage dispatch in the same-process case. One example of this is frame.focus(), and another is a frame element onload event (dispatched via FrameHostMsg_DispatchLoad) arriving after a postMessage dispatched from an inline script while the frame was still loading. To resolve these ordering concerns, this CL changes cross-process postMessage to do a PostTask on the sender side before sending the message to the browser process. This improves the current state of the world, but does not yet achieve a perfect match for the IPC ordering in the same-process case - see discussion on the bug. Bug: 828529 Tbr: dcheng@chromium.org Change-Id: If2cc6591db31471adff0d84ec0b689905e21cdf1 Reviewed-on: https://chromium-review.googlesource.com/999182 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#550284} Reviewed-on: https://chromium-review.googlesource.com/1011287 Cr-Original-Commit-Position: refs/heads/master@{#550621} Reviewed-on: https://chromium-review.googlesource.com/1012472 Cr-Commit-Position: refs/heads/master@{#550769} | 13 April 2018, 23:31:26 UTC |
ae86013 | Emilio Cobos Álvarez | 13 April 2018, 22:03:05 UTC | Remove Element.createShadowRoot. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1453789 gecko-commit: b2dd9ca61e0b92b6a0da66d86de4ab4f87cd8e19 gecko-integration-branch: central gecko-reviewers: smaug | 13 April 2018, 22:24:03 UTC |
433d39e | Emilio Cobos Álvarez | 11 April 2018, 12:29:23 UTC | [cssom] Remove comment that now is invalid per CSSWG resolution. getComputedStyle returns styles in the node's document per the resolution in https://github.com/w3c/csswg-drafts/issues/1548. | 13 April 2018, 20:20:18 UTC |
dc670d8 | Emilio Cobos Álvarez | 11 April 2018, 12:27:56 UTC | [cssom] Test detached elements, elements outside the flattened tree, and hidden frames. This tests resolutions from https://github.com/w3c/csswg-drafts/issues/1548. | 13 April 2018, 20:20:18 UTC |
de23472 | Emilio Cobos Álvarez | 11 April 2018, 12:15:02 UTC | [cssom] Test that getComputedStyle with an unknown/invalid pseudo-element throws. This tests the resolution in https://github.com/w3c/csswg-drafts/issues/2149. | 13 April 2018, 20:20:17 UTC |
cb845c5 | Avi Drissman | 13 April 2018, 19:50:51 UTC | Revert "Web Animations: Fix bugs in procedure to process a keyframes argument" This reverts commit 0ade0386aa4168b48234bc7f33d30a62140b95ea. Reason for revert: Unexpected Failures: * bindings/sequence-type.html * custom-elements/spec/define-element.html * external/wpt/custom-elements/CustomElementRegistry.html on https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11%20%28dbg%29/ https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20%28dbg%29/ Speculatively reverting this to see if it's the cause. Original change's description: > Web Animations: Fix bugs in procedure to process a keyframes argument > > There were three minor bugs left in the implementation: > > - We threw on lists-in-custom-iterators instead of just ignoring them. > - We returned all properties on the keyframe rather than just those > defined on the keyframe itself (e.g. we would include prototype > properties, against spec). > - We didn't access the properties in ascending unicode order. > > Bug: 827573 > Change-Id: I213ae5b24e1f35d7f28d16625025122950a6ba88 > Reviewed-on: https://chromium-review.googlesource.com/989261 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550641} TBR=flackr@chromium.org,yukishiino@chromium.org,jbroman@chromium.org,haraken@chromium.org,smcgruer@chromium.org Change-Id: I5e8dc0c67599492bd6e90fca4a034e29e334ef88 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 827573 Reviewed-on: https://chromium-review.googlesource.com/1012857 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550721} | 13 April 2018, 20:09:27 UTC |
e6cffaa | theodab | 13 April 2018, 19:17:17 UTC | Test that requestMediaKeySystemAccess sets label (#8508) On Edge, navigator.requestMediaKeySystemAccess ignores the value passed along to the label configuration field. This test exposes that bug. See https://goo.gl/6SgCRb | 13 April 2018, 19:17:17 UTC |
81bcc8d | Mustaq Ahmed | 13 April 2018, 18:16:18 UTC | Make PointerEvent fromElement/toElement return null. Also added web-platform-tests. Blink intent thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/G2s1Ol3qcgA Closes https://github.com/w3c/pointerevents/issues/167 Bug: 827271 Change-Id: I8429b9541f8cfc38223b3a34116b74c2aba92ee5 Reviewed-on: https://chromium-review.googlesource.com/986877 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#550683} | 13 April 2018, 18:25:25 UTC |
6ad1b51 | Ben Pastene | 13 April 2018, 17:03:33 UTC | Revert "Reland: Use PostTask to schedule cross-process postMessage forwarding." This reverts commit 7c3d1d13f940e88ef6706fd8b5c257a81d340ed9. Reason for revert: WebviewLoginTest.Basic is still flaky on linux-chromeos-rel https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/6886 https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/6887 Original change's description: > Reland: Use PostTask to schedule cross-process postMessage forwarding. > > Changes from original attempt at https://crrev.com/c/999182: > - fix flakiness in two additional ChromeOS login tests > - fix CSP WPT tests to not depend on ordering between iframe's onload > and postMessage - see https://crbug.com/832319. > > Previously, we sent the IPC to forward a cross-process postMessage > immediately. This caused a behavioral difference from the > same-process case where the postMessage is always scheduled. Namely, > in a scenario like this: > > frame.postMessage(...); > doSomethingThatSendsIPCsToFrame(frame); > > the IPCs from JS following the postMessage would've been ordered > incorrectly, causing |frame| to see their side effects after the > postMessage dispatch in the cross-process case, whereas they would be > seen before the postMessage dispatch in the same-process case. One > example of this is frame.focus(), and another is a frame element > onload event (dispatched via FrameHostMsg_DispatchLoad) arriving after > a postMessage dispatched from an inline script while the frame was > still loading. > > To resolve these ordering concerns, this CL changes cross-process > postMessage to do a PostTask on the sender side before sending the > message to the browser process. This improves the current state of > the world, but does not yet achieve a perfect match for the IPC > ordering in the same-process case - see discussion on the bug. > > Bug: 828529 > Change-Id: I62a627c501526d09900be4f5bd2c899acf4d1e07 > Reviewed-on: https://chromium-review.googlesource.com/999182 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Alex Moshchuk <alexmos@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#550284} > Reviewed-on: https://chromium-review.googlesource.com/1011287 > Cr-Commit-Position: refs/heads/master@{#550621} TBR=xiyuan@chromium.org,dcheng@chromium.org,alexmos@chromium.org Change-Id: Ic0637a6038bed6e5334a26e1934bee81faad3b9e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 828529 Reviewed-on: https://chromium-review.googlesource.com/1012138 Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#550649} | 13 April 2018, 17:30:38 UTC |
7b20d12 | Eric Willigers | 13 April 2018, 17:26:34 UTC | Merge pull request #10263 from csnardi/patch-10 Update serialization of timing functions | 13 April 2018, 17:26:34 UTC |
2707869 | Stephen McGruer | 13 April 2018, 16:52:45 UTC | Web Animations: Fix bugs in procedure to process a keyframes argument There were three minor bugs left in the implementation: - We threw on lists-in-custom-iterators instead of just ignoring them. - We returned all properties on the keyframe rather than just those defined on the keyframe itself (e.g. we would include prototype properties, against spec). - We didn't access the properties in ascending unicode order. Bug: 827573 Change-Id: I213ae5b24e1f35d7f28d16625025122950a6ba88 Reviewed-on: https://chromium-review.googlesource.com/989261 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#550641} | 13 April 2018, 17:03:30 UTC |
1e5a5fe | Eric Willigers | 13 April 2018, 16:48:17 UTC | Merge pull request #10462 from ewilligers/background-serialization-variety Accept variation in serialization of 'background' | 13 April 2018, 16:48:17 UTC |
f281334 | Alex Moshchuk | 13 April 2018, 15:22:14 UTC | Reland: Use PostTask to schedule cross-process postMessage forwarding. Changes from original attempt at https://crrev.com/c/999182: - fix flakiness in two additional ChromeOS login tests - fix CSP WPT tests to not depend on ordering between iframe's onload and postMessage - see https://crbug.com/832319. Previously, we sent the IPC to forward a cross-process postMessage immediately. This caused a behavioral difference from the same-process case where the postMessage is always scheduled. Namely, in a scenario like this: frame.postMessage(...); doSomethingThatSendsIPCsToFrame(frame); the IPCs from JS following the postMessage would've been ordered incorrectly, causing |frame| to see their side effects after the postMessage dispatch in the cross-process case, whereas they would be seen before the postMessage dispatch in the same-process case. One example of this is frame.focus(), and another is a frame element onload event (dispatched via FrameHostMsg_DispatchLoad) arriving after a postMessage dispatched from an inline script while the frame was still loading. To resolve these ordering concerns, this CL changes cross-process postMessage to do a PostTask on the sender side before sending the message to the browser process. This improves the current state of the world, but does not yet achieve a perfect match for the IPC ordering in the same-process case - see discussion on the bug. Bug: 828529 Change-Id: I62a627c501526d09900be4f5bd2c899acf4d1e07 Reviewed-on: https://chromium-review.googlesource.com/999182 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#550284} Reviewed-on: https://chromium-review.googlesource.com/1011287 Cr-Commit-Position: refs/heads/master@{#550621} | 13 April 2018, 15:40:47 UTC |
f6787be | Eric Willigers | 13 April 2018, 15:13:19 UTC | Accept variation in serialization of 'background' Serialization of the CSS property 'background' varies across browsers. There is an open spec issue: https://github.com/w3c/csswg-drafts/issues/418 Until the issue is resolved, we accept a variety of serializations. | 13 April 2018, 15:22:50 UTC |
f90d3d6 | Andreas Tolfsen | 13 April 2018, 13:33:50 UTC | Test serialisation of collections in wdspec. Ports tests added to Marionette in bug 1284232 to WPT. These test that the Arguments, Array, FileList, HTMLAllCollection, HTMLCollection, HTMLFormControlsCollection, HTMLOptionsCollection, and NodeList collections are properly serialised when returned from an injected script. There is one failing test that needs more investigation. My current suspicion is that it is a JavaScript bug. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1453009 gecko-commit: 172094bca9a6e2f841e629aae292647e212d92c6 gecko-integration-branch: central gecko-reviewers: whimboo | 13 April 2018, 13:46:58 UTC |
4c8580c | Ian Clelland | 13 April 2018, 01:59:02 UTC | Allow feature policy to be used in opaque origins. Currently, policy-controlled features do not work as expected in frames with opaque origins, such as isolated sandboxes and data: URLs, because the eventual opaque origin of the frame is not known when the HTMLFrameOwnerElement builds the container policy, and so has no way to tell the browser that a particular origin should be allowed. This CL adds a new member to the ParsedFeaturePolicyDeclaration, which indicates that the iframe policy is expected to apply to the origin of the frame, and is used when that frame has an opaque origin. This can be triggered with an iframe of the form <iframe sandbox allow="feature"> or <iframe sandbox allow="feature src"> This flag is checked when building the feature policy in the new frame, and ensures that the new feature policy will allow the feature in that origin. This is the first part of the eventual solution -- currently this has the effect of allowing the feature even if a sandboxed frame navigates to a new page (causing a new opaque origin to be created for it). Subsequent CLs will add a unique identified to each such origin, and ensure that the generated policies are properly tied to the specific origin of the frame. Bug: 690520 Change-Id: Ie18b9bc3c36be6550baf5a03e355871b9589fd40 Reviewed-on: https://chromium-review.googlesource.com/963382 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#550463} | 13 April 2018, 12:05:15 UTC |