https://github.com/angular/angular

sort by:
Revision Author Date Message Commit Date
b184f0a refactor: fix various typos across different packages (#44523) simply fix different unrelated typos present in various packages PR Close #44523 07 January 2022, 18:11:10 UTC
277d2af docs(common): use <em> instead of <i> in examples (#44648) Updated the html tag format from <i> to <em> in ts file. <em> tag helps to improve the code quality PR Close #44648 07 January 2022, 18:10:47 UTC
de93b6e refactor(compiler-cli): update template typechecking link to latest angular.io version (#44649) This page exists in the most recent angular.io version (v13 currently), so there's no need to link to an old version. The hash also refers to the title section of the page, which isn't necessary and is now dropped. PR Close #44649 07 January 2022, 18:10:19 UTC
21f8d12 release: cherry-pick the v12.2.15 release notes (#44619) PR Close #44619 07 January 2022, 18:09:40 UTC
cc6380c release: cherry-pick the v12.2.14 release notes (#44341) (#44619) resolves #44475 PR Close #44619 07 January 2022, 18:09:40 UTC
0cf5501 build: use correct target name (#44651) Dev mode output was switched from ES5 -> ES2015 recently and as a part of those changes, some target names that contained `_es5` postfixes were changes to `_es2015` instead. This commit fixes the issue with one of the recently merged BUILD files that contained the old (`_es5`) postfix. PR Close #44651 07 January 2022, 00:42:22 UTC
bb346fc docs(common): url link format updated (#44645) fix the url link format from http to https in BAZEL.md && component-styles.md PR Close #44645 06 January 2022, 23:49:47 UTC
84ff67f build: update .bazelversion (#44641) Update to the latest version of bazel. PR Close #44641 06 January 2022, 23:49:02 UTC
f8af49e fix(compiler-cli): fix crash during type-checking of library builds (#44587) When building a library, the `rootDir` option is configured to ensure that all source files are present within the entry-point that is being build. This imposes an extra constraint on the reference emit logic, which does not allow emitting a reference into a source file outside of this `rootDir`. During the generation of type-check blocks we used to make a best-effort estimation of whether a type reference can be emitted into the type-check file. This check was relaxed in #42492 to support emitting more syntax forms and type references, but this change did not consider the `rootDir` constraint that is present in library builds. As such, the compiler might conclude that a type reference is eligible for emit into the type-check file, whereas in practice this would cause a failure. This commit changes the best-effort estimation into a "preflight" reference emit that is fully accurate as to whether emitting a type reference is possible. Fixes #43624 PR Close #44587 06 January 2022, 23:44:24 UTC
1955d0a refactor(compiler-cli): implement `realpath` in `NgtscCompilerHost` (#44587) The `NgtscCompilerHost` is implemented using the `FileSystem` abstraction of the compiler, which is implemented for tests using an in-memory `MockFileSystem`. If the in-memory filesystem contains symlinks, then using `NgtscCompilerHost` would not reflect their resolved real path. Instead, the TypeScript compiler would use its default implementation based on the real filesystem, which is unaware of the in-memory `MockFileSystem` setup. This change does not currently address any issues, but is being fixed as it prevented a reproduction scenario from behaving correctly. PR Close #44587 06 January 2022, 23:44:24 UTC
03edc7d test(compiler-cli): properly support symlinks in `MockFileSystem` (#44587) This commit fixes an issue with symlink handling in `MockFileSystem`, where entries within a symlink would fail to resolve. PR Close #44587 06 January 2022, 23:44:24 UTC
c1a9bb3 refactor(compiler-cli): use `absoluteFromSourceFile` to obtain a source file path (#44587) Using `absoluteFromSourceFile` leverages the cache of the resolved absolute path, instead of having to compute it each time. PR Close #44587 06 January 2022, 23:44:24 UTC
7052e27 refactor(compiler-cli): improve DX for reference emit failures (#44587) In certain scenarios, the compiler may have crashed with an `Unable to write a reference` error which would be particularly hard to diagnose. One of the primary reasons for this failure is when the `rootDir` option is configured---typically the case for libraries--- and a source file is imported using a relative import from an external entry-point. This would normally report TS6059 for the invalid relative import, but the crash prevents this error from being surfaced. This commit refactors the reference emit logic to result in an explicit `Failure` state with a reason as to why the failure occurred. This state is then used to report a `FatalDiagnosticException`, preventing a hard crash. Closes #44414 PR Close #44587 06 January 2022, 23:44:24 UTC
67df935 refactor(forms): use shared RuntimeError class (#44398) This commit performs some refactoring of the AbstractControl-based classes to employ shared `RuntimeError` class and also updates the code to avoid duplication and improve minification. PR Close #44398 06 January 2022, 23:43:19 UTC
a84f99f refactor(core): move runtime error code logic (#44398) This commit moves some logic to make the location of runtime error codes consistent across packages. Now all error codes are located in `packages/core/src/errors.ts` file. PR Close #44398 06 January 2022, 23:43:18 UTC
66e59bc refactor(core): make RuntimeError reusable across packages (#44398) This commit updates the code around the `RuntimeError` class to make it more reusable between packages (currently it's only usable inside the `core` package). Specifically: - the error formatting logic was updated to handle cases when there is no error message provided - there is no special Set that contains a set of error codes for which we have guides on angular.io. Instead, this is now encoded into the error code itself (making such codes negative integers). Having a separate Set makes it non-tree-shakable, which we want to avoid. This change should allow to employ the `RuntimeError` class in other packages to further standardize this subsystem and make the errors thrown by the framework consistent. As a part of the refactoring, the `common` package code was also updated to follow the same logic as `core`, since the `RuntimeError` class was used there as well. PR Close #44398 06 January 2022, 23:43:18 UTC
7b9169e docs(animations): fix grammar (#44607) Fix grammar issues based on suggestions in issue #44403 Fixes #44403 PR Close #44607 06 January 2022, 18:40:02 UTC
7f51f1d docs(docs-infra): improve the content of attribute directives (#44628) Improve docs "Understanding Angular-Directives-Attribute Directives" In `highlight.directive.1.ts`, add the `private` keyword for `el` property to make it correct and consistent with subsequent examples. For section "Setting the value with user input", add a step to tell the reader change the method `onMouseEnter`, thus more readable. For section "Binding to a second property", delete the aliase for the `Input` property, and changes the name back to `appHighlight` in the code to make it consistent with the whole tutorial. PR Close #44628 06 January 2022, 18:36:46 UTC
3591032 test: clean up more entryComponents usages (#44561) Cleans up some more tests that were using `entryComponents`. PR Close #44561 06 January 2022, 18:36:22 UTC
ea91edb docs: fix typos in using libraries guide (#44634) correct word typically, typescript and import PR Close #44634 06 January 2022, 00:23:06 UTC
b69a514 docs(animations): fix links to the AnimationBuilder.build method (#44594) In angular.io links to the AnimationBuilder.build method are broken and do not point to the api docs page, fix such broken links Also apply minor wording and related improvements PR Close #44594 06 January 2022, 00:22:43 UTC
2d14724 docs(common): url link format updated (#44638) fix the url link format from http to https in i18-common-locale-id.md file PR Close #44638 05 January 2022, 23:21:10 UTC
e39f804 test(upgrade): fix flaky tests (#44597) Fixes a couple of tests that have been flaking our test runs. The two tests actually failed consistently when run in isolation, but they passed if at least one test ran before them. My understanding was that they failed, because they were running outside of the `NgZone` which meant that the errors being thrown inside of a `Promise` weren't being flushed. PR Close #44597 05 January 2022, 23:20:43 UTC
12e0424 ci: temporarily disable components-repo-unit-tests job (#44505) Temporarily disables the components repo unit tests job that breaks due to us changing the devmode output to ES2015 in Angular Bazel. This is a trivial thing to solve in the COMP repo but the job needs to be disabled first, so that the changes can be released. PR Close #44505 05 January 2022, 23:20:21 UTC
d60ebaa test: update example di tests to work with es2015 (#44505) * `forwardRef` does not work with ES2015 and TypeScript's decorator downlevel emit. This is a known limitation we work around in Angular applications by either compiling tests with the Angular compiler, or by running a custom decorator downlevel transform (like in the CLI). PR Close #44505 05 January 2022, 23:20:21 UTC
807c6a4 test: update acceptance core tests to work with es2015 (#44505) Updates the acceptance core tests to work with ES2015 devmode output. There were two issues surfacing: * The NodeJS test execution failed because Domino does not handle destructuring syntax properly. This is because `Node.children` is not an iterable. * `forwardRef` does not work with ES2015 and TypeScript's decorator downlevel emit. This is a known limitation we work around in Angular applications by either compiling tests with the Angular compiler, or by running a custom decorator downlevel transform (like in the CLI). PR Close #44505 05 January 2022, 23:20:21 UTC
92806ff test: update router tests to work with es2015 temporal dead zone (#44505) Update router tests to work with the the es2015 temporal dead zone. Somewhat similar to: https://github.com/angular/angular/issues/30106. PR Close #44505 05 January 2022, 23:20:20 UTC
890d069 test: update ngtsc specs to work with es2015 output (#44505) Updates the ngtsc specs to work with ES2015 output. PR Close #44505 05 January 2022, 23:20:20 UTC
c46d533 build: switch devmode output to es2015 (#44505) To make our test output i.e. devmode output more aligned with what we produce in the NPM packages, or to be more aligned with what Angular applications will usually consume, the devmode output is switched from ES5 to ES2015. Additionally various tsconfigs (outside of Bazel) have been updated to match with the other parts of the build. The rules are: ES2015 for test configurations, ES2020 for actual code that will end up being shipped (this includes the IDE-only tsconfigs). PR Close #44505 05 January 2022, 23:20:20 UTC
8388151 refactor(forms): make validators code compatible with property renaming (#44500) This commit refactors the code of the base validators class to make it compatible with the property renaming optimization. Currently the code makes an assumption that the field with a specified name (defined as a string) can be found on an object, but with property renaming optimization this is not correct. PR Close #44500 05 January 2022, 18:43:36 UTC
6a55aff docs(router): fix code block for IsActiveMatchOptions (#44635) PR Close #44635 05 January 2022, 17:47:08 UTC
7278a9c docs(animations): fix filter-animations docregion (#44544) the filter animation example in the complex-animation-sequences guide talks about entering and leaving elements, but the presented html snipped exluded the *ngFor which actually adds and removes the elements, so add the *ngFor section to make the example complete and understandable PR Close #44544 05 January 2022, 17:46:10 UTC
d5ced77 refactor(docs-infra): fix eslint issues for aio ugrade-* examples (#44534) fix the eslint issues in the aio/content/examples/upgrade-* folders and remove their ignorePattern in the examples eslintrc file PR Close #44534 05 January 2022, 00:34:06 UTC
c7ac2df refactor(compiler): remove output AST functions (#44411) These functions are not used anymore so they are removed. PR Close #44411 04 January 2022, 23:54:10 UTC
d196cbc refactor(compiler): remove class related output AST types (#44411) The Ivy compiler no longer generates classes so this commit removes the supporting output nodes. PR Close #44411 04 January 2022, 23:54:10 UTC
8cadfe1 refactor(compiler): remove type-casting related output AST types (#44411) The Ivy compiler no longer generates code for type-checking purposes using the output AST types. Instead, it uses TypeScript AST nodes and its printer for type-checking. This commit removes the type-related output nodes. PR Close #44411 04 January 2022, 23:54:10 UTC
f352c2b refactor(compiler): remove some unused output AST types (#44411) This kind of output is no longer emitted into generated code, so the supporting output AST is removed. PR Close #44411 04 January 2022, 23:54:10 UTC
e0458a6 refactor(compiler): remove unused method from binding parser (#44411) This method is no longer called so is being removed. PR Close #44411 04 January 2022, 23:54:10 UTC
b5ad12b refactor(compiler): make template preparser null-safe (#44411) This commit removes some non-null assertion operations to improve null-safety. PR Close #44411 04 January 2022, 23:54:10 UTC
f40802f refactor(compiler): remove unused `unsupported` function (#44411) This function is no longer used so is being removed. PR Close #44411 04 January 2022, 23:54:10 UTC
d9befd2 refactor(compiler): make `keySpan` required in binding parser (#44411) Now that ViewEngine has been removed the `keySpan` property can be made required, as it is always provided in the Ivy compiler PR Close #44411 04 January 2022, 23:54:10 UTC
f86e02e refactor(compiler): cleanup distinction in parse logic (#44411) This removes the special casing of parse-validation logic that was only used by Ivy. PR Close #44411 04 January 2022, 23:54:10 UTC
a758b88 refactor(compiler): remove `BindingForm` enum (#44411) The Ivy compiler only uses `BindingForm.Expression`, so all other variants are removed. PR Close #44411 04 January 2022, 23:54:10 UTC
da159a5 refactor(compiler): cleanup AST fixup of listener instructions (#44411) This commit refactors the generation of listener instructions to no longer fixup the output AST that was designed for ViewEngine. PR Close #44411 04 January 2022, 23:54:09 UTC
7862f56 refactor(compiler): remove unused assertion function (#44411) This code is no longer used now that ViewEngine has been removed. PR Close #44411 04 January 2022, 23:54:09 UTC
e8812bc refactor(compiler): cleanup unsafe usage of `null` value for ng-content selector (#44411) This commit improves the null-safety of the ng-content selector and updates a comment that turned out to be slightly inaccurate. Closes #38407 PR Close #44411 04 January 2022, 23:54:09 UTC
722d8ef refactor(compiler): remove unused code from output logic (#44411) This code is no longer used now that ViewEngine has been removed. PR Close #44411 04 January 2022, 23:54:09 UTC
26eee35 refactor(compiler): remove unused `AstPath` (#44411) This code is no longer used now that ViewEngine has been removed. PR Close #44411 04 January 2022, 23:54:09 UTC
a0c36ac refactor(compiler): remove unused logic from `ConstantPool` (#44411) The `ConstantPool.getDefinition` method is not being used anymore, so this commit removes anything that is related to this method. PR Close #44411 04 January 2022, 23:54:09 UTC
f3de922 refactor(compiler): remove unused type declarations (#44411) This code is no longer used now that ViewEngine has been removed. PR Close #44411 04 January 2022, 23:54:09 UTC
1d39a5e refactor(compiler): remove syntax error logic (#44411) This code is no longer used now that ViewEngine has been removed. PR Close #44411 04 January 2022, 23:54:09 UTC
f2b858d refactor(animations): add unit test for leaving animated child (#44489) add a new unit test to make sure that leaving elements queried via a parent queried via animateChild are correctly removed note: this tests the fix introduced in PR #44357 PR Close #44489 04 January 2022, 23:53:36 UTC
d4015f7 test: remove newlines to make a test more stable (#44616) One of the tests was not taking into account newlines in the text content of an element, thus failing in some browsers. This commit makes the test more stable by removing newlines and comparing the output after that. PR Close #44616 04 January 2022, 23:53:00 UTC
a864d1c fix(docs-infra): adjust code link styling height (#44376) the height of code links (anchors inside code tags or code tags inside anchors) is inconsistent, fix such issue by also making sure that code links to external resources do not get wrongly styled PR Close #44376 04 January 2022, 20:19:08 UTC
7663dd0 docs(animations): add links to `state()` references (#44376) the keyword 'state' is included in the `ignoredWords` set that prevents certain words to be autolinked, this causes the animations' state function not to be automatically linked, so manually link those references to the state api docs PR Close #44376 04 January 2022, 20:19:08 UTC
5ae1030 feat(forms): Add an unused symbol `AnyForUntypedForms`. (#44467) This symbol will support the typed forms migration in google3. The docs will be updated once the migration begins. Pertains to #13721. PR Close #44467 04 January 2022, 20:18:26 UTC
f0b4c70 docs: fix code sample indentation (#44517) PR Close #44517 04 January 2022, 20:15:55 UTC
ed6e2d2 docs: fix ngOnChange description issue (#44582) ngOnChange respond when Angular sets or resets data-bound @input properties and description of the ngOnChanges should be `When an [input](#input) binding value changes` instead of `When an [input](#input)/[output](#output) binding value changes` resolves angular#44559 PR Close #44582 04 January 2022, 20:15:18 UTC
bfd94b3 docs: Replace OnInit with AfterViewInit (#44485) `this.adHost` is undefined if loadComponent is called in OnInit. So replace OnInit with AfterViewInit! PR Close #44485 04 January 2022, 20:14:44 UTC
3a29c57 test: update size goldens to reflect latest CLI devkit update (#44490) Updates the size goldens to the reflect the latest CLI devkit updates. PR Close #44490 04 January 2022, 20:14:14 UTC
7974564 build: update release config to reflect latest ng-dev config changes (#44490) The ng-dev release config changed its release configuration in order to support experimental packages. This commit updates the FW release config to work with the new config signature of ng-dev. All of our peackages are non-experimental, so we do not specify an explicit `experimental` property. PR Close #44490 04 January 2022, 20:14:14 UTC
c8cd5d5 build: switch all instances from `ng_rollup_bundle` to `app_bundle` (#44490) The `ng_rollup_bundle` rule has been replaced with a new rule called `app_bundle`. This rule replicates the Angular v13 optimization pipeline in the CLI, so that we can get better benchmarking results. Also the rule is much simpler to maintain as it relies on ESbuild. The old `ng_rollup_bundle` rule did rely on e.g. build-optimizer that no longer has an effect on v13 Angular packages, so technically size tests/symbol tests were no longer as correct as they were before. This commit fixes that. A couple of different changes and their explanation: * Language-service will no longer use the benchmark rule for creating its NPM bundles! It will use plain `rollup_bundle`. ESBuild would have been nice but the language-service relies on AMD that ESBuild cannot generate (yet?) * Service-worker ngsw-worker.js file was generated using the benchmark bundle rule. This is wrong. We will use a simple ESbuild rule in the future. The output is more predictable that way, and we can have a clear use of the benchmark bundle rule.. * A couple of benchmarks in `modules/` had to be updated to use e.g. `initTableUtils` calls. This is done because with the new rule, all files except for the entry-point are considered side-effect free. The utilities for benchmarks relied on side-effects in some transitively-loaded file (bad practice anyway IMO). We are now initializing the utilities using a proper init function that is exported... PR Close #44490 04 January 2022, 20:14:14 UTC
4e58a50 build: update postinstall script to account for local target references in dev-infra (#44490) We are in an inconvenient situation where the ng-dev package might rely on packages from the Angular framework repository. Given that we install this package in the framework repository, we need to update some references through a postinstall. This commit updates the patches to account for the latest changes in the dev-infra package/repository. PR Close #44490 04 January 2022, 20:14:14 UTC
d73c716 build: add postinstall script as runfile for `yarn_install` repository rule (#44490) Adds the postinstall script as runfile for the `yarn_install` repository rule, so that the dependencies are re-fetched when the script changes. PR Close #44490 04 January 2022, 20:14:14 UTC
c3a5568 build: update symbol extractor to support IIFE bundles using arrow-functions (#44490) Updates the symbol extractor to support IIFE bundles using arrow-functions instead of function declarations. This is in preparation for running symbol extraction tests with the overhauled optimization pipeline for Angular v13, relying on ESBuild internally. Also removes rollup-specific code that does not seem to be relevant anymore / rollup will be replaced anyway. PR Close #44490 04 January 2022, 20:14:14 UTC
02bc458 build: update angular (#44490) Updates Angular and the dev-infra package to the latest version/build. PR Close #44490 04 January 2022, 20:14:14 UTC
9d2401d docs: fix several typos (#44508) PR Close #44508 04 January 2022, 20:13:46 UTC
67c81cc refactor(docs-infra): improve aio-footer's layout (#44532) improve aio-footer's layout by using grid instead of flexbox, such change makes it so that we have four columns on wide window sizes (desktop), two columns on medium window sizes (desktop/tablet) and a single column on small window sizes (mobile), compared to the flex implementation which could only have either 4 columns or 1 this makes the footer look generally nicer for various window sizes (especially in the middle range in which one column was too little and four were too much) note: also a scroll of auto has been added so we that we can be sure that overflowing footer content never creates a global layout issue PR Close #44532 04 January 2022, 20:13:22 UTC
f7aa937 fix(forms): Make some minor fixups for forward-compatibility with typed forms. (#44540) Make the following fixes: * When submitting the entire migration in a disabled state, I commented out more code than strictly required * Responding to some final review comments caused two conditions to become flipped * Always use explicit checks instead of boolean corecion * Fix one missed any cast in a test case PR Close #44540 04 January 2022, 20:10:56 UTC
7cb2999 docs: add missing npm install instruction (#44574) add missing npm install instruction to start->deploying an application Fixes #44542 PR Close #44574 04 January 2022, 20:07:37 UTC
756761d fix(language-service): revert the test files for Ivy (#44528) The `completions_spec` and `definitions_spec` is removed by accident in [bb9ff60](https://github.com/angular/angular/commit/bb9ff6003c620b3cf00232189d60097395382802) PR Close #44528 04 January 2022, 20:06:49 UTC
4f7a838 docs: Add breaking changes note to 13.0 release (#44518) A breaking change in v13 was identified post-release and needs to be noted in the breaking changes section to ensure developers are aware of it when upgrading. Resolves #44383 PR Close #44518 04 January 2022, 20:06:27 UTC
a8f153c docs(docs-infra): fix numbering of 'running your application locally' steps (#44575) fix numbering of 'running your application locally' steps and corrected step 1 statement. PR Close #44575 04 January 2022, 20:06:07 UTC
62a5027 docs: fixed meetup URL (#44585) PR Close #44585 04 January 2022, 20:05:45 UTC
79d1afa build: bump license year (#44590) The year has advanced by one cycle. In accordance with this practice, we increment the value of the bounding set of our license year by one. PR Close #44590 04 January 2022, 20:05:25 UTC
ca042be docs: update instructions for running `ng-dev misc build-and-link` command (#44604) Fixes #44571 PR Close #44604 04 January 2022, 20:05:04 UTC
6cdd66d docs(compiler): fix typo in `getHtmlTagDefinition()` function (#44601) PR Close #44601 04 January 2022, 20:04:04 UTC
a01c077 docs: remove Angular 10 from support table (#44611) PR Close #44611 04 January 2022, 20:03:37 UTC
af512de docs: fix invalid link of library support for npm packages guide (#44612) change link of library support to point to guide->creating-libraries fixes #44583 PR Close #44612 04 January 2022, 20:03:15 UTC
c6c75c9 docs: fix typo (#44592) PR Close #44592 04 January 2022, 18:59:58 UTC
58e8f5e ci: remove atscott for unavailable users (#44539) I am back from vacation so I can now be assigend PRs to review PR Close #44539 04 January 2022, 18:38:42 UTC
8ebc946 docs: remove recent departures from contributors page (#44514) PR Close #44514 16 December 2021, 19:29:29 UTC
28eecf5 release: cut the v13.2.0-next.1 release (#44497) PR Close #44497 15 December 2021, 20:21:51 UTC
5370c20 docs: release notes for the v13.1.1 release (#44496) PR Close #44496 15 December 2021, 20:00:04 UTC
7c246d5 fix(docs-infra): update examples to Angular 13.1 (#44487) Updates AIO and the live examples to 13.1.0 in order to resolve a build error when opened on Stackblitz. They were using TS 4.5 with Angular ~13.0.0 which doesn't support 4.5. Fixes #44480. PR Close #44487 15 December 2021, 18:22:14 UTC
9921b2c feat(core): Add a migration for typed forms. (#44449) This migration will insert `<AnyForUntypedForms>` or `<AnyForUntypedForms[]>` at existing uses of `AbstractControl` classes, as well as calls to `FormBuilder` methods. We need to submit this ahead of time in order to get started with the migration in google3. PR Close #44449 15 December 2021, 18:20:33 UTC
835987b refactor(docs-infra): use eslint in aio's example-lint script (#43218) Instead of the deprecated tslint use eslint in the aio's example-lint script PR Close #43218 15 December 2021, 17:28:46 UTC
6a0dadf fix(forms): `_reduceValue` arrow function now has correct types. (#44483) I previously strengthened some weak types in #44370. One of these fixes exposed an incorrect call into `_reduceChildren` from `_reduceValue`. This was caught in google3 by a caller who was extending `FormGroup` and overriding these methods. Special thanks to Bart G for catching this issue and suggesting a fix. PR Close #44483 15 December 2021, 17:27:06 UTC
72092eb feat(forms): Allow a FormControl to use initial value as default. (#44434) Allow a FormControl to be reset to its initial value. Provide this feature via a new option in a FormControlOptions interface, based on AbstractControlOptions. Also, expose the default value as part of the public API. This is part of a feature that has been requested elsewhere (e.g. in #19747). This was originally proposed as part of typed forms. As discussed in the GDE session (and after with akushnir/alxhub), it is likely better to just reuse the initial value rather than accepting an additional default. It is desirable to land this separately in order to reduce the scope of the typed forms PR, and make it a types-only change. Pertains to issue #13721. PR Close #44434 15 December 2021, 15:36:13 UTC
4aa6965 test(docs-infra): Correct an invalid assumption in aio tests. (#44479) The aio application expects `FormControl` to have no properties for the purposes of its own internal tests, but this is no longer true after #44434. PR Close #44479 14 December 2021, 21:14:47 UTC
093fd39 refactor(compiler): clean up workarounds for TypeScript 4.5 (#44477) Cleans up some of the temporary workarounds that were necessary in order to land support for TypeScript 4.5 since they're no longer necessary. PR Close #44477 14 December 2021, 21:14:02 UTC
d640fa7 docs: Fixed typo 'test' => 'text' (#44464) PR Close #44464 14 December 2021, 21:12:57 UTC
f394831 refactor(animations): remove the unused enter and leave selectors (#44460) remove the no longer used ENTER_SELECTOR and LEAVE_SELECTOR constants note: their uses have been removed in PR #19455 PR Close #44460 14 December 2021, 21:12:35 UTC
f56ac0f refactor(animations): improve _finalKeyframe non-null assertion (#44458) instead of declaring the WebAnimationsPlayer's _finalKeyframe field with a non-null assertion, declare it as optional field and use a non-null assertion only when it is being used in the beforeDestroy function relates to #24571 PR Close #44458 14 December 2021, 21:12:11 UTC
5da31d6 test(forms): Add more tests for `FormBuilder` method argument shapes. (#44452) It is possible to pass arguments to `FormBuilder` using four different formats: value-only, boxed value, control config, and value-array. Currently, these different methods are not well-tested, especially as they interact. This PR will add tests for the variety of different argument shapes. This was originally inspired by typed forms: when `FormBuilder` becomes typed, all these argument shapes should just work, with correct inferred types. PR Close #44452 14 December 2021, 21:11:29 UTC
6571799 refactor(forms): Make the minimum changes to the forms unit tests in order to support the typed forms PR (#43834). (#44451) Currently, many of our unit tests are written to use heterogenous groups and arrays, and controls that accept heterogenous values. This PR will make the minimum possible alterations to prepare those usages, mainly by annotating them as untyped controls, etc. This PR is *not* intended to test typed forms, merely to minimize the size of the upcoming PR. This will allow that PR to be focused on the actual features and tests, rather than boilerplate fixes. PR Close #44451 14 December 2021, 21:10:08 UTC
815d4ce fix(forms): I indroduced a minor error in a previous PR: pendingValue is a value not a boolean flag. (#44450) The bug should have no effect since it's a typings-only, internal-only bug, but it's good to fix nonetheless. PR Close #44450 14 December 2021, 21:09:42 UTC
e483993 test(ngcc): don't use the workspace typescript version to generate integration test fixtures (#44448) Now that ViewEngine libraries can no longer be created, the latest TypeScript version that ngcc should be able to process is TypeScript 4.3, i.e. the version of TypeScript that was supported in Angular 12. However, ngcc's integration tests used the TypeScript version of the workspace to create the JavaScript files from TypeScript sources on demand. This introduces friction when upgrading the TypeScript version within the workspace, as changes to TypeScript's emit format may affect ngcc's ability to process it correctly. The on demand creation of JavaScript files was convenient for authoring tests, but it also helped to detect incompatibilities with newer versions of TypeScript. Now that ngcc no longer has to process newer versions of TypeScript, we want to pin the integration suite to use JavaScript code as if it were compiled using TypeScript 4.3, i.e. a version of TypeScript that is actually supported by ngcc. This commit updates the integration test to inline all the generated files directly in the tests, instead of compiling them on demand. This was done by temporarily installing TypeScript 4.3 and using it to create the `loadTestFiles` statement from the original TypeScript inputs. An alternative could have been to install TypeScript 4.3 as an actual dependency in the workspace and using that to continue compiling the integration suite on demand, but this brings some overhead in package installations (TypeScript is ~60MB) and the authoring aspect of ngcc integration test is expected to diminish, now that ngcc's support is no longer a moving target. PR Close #44448 14 December 2021, 21:08:28 UTC
ab2248e docs(docs-infra): change variable names in route guards examples (#44444) change variable name 'next' to 'route' in route guards examples on developer guides "Routing and Navigation Tutorial: Adding routing to Tour of Heroes" to make it consistent with api docs and subsequent examples. Fixes #44291 PR Close #44444 14 December 2021, 21:08:05 UTC
12f7c85 docs: fix typo (#44427) `name` instead of `id` PR Close #44427 14 December 2021, 21:07:22 UTC
back to top