https://github.com/GPflow/GPflow
Revision deb4508578f7223fa1ad5e3b6458626c4b41ef09 authored by Eric Hammy on 17 October 2019, 14:46:42 UTC, committed by GitHub on 17 October 2019, 14:46:42 UTC
1. Fix hidden bug in SGPR 2. Add the sgpr.compute_qu method from gpflow1 1. [Bug]. SGPR likelihoods were previously using full rank matrices instead of diagonal ones in both upper bound and likelihood calculation. Ie `Kdiag` was not "diag". This error was being masked by the intentional deactivation of tests comparing to the SGPR to the GPR, and what appears to be a hack to make tests working on the upper bound case. 2. [Migration]. Fixing the above broke another test, originally used for sgpr.compute_qu. The method sgpr.compute_qu had not been migrated from gpflow1, and a test that was meant to check it had been patched up to pass, erroneously. After speaking to @markvdw, concluded this method is useful, in particular to compare to SVGP model. The test has been patched up and the method ported to gpflow2.
1 parent 3b2a2ee
Tip revision: deb4508578f7223fa1ad5e3b6458626c4b41ef09 authored by Eric Hammy on 17 October 2019, 14:46:42 UTC
Fix hidden bug in SGPR (#1106)
Fix hidden bug in SGPR (#1106)
Tip revision: deb4508
File | Mode | Size |
---|---|---|
.circleci | ||
.github | ||
doc | ||
gpflow | ||
tests | ||
.coveragerc | -rw-r--r-- | 286 bytes |
.coveralls.yml | -rw-r--r-- | 23 bytes |
.gitignore | -rw-r--r-- | 811 bytes |
.pylintrc | -rw-r--r-- | 14.6 KB |
GLOSSARY.md | -rw-r--r-- | 1.4 KB |
LICENSE | -rw-r--r-- | 11.1 KB |
MANIFEST.in | -rw-r--r-- | 158 bytes |
Makefile | -rw-r--r-- | 597 bytes |
README.md | -rw-r--r-- | 5.2 KB |
RELEASE.md | -rw-r--r-- | 6.9 KB |
VERSION | -rw-r--r-- | 7 bytes |
codecov.yml | -rw-r--r-- | 274 bytes |
contributing.md | -rw-r--r-- | 7.3 KB |
notebooks | l--------- | 21 bytes |
setup.py | -rw-r--r-- | 2.1 KB |
tests_requirements.txt | -rw-r--r-- | 108 bytes |
Computing file changes ...