Skip to main content

Browse the archive

https://github.com/postgres/postgres
07 April 2024, 13:56:23 UTC
Revision dece64a941457686184654968ac1ded58b7d4ee8 authored by David Rowley on 26 July 2021, 02:56:09 UTC, committed by David Rowley on 26 July 2021, 02:56:09 UTC 
Fix incorrect comment for get_agg_clause_costs
 
Adjust the header comment in get_agg_clause_costs so that it matches what
the function currently does.  No recursive searching has been done ever
since 0a2bc5d61.  It also does not determine the aggtranstype like the
comment claimed. That's all done in preprocess_aggref().
preprocess_aggref also now determines the numOrderedAggs, so remove the
mention that get_agg_clause_costs also calculates "counts".

Normally, since this is just an adjustment of a comment it might not be
worth back-patching, but since this code is new to PG14 and that version
is still in beta, then it seems worth having the comments match.

Discussion: https://postgr.es/m/CAApHDvrrGrTJFPELrjx0CnDtz9B7Jy2XYW3Z2BKifAWLSaJYwQ@mail.gmail.com
Backpatch-though: 14
1 parent b0d2867
History
Tip revision: dece64a941457686184654968ac1ded58b7d4ee8 authored by David Rowley on 26 July 2021, 02:56:09 UTC
Fix incorrect comment for get_agg_clause_costs
Tip revision: dece64a
File Mode Size
config
contrib
doc
src
.dir-locals.el -rw-r--r-- 730 bytes
.editorconfig -rw-r--r-- 183 bytes
.git-blame-ignore-revs -rw-r--r-- 8.6 KB
.gitattributes -rw-r--r-- 1.5 KB
.gitignore -rw-r--r-- 504 bytes
COPYRIGHT -rw-r--r-- 1.2 KB
GNUmakefile.in -rw-r--r-- 4.2 KB
HISTORY -rw-r--r-- 277 bytes
Makefile -rw-r--r-- 1.6 KB
README -rw-r--r-- 1.2 KB
README.git -rw-r--r-- 721 bytes
aclocal.m4 -rw-r--r-- 490 bytes
configure -rwxr-xr-x 567.2 KB
configure.ac -rw-r--r-- 81.3 KB

README

back to top