Revision df88912a2165f56a7402db80126cf8ea075221fe authored by Andrew Morton on 20 May 2006, 22:00:01 UTC, committed by Linus Torvalds on 21 May 2006, 19:59:17 UTC
Bernd Schmidt points out that binfmt_flat is now leaving the exec file open
while the application runs.  This offsets all the application's fd numbers.
We should have closed the file within exec(), not at exit()-time.

But there doesn't seem to be a lot of point in doing all this just to avoid
going over RLIMIT_NOFILE by one fd for a few microseconds.  So take the EMFILE
checking out again.  This will cause binfmt_flat to again fail LTP's
exec-should-return-EMFILE-when-fdtable-is-full test.  That test appears to be
wrong anyway - Open Group specs say nothing about exec() returning EMFILE.

Cc: Bernd Schmidt <bernd.schmidt@analog.com>
Cc: Greg Ungerer <gerg@uclinux.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
1 parent 48d7055
History
File Mode Size
configs
dig
hp
ia32
kernel
lib
mm
oprofile
pci
scripts
sn
Kconfig -rw-r--r-- 12.5 KB
Kconfig.debug -rw-r--r-- 1.9 KB
Makefile -rw-r--r-- 3.0 KB
defconfig -rw-r--r-- 28.6 KB
install.sh -rw-r--r-- 946 bytes
module.lds -rw-r--r-- 355 bytes

back to top