Revision df9576def004d2cd5beedc00cb6e8901427634b9 authored by Yang Shi on 03 August 2019, 04:48:37 UTC, committed by Linus Torvalds on 03 August 2019, 14:02:00 UTC
When running ltp's oom test with kmemleak enabled, the below warning was
triggerred since kernel detects __GFP_NOFAIL & ~__GFP_DIRECT_RECLAIM is
passed in:
WARNING: CPU: 105 PID: 2138 at mm/page_alloc.c:4608 __alloc_pages_nodemask+0x1c31/0x1d50
Modules linked in: loop dax_pmem dax_pmem_core ip_tables x_tables xfs virtio_net net_failover virtio_blk failover ata_generic virtio_pci virtio_ring virtio libata
CPU: 105 PID: 2138 Comm: oom01 Not tainted 5.2.0-next-20190710+ #7
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.10.2-0-g5f4c7b1-prebuilt.qemu-project.org 04/01/2014
RIP: 0010:__alloc_pages_nodemask+0x1c31/0x1d50
...
kmemleak_alloc+0x4e/0xb0
kmem_cache_alloc+0x2a7/0x3e0
mempool_alloc_slab+0x2d/0x40
mempool_alloc+0x118/0x2b0
bio_alloc_bioset+0x19d/0x350
get_swap_bio+0x80/0x230
__swap_writepage+0x5ff/0xb20
The mempool_alloc_slab() clears __GFP_DIRECT_RECLAIM, however kmemleak
has __GFP_NOFAIL set all the time due to d9570ee3bd1d4f2 ("kmemleak:
allow to coexist with fault injection"). But, it doesn't make any sense
to have __GFP_NOFAIL and ~__GFP_DIRECT_RECLAIM specified at the same
time.
According to the discussion on the mailing list, the commit should be
reverted for short term solution. Catalin Marinas would follow up with
a better solution for longer term.
The failure rate of kmemleak metadata allocation may increase in some
circumstances, but this should be expected side effect.
Link: http://lkml.kernel.org/r/1563299431-111710-1-git-send-email-yang.shi@linux.alibaba.com
Fixes: d9570ee3bd1d4f2 ("kmemleak: allow to coexist with fault injection")
Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
Suggested-by: Catalin Marinas <catalin.marinas@arm.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: David Rientjes <rientjes@google.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Qian Cai <cai@lca.pw>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 68d8681
| File | Mode | Size |
|---|---|---|
| partitions | ||
| Kconfig | -rw-r--r-- | 5.8 KB |
| Kconfig.iosched | -rw-r--r-- | 1.3 KB |
| Makefile | -rw-r--r-- | 1.5 KB |
| badblocks.c | -rw-r--r-- | 14.1 KB |
| bfq-cgroup.c | -rw-r--r-- | 35.1 KB |
| bfq-iosched.c | -rw-r--r-- | 233.7 KB |
| bfq-iosched.h | -rw-r--r-- | 36.1 KB |
| bfq-wf2q.c | -rw-r--r-- | 52.3 KB |
| bio-integrity.c | -rw-r--r-- | 12.3 KB |
| bio.c | -rw-r--r-- | 54.1 KB |
| blk-cgroup.c | -rw-r--r-- | 46.2 KB |
| blk-core.c | -rw-r--r-- | 47.6 KB |
| blk-exec.c | -rw-r--r-- | 2.6 KB |
| blk-flush.c | -rw-r--r-- | 14.3 KB |
| blk-integrity.c | -rw-r--r-- | 11.4 KB |
| blk-ioc.c | -rw-r--r-- | 10.2 KB |
| blk-iolatency.c | -rw-r--r-- | 28.0 KB |
| blk-lib.c | -rw-r--r-- | 10.2 KB |
| blk-map.c | -rw-r--r-- | 6.0 KB |
| blk-merge.c | -rw-r--r-- | 20.6 KB |
| blk-mq-cpumap.c | -rw-r--r-- | 1.9 KB |
| blk-mq-debugfs-zoned.c | -rw-r--r-- | 435 bytes |
| blk-mq-debugfs.c | -rw-r--r-- | 24.4 KB |
| blk-mq-debugfs.h | -rw-r--r-- | 2.7 KB |
| blk-mq-pci.c | -rw-r--r-- | 1.3 KB |
| blk-mq-rdma.c | -rw-r--r-- | 1.3 KB |
| blk-mq-sched.c | -rw-r--r-- | 14.1 KB |
| blk-mq-sched.h | -rw-r--r-- | 2.5 KB |
| blk-mq-sysfs.c | -rw-r--r-- | 8.6 KB |
| blk-mq-tag.c | -rw-r--r-- | 14.4 KB |
| blk-mq-tag.h | -rw-r--r-- | 2.3 KB |
| blk-mq-virtio.c | -rw-r--r-- | 1.3 KB |
| blk-mq.c | -rw-r--r-- | 85.8 KB |
| blk-mq.h | -rw-r--r-- | 7.8 KB |
| blk-pm.c | -rw-r--r-- | 6.6 KB |
| blk-pm.h | -rw-r--r-- | 1.4 KB |
| blk-rq-qos.c | -rw-r--r-- | 6.5 KB |
| blk-rq-qos.h | -rw-r--r-- | 4.4 KB |
| blk-settings.c | -rw-r--r-- | 26.8 KB |
| blk-softirq.c | -rw-r--r-- | 3.7 KB |
| blk-stat.c | -rw-r--r-- | 4.6 KB |
| blk-stat.h | -rw-r--r-- | 4.6 KB |
| blk-sysfs.c | -rw-r--r-- | 26.2 KB |
| blk-throttle.c | -rw-r--r-- | 67.9 KB |
| blk-timeout.c | -rw-r--r-- | 3.8 KB |
| blk-wbt.c | -rw-r--r-- | 20.0 KB |
| blk-wbt.h | -rw-r--r-- | 3.0 KB |
| blk-zoned.c | -rw-r--r-- | 12.0 KB |
| blk.h | -rw-r--r-- | 10.5 KB |
| bounce.c | -rw-r--r-- | 9.3 KB |
| bsg-lib.c | -rw-r--r-- | 9.8 KB |
| bsg.c | -rw-r--r-- | 11.1 KB |
| cmdline-parser.c | -rw-r--r-- | 4.9 KB |
| compat_ioctl.c | -rw-r--r-- | 10.9 KB |
| elevator.c | -rw-r--r-- | 16.4 KB |
| genhd.c | -rw-r--r-- | 50.3 KB |
| ioctl.c | -rw-r--r-- | 15.4 KB |
| ioprio.c | -rw-r--r-- | 5.1 KB |
| kyber-iosched.c | -rw-r--r-- | 27.8 KB |
| mq-deadline.c | -rw-r--r-- | 20.6 KB |
| opal_proto.h | -rw-r--r-- | 9.3 KB |
| partition-generic.c | -rw-r--r-- | 17.4 KB |
| scsi_ioctl.c | -rw-r--r-- | 18.5 KB |
| sed-opal.c | -rw-r--r-- | 58.3 KB |
| t10-pi.c | -rw-r--r-- | 7.2 KB |
Computing file changes ...
