Revision df9576def004d2cd5beedc00cb6e8901427634b9 authored by Yang Shi on 03 August 2019, 04:48:37 UTC, committed by Linus Torvalds on 03 August 2019, 14:02:00 UTC
When running ltp's oom test with kmemleak enabled, the below warning was triggerred since kernel detects __GFP_NOFAIL & ~__GFP_DIRECT_RECLAIM is passed in: WARNING: CPU: 105 PID: 2138 at mm/page_alloc.c:4608 __alloc_pages_nodemask+0x1c31/0x1d50 Modules linked in: loop dax_pmem dax_pmem_core ip_tables x_tables xfs virtio_net net_failover virtio_blk failover ata_generic virtio_pci virtio_ring virtio libata CPU: 105 PID: 2138 Comm: oom01 Not tainted 5.2.0-next-20190710+ #7 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.10.2-0-g5f4c7b1-prebuilt.qemu-project.org 04/01/2014 RIP: 0010:__alloc_pages_nodemask+0x1c31/0x1d50 ... kmemleak_alloc+0x4e/0xb0 kmem_cache_alloc+0x2a7/0x3e0 mempool_alloc_slab+0x2d/0x40 mempool_alloc+0x118/0x2b0 bio_alloc_bioset+0x19d/0x350 get_swap_bio+0x80/0x230 __swap_writepage+0x5ff/0xb20 The mempool_alloc_slab() clears __GFP_DIRECT_RECLAIM, however kmemleak has __GFP_NOFAIL set all the time due to d9570ee3bd1d4f2 ("kmemleak: allow to coexist with fault injection"). But, it doesn't make any sense to have __GFP_NOFAIL and ~__GFP_DIRECT_RECLAIM specified at the same time. According to the discussion on the mailing list, the commit should be reverted for short term solution. Catalin Marinas would follow up with a better solution for longer term. The failure rate of kmemleak metadata allocation may increase in some circumstances, but this should be expected side effect. Link: http://lkml.kernel.org/r/1563299431-111710-1-git-send-email-yang.shi@linux.alibaba.com Fixes: d9570ee3bd1d4f2 ("kmemleak: allow to coexist with fault injection") Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com> Suggested-by: Catalin Marinas <catalin.marinas@arm.com> Acked-by: Michal Hocko <mhocko@suse.com> Cc: Dmitry Vyukov <dvyukov@google.com> Cc: David Rientjes <rientjes@google.com> Cc: Matthew Wilcox <willy@infradead.org> Cc: Qian Cai <cai@lca.pw> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 68d8681
File | Mode | Size |
---|---|---|
asymmetric_keys | ||
async_tx | ||
842.c | -rw-r--r-- | 3.7 KB |
Kconfig | -rw-r--r-- | 55.2 KB |
Makefile | -rw-r--r-- | 6.5 KB |
ablkcipher.c | -rw-r--r-- | 10.4 KB |
acompress.c | -rw-r--r-- | 4.5 KB |
adiantum.c | -rw-r--r-- | 20.8 KB |
aead.c | -rw-r--r-- | 11.0 KB |
aegis.h | -rw-r--r-- | 2.0 KB |
aegis128.c | -rw-r--r-- | 11.5 KB |
aegis128l.c | -rw-r--r-- | 14.1 KB |
aegis256.c | -rw-r--r-- | 12.2 KB |
aes_generic.c | -rw-r--r-- | 62.2 KB |
aes_ti.c | -rw-r--r-- | 12.6 KB |
af_alg.c | -rw-r--r-- | 25.5 KB |
ahash.c | -rw-r--r-- | 16.3 KB |
akcipher.c | -rw-r--r-- | 4.0 KB |
algapi.c | -rw-r--r-- | 28.6 KB |
algboss.c | -rw-r--r-- | 6.1 KB |
algif_aead.c | -rw-r--r-- | 15.8 KB |
algif_hash.c | -rw-r--r-- | 9.6 KB |
algif_rng.c | -rw-r--r-- | 5.2 KB |
algif_skcipher.c | -rw-r--r-- | 9.9 KB |
ansi_cprng.c | -rw-r--r-- | 10.7 KB |
anubis.c | -rw-r--r-- | 27.8 KB |
api.c | -rw-r--r-- | 13.7 KB |
arc4.c | -rw-r--r-- | 1.8 KB |
authenc.c | -rw-r--r-- | 14.0 KB |
authencesn.c | -rw-r--r-- | 15.1 KB |
blkcipher.c | -rw-r--r-- | 14.7 KB |
blowfish_common.c | -rw-r--r-- | 15.5 KB |
blowfish_generic.c | -rw-r--r-- | 3.2 KB |
camellia_generic.c | -rw-r--r-- | 34.3 KB |
cast5_generic.c | -rw-r--r-- | 20.5 KB |
cast6_generic.c | -rw-r--r-- | 9.1 KB |
cast_common.c | -rw-r--r-- | 12.9 KB |
cbc.c | -rw-r--r-- | 2.3 KB |
ccm.c | -rw-r--r-- | 24.6 KB |
cfb.c | -rw-r--r-- | 6.1 KB |
chacha20poly1305.c | -rw-r--r-- | 18.7 KB |
chacha_generic.c | -rw-r--r-- | 5.8 KB |
cipher.c | -rw-r--r-- | 3.1 KB |
cmac.c | -rw-r--r-- | 7.5 KB |
compress.c | -rw-r--r-- | 1.1 KB |
crc32_generic.c | -rw-r--r-- | 3.7 KB |
crc32c_generic.c | -rw-r--r-- | 4.2 KB |
crct10dif_common.c | -rw-r--r-- | 3.6 KB |
crct10dif_generic.c | -rw-r--r-- | 3.1 KB |
cryptd.c | -rw-r--r-- | 29.5 KB |
crypto_engine.c | -rw-r--r-- | 13.3 KB |
crypto_null.c | -rw-r--r-- | 5.3 KB |
crypto_user_base.c | -rw-r--r-- | 11.5 KB |
crypto_user_stat.c | -rw-r--r-- | 9.7 KB |
ctr.c | -rw-r--r-- | 10.1 KB |
cts.c | -rw-r--r-- | 12.0 KB |
deflate.c | -rw-r--r-- | 7.7 KB |
des_generic.c | -rw-r--r-- | 35.4 KB |
dh.c | -rw-r--r-- | 4.7 KB |
dh_helper.c | -rw-r--r-- | 3.4 KB |
drbg.c | -rw-r--r-- | 59.2 KB |
ecb.c | -rw-r--r-- | 2.4 KB |
ecc.c | -rw-r--r-- | 38.2 KB |
ecc.h | -rw-r--r-- | 7.6 KB |
ecc_curve_defs.h | -rw-r--r-- | 1.9 KB |
ecdh.c | -rw-r--r-- | 3.9 KB |
ecdh_helper.c | -rw-r--r-- | 2.1 KB |
echainiv.c | -rw-r--r-- | 4.3 KB |
ecrdsa.c | -rw-r--r-- | 8.3 KB |
ecrdsa_defs.h | -rw-r--r-- | 7.2 KB |
ecrdsa_params.asn1 | -rw-r--r-- | 142 bytes |
ecrdsa_pub_key.asn1 | -rw-r--r-- | 57 bytes |
fcrypt.c | -rw-r--r-- | 18.0 KB |
fips.c | -rw-r--r-- | 1.4 KB |
gcm.c | -rw-r--r-- | 31.9 KB |
gf128mul.c | -rw-r--r-- | 12.4 KB |
ghash-generic.c | -rw-r--r-- | 3.5 KB |
hash_info.c | -rw-r--r-- | 1.9 KB |
hmac.c | -rw-r--r-- | 6.5 KB |
internal.h | -rw-r--r-- | 3.4 KB |
jitterentropy-kcapi.c | -rw-r--r-- | 5.9 KB |
jitterentropy.c | -rw-r--r-- | 19.3 KB |
keywrap.c | -rw-r--r-- | 9.5 KB |
khazad.c | -rw-r--r-- | 51.8 KB |
kpp.c | -rw-r--r-- | 2.7 KB |
lrw.c | -rw-r--r-- | 10.7 KB |
lz4.c | -rw-r--r-- | 3.3 KB |
lz4hc.c | -rw-r--r-- | 3.4 KB |
lzo-rle.c | -rw-r--r-- | 3.4 KB |
lzo.c | -rw-r--r-- | 3.3 KB |
md4.c | -rw-r--r-- | 5.9 KB |
md5.c | -rw-r--r-- | 7.4 KB |
memneq.c | -rw-r--r-- | 6.1 KB |
michael_mic.c | -rw-r--r-- | 3.6 KB |
morus1280.c | -rw-r--r-- | 14.0 KB |
morus640.c | -rw-r--r-- | 13.6 KB |
nhpoly1305.c | -rw-r--r-- | 7.7 KB |
ofb.c | -rw-r--r-- | 2.4 KB |
pcbc.c | -rw-r--r-- | 4.7 KB |
pcrypt.c | -rw-r--r-- | 12.6 KB |
poly1305_generic.c | -rw-r--r-- | 8.5 KB |
proc.c | -rw-r--r-- | 2.5 KB |
ripemd.h | -rw-r--r-- | 1013 bytes |
rmd128.c | -rw-r--r-- | 10.0 KB |
rmd160.c | -rw-r--r-- | 12.4 KB |
rmd256.c | -rw-r--r-- | 10.3 KB |
rmd320.c | -rw-r--r-- | 12.8 KB |
rng.c | -rw-r--r-- | 4.7 KB |
rsa-pkcs1pad.c | -rw-r--r-- | 17.8 KB |
rsa.c | -rw-r--r-- | 5.3 KB |
rsa_helper.c | -rw-r--r-- | 4.0 KB |
rsaprivkey.asn1 | -rw-r--r-- | 316 bytes |
rsapubkey.asn1 | -rw-r--r-- | 82 bytes |
salsa20_generic.c | -rw-r--r-- | 6.0 KB |
scatterwalk.c | -rw-r--r-- | 2.0 KB |
scompress.c | -rw-r--r-- | 6.8 KB |
seed.c | -rw-r--r-- | 17.2 KB |
seqiv.c | -rw-r--r-- | 5.0 KB |
serpent_generic.c | -rw-r--r-- | 21.4 KB |
sha1_generic.c | -rw-r--r-- | 2.4 KB |
sha256_generic.c | -rw-r--r-- | 10.7 KB |
sha3_generic.c | -rw-r--r-- | 8.0 KB |
sha512_generic.c | -rw-r--r-- | 7.8 KB |
shash.c | -rw-r--r-- | 14.5 KB |
simd.c | -rw-r--r-- | 13.6 KB |
skcipher.c | -rw-r--r-- | 32.0 KB |
sm3_generic.c | -rw-r--r-- | 4.1 KB |
sm4_generic.c | -rw-r--r-- | 6.3 KB |
streebog_generic.c | -rw-r--r-- | 59.3 KB |
tcrypt.c | -rw-r--r-- | 78.3 KB |
tcrypt.h | -rw-r--r-- | 4.2 KB |
tea.c | -rw-r--r-- | 6.5 KB |
testmgr.c | -rw-r--r-- | 133.5 KB |
testmgr.h | -rw-r--r-- | 1.2 MB |
tgr192.c | -rw-r--r-- | 30.3 KB |
twofish_common.c | -rw-r--r-- | 37.2 KB |
twofish_generic.c | -rw-r--r-- | 5.6 KB |
vmac.c | -rw-r--r-- | 18.8 KB |
wp512.c | -rw-r--r-- | 59.8 KB |
xcbc.c | -rw-r--r-- | 6.6 KB |
xor.c | -rw-r--r-- | 3.4 KB |
xts.c | -rw-r--r-- | 8.9 KB |
xxhash_generic.c | -rw-r--r-- | 2.5 KB |
zstd.c | -rw-r--r-- | 5.0 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...