Revision df9576def004d2cd5beedc00cb6e8901427634b9 authored by Yang Shi on 03 August 2019, 04:48:37 UTC, committed by Linus Torvalds on 03 August 2019, 14:02:00 UTC
When running ltp's oom test with kmemleak enabled, the below warning was triggerred since kernel detects __GFP_NOFAIL & ~__GFP_DIRECT_RECLAIM is passed in: WARNING: CPU: 105 PID: 2138 at mm/page_alloc.c:4608 __alloc_pages_nodemask+0x1c31/0x1d50 Modules linked in: loop dax_pmem dax_pmem_core ip_tables x_tables xfs virtio_net net_failover virtio_blk failover ata_generic virtio_pci virtio_ring virtio libata CPU: 105 PID: 2138 Comm: oom01 Not tainted 5.2.0-next-20190710+ #7 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.10.2-0-g5f4c7b1-prebuilt.qemu-project.org 04/01/2014 RIP: 0010:__alloc_pages_nodemask+0x1c31/0x1d50 ... kmemleak_alloc+0x4e/0xb0 kmem_cache_alloc+0x2a7/0x3e0 mempool_alloc_slab+0x2d/0x40 mempool_alloc+0x118/0x2b0 bio_alloc_bioset+0x19d/0x350 get_swap_bio+0x80/0x230 __swap_writepage+0x5ff/0xb20 The mempool_alloc_slab() clears __GFP_DIRECT_RECLAIM, however kmemleak has __GFP_NOFAIL set all the time due to d9570ee3bd1d4f2 ("kmemleak: allow to coexist with fault injection"). But, it doesn't make any sense to have __GFP_NOFAIL and ~__GFP_DIRECT_RECLAIM specified at the same time. According to the discussion on the mailing list, the commit should be reverted for short term solution. Catalin Marinas would follow up with a better solution for longer term. The failure rate of kmemleak metadata allocation may increase in some circumstances, but this should be expected side effect. Link: http://lkml.kernel.org/r/1563299431-111710-1-git-send-email-yang.shi@linux.alibaba.com Fixes: d9570ee3bd1d4f2 ("kmemleak: allow to coexist with fault injection") Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com> Suggested-by: Catalin Marinas <catalin.marinas@arm.com> Acked-by: Michal Hocko <mhocko@suse.com> Cc: Dmitry Vyukov <dvyukov@google.com> Cc: David Rientjes <rientjes@google.com> Cc: Matthew Wilcox <willy@infradead.org> Cc: Qian Cai <cai@lca.pw> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 68d8681
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 228 bytes |
Makefile | -rw-r--r-- | 356 bytes |
acl.c | -rw-r--r-- | 4.6 KB |
dcache.c | -rw-r--r-- | 3.6 KB |
devorangefs-req.c | -rw-r--r-- | 21.9 KB |
dir.c | -rw-r--r-- | 9.1 KB |
downcall.h | -rw-r--r-- | 2.9 KB |
file.c | -rw-r--r-- | 17.1 KB |
inode.c | -rw-r--r-- | 29.0 KB |
namei.c | -rw-r--r-- | 11.5 KB |
orangefs-bufmap.c | -rw-r--r-- | 12.6 KB |
orangefs-bufmap.h | -rw-r--r-- | 925 bytes |
orangefs-cache.c | -rw-r--r-- | 4.3 KB |
orangefs-debug.h | -rw-r--r-- | 2.5 KB |
orangefs-debugfs.c | -rw-r--r-- | 24.7 KB |
orangefs-debugfs.h | -rw-r--r-- | 311 bytes |
orangefs-dev-proto.h | -rw-r--r-- | 2.1 KB |
orangefs-kernel.h | -rw-r--r-- | 13.2 KB |
orangefs-mod.c | -rw-r--r-- | 5.9 KB |
orangefs-sysfs.c | -rw-r--r-- | 33.0 KB |
orangefs-sysfs.h | -rw-r--r-- | 77 bytes |
orangefs-utils.c | -rw-r--r-- | 15.4 KB |
protocol.h | -rw-r--r-- | 11.2 KB |
super.c | -rw-r--r-- | 17.1 KB |
symlink.c | -rw-r--r-- | 497 bytes |
upcall.h | -rw-r--r-- | 6.7 KB |
waitqueue.c | -rw-r--r-- | 10.3 KB |
xattr.c | -rw-r--r-- | 14.7 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...