Revision df9576def004d2cd5beedc00cb6e8901427634b9 authored by Yang Shi on 03 August 2019, 04:48:37 UTC, committed by Linus Torvalds on 03 August 2019, 14:02:00 UTC
When running ltp's oom test with kmemleak enabled, the below warning was
triggerred since kernel detects __GFP_NOFAIL & ~__GFP_DIRECT_RECLAIM is
passed in:
WARNING: CPU: 105 PID: 2138 at mm/page_alloc.c:4608 __alloc_pages_nodemask+0x1c31/0x1d50
Modules linked in: loop dax_pmem dax_pmem_core ip_tables x_tables xfs virtio_net net_failover virtio_blk failover ata_generic virtio_pci virtio_ring virtio libata
CPU: 105 PID: 2138 Comm: oom01 Not tainted 5.2.0-next-20190710+ #7
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.10.2-0-g5f4c7b1-prebuilt.qemu-project.org 04/01/2014
RIP: 0010:__alloc_pages_nodemask+0x1c31/0x1d50
...
kmemleak_alloc+0x4e/0xb0
kmem_cache_alloc+0x2a7/0x3e0
mempool_alloc_slab+0x2d/0x40
mempool_alloc+0x118/0x2b0
bio_alloc_bioset+0x19d/0x350
get_swap_bio+0x80/0x230
__swap_writepage+0x5ff/0xb20
The mempool_alloc_slab() clears __GFP_DIRECT_RECLAIM, however kmemleak
has __GFP_NOFAIL set all the time due to d9570ee3bd1d4f2 ("kmemleak:
allow to coexist with fault injection"). But, it doesn't make any sense
to have __GFP_NOFAIL and ~__GFP_DIRECT_RECLAIM specified at the same
time.
According to the discussion on the mailing list, the commit should be
reverted for short term solution. Catalin Marinas would follow up with
a better solution for longer term.
The failure rate of kmemleak metadata allocation may increase in some
circumstances, but this should be expected side effect.
Link: http://lkml.kernel.org/r/1563299431-111710-1-git-send-email-yang.shi@linux.alibaba.com
Fixes: d9570ee3bd1d4f2 ("kmemleak: allow to coexist with fault injection")
Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
Suggested-by: Catalin Marinas <catalin.marinas@arm.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: David Rientjes <rientjes@google.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Qian Cai <cai@lca.pw>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 68d8681
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 1.3 KB |
| Makefile | -rw-r--r-- | 549 bytes |
| addr.c | -rw-r--r-- | 3.7 KB |
| addr.h | -rw-r--r-- | 3.0 KB |
| bcast.c | -rw-r--r-- | 21.5 KB |
| bcast.h | -rw-r--r-- | 4.4 KB |
| bearer.c | -rw-r--r-- | 28.5 KB |
| bearer.h | -rw-r--r-- | 9.1 KB |
| core.c | -rw-r--r-- | 4.9 KB |
| core.h | -rw-r--r-- | 5.1 KB |
| diag.c | -rw-r--r-- | 3.5 KB |
| discover.c | -rw-r--r-- | 12.6 KB |
| discover.h | -rw-r--r-- | 2.3 KB |
| eth_media.c | -rw-r--r-- | 3.6 KB |
| group.c | -rw-r--r-- | 23.7 KB |
| group.h | -rw-r--r-- | 3.5 KB |
| ib_media.c | -rw-r--r-- | 3.6 KB |
| link.c | -rw-r--r-- | 72.0 KB |
| link.h | -rw-r--r-- | 6.6 KB |
| monitor.c | -rw-r--r-- | 21.1 KB |
| monitor.h | -rw-r--r-- | 3.5 KB |
| msg.c | -rw-r--r-- | 19.2 KB |
| msg.h | -rw-r--r-- | 25.8 KB |
| name_distr.c | -rw-r--r-- | 9.9 KB |
| name_distr.h | -rw-r--r-- | 3.1 KB |
| name_table.c | -rw-r--r-- | 26.6 KB |
| name_table.h | -rw-r--r-- | 6.1 KB |
| net.c | -rw-r--r-- | 9.2 KB |
| net.h | -rw-r--r-- | 2.3 KB |
| netlink.c | -rw-r--r-- | 9.6 KB |
| netlink.h | -rw-r--r-- | 2.7 KB |
| netlink_compat.c | -rw-r--r-- | 33.8 KB |
| node.c | -rw-r--r-- | 64.8 KB |
| node.h | -rw-r--r-- | 4.8 KB |
| socket.c | -rw-r--r-- | 99.0 KB |
| socket.h | -rw-r--r-- | 3.4 KB |
| subscr.c | -rw-r--r-- | 5.4 KB |
| subscr.h | -rw-r--r-- | 4.1 KB |
| sysctl.c | -rw-r--r-- | 2.8 KB |
| topsrv.c | -rw-r--r-- | 18.1 KB |
| topsrv.h | -rw-r--r-- | 2.3 KB |
| trace.c | -rw-r--r-- | 7.0 KB |
| trace.h | -rw-r--r-- | 12.8 KB |
| udp_media.c | -rw-r--r-- | 20.8 KB |
| udp_media.h | -rw-r--r-- | 2.5 KB |
Computing file changes ...
