Skip to main content

Browse the archive

https://github.com/angular/angular
19 April 2024, 08:24:33 UTC
sort by:
Revision Author Date Message Commit Date
dfb072a Jessica Janiuk 09 June 2021, 18:03:28 UTC release: cut the v12.0.4 release (#42531) 09 June 2021, 18:03:28 UTC
6203f5e Andrew Scott 24 May 2021, 15:50:48 UTC docs: clarify onSameUrlNavigation behavior (#42275) `onSameUrlNavigation` only affects whether the Angular Router processes the URL and runs it through the navigation pipeline, retriggering redirects, guards, and resolvers. The name `reload` is a little confusing because it does _not_ reload the component. Developers _also_ need to implement a custom `RouteReuseStrategy` to trigger a component reload on same URL navigation. Fixes #21115 PR Close #42275 09 June 2021, 16:45:25 UTC
3abf365 David Shevitz 26 May 2021, 21:04:12 UTC docs: add guidance on adding filtering and sorting logic to componetns instead of pipes (#42368) Fixes #41652 PR Close #42368 09 June 2021, 00:53:31 UTC
5f6492e Teri Glover 19 May 2021, 21:57:53 UTC docs: Edited to remove jargon in Reference, Glossary, and Style sections (#42187) PR Close #42187 08 June 2021, 19:51:06 UTC
ef0ece1 kuncevic 13 May 2021, 11:24:02 UTC docs: add Angular Rocks podcast (#42078) PR Close #42078 08 June 2021, 19:50:14 UTC
72b86c7 Santosh Yadav 30 May 2021, 19:48:23 UTC docs(platform-server): added commands for universal and add prerendering info (#36005) Fixes #36004 PR Close #36005 08 June 2021, 19:47:24 UTC
f158ce1 Sam Severance 18 May 2021, 13:32:02 UTC docs: Add selector for `PeekABooDirective` (#42146) PR Close #42146 08 June 2021, 19:46:06 UTC
a42b9bf Teri Glover 19 May 2021, 21:20:23 UTC docs: Edited to remove jargon in Reference Errors (#42186) PR Close #42186 08 June 2021, 19:45:24 UTC
68ae32a anups1 08 June 2021, 06:40:38 UTC docs: fix issue 24571 in ngOnChanges (#42517) fix issue #24571 in ngOnChanges doc PR Close #42517 08 June 2021, 19:44:30 UTC
af5867d Kapunahele Wong 30 March 2021, 19:31:38 UTC docs: improve accessibility of animations example (#41385) PR Close #41385 08 June 2021, 19:43:33 UTC
d509a76 Kapunahele Wong 16 March 2021, 18:22:09 UTC docs: improve accessibility of reactive-forms example (#41252) PR Close #41252 08 June 2021, 19:42:20 UTC
5746afe Kapunahele Wong 02 April 2021, 19:30:22 UTC docs: improve accessibility of attribute-binding example (#41432) PR Close #41432 08 June 2021, 19:16:55 UTC
6b8ecb4 Kapunahele Wong 22 March 2021, 20:18:25 UTC docs: improve accessibility of pipes example (#41317) PR Close #41317 08 June 2021, 19:16:09 UTC
93de5a0 Chris 24 March 2021, 06:06:00 UTC docs: clarify documentation regarding passing multiple configurations to ng build (#41333) Fixes #40923 PR Close #41333 08 June 2021, 18:49:25 UTC
3ffdc75 Tiago Temporin 07 May 2021, 10:54:09 UTC docs: add components to material community components description (#41987) PR Close #41987 08 June 2021, 18:48:41 UTC
8ad2feb Pete Bacon Darwin 07 June 2021, 17:20:32 UTC refactor(docs-infra): prepare DocumentService to handle new disambiguated URLs (#42509) A subsequent commit is going to change disambiguated URLs. This commit prepares the AIO application to attempt the new URLs if the old URLs fail. This will help to mitigate problems that may occur during the period between deployment of the new version and the service-worker not being updated. PR Close #42509 08 June 2021, 18:45:54 UTC
a77ec5b Sam Severance 04 June 2021, 17:25:24 UTC fix(router): fix `serializeQueryParams` logic (#42481) corrects a bug that resulted in query params such as `[queryParams]={a: 1, b:[]}` being serialized as 'a=1&' instead of 'a=1' resolves #42445 PR Close #42481 08 June 2021, 17:43:01 UTC
64a0ed8 Andrew Scott 26 May 2021, 20:12:42 UTC docs: add selector documentation for `ViewChildren`, `ContentChildren`, and `ContentChild` (#42366) These notes are copied from `ViewChild`. In addition, `ContentChildren` and `ViewChildren` can specify multiple string selectors by separating each selector by a comma. fixes #21734 PR Close #42366 08 June 2021, 17:42:21 UTC
92d8177 MrJithil 06 June 2021, 18:19:05 UTC docs: add links to examples for ComponentFactoryResolver (#42496) Fixes #21705 PR Close #42496 08 June 2021, 17:41:34 UTC
d5f9d47 Pete Bacon Darwin 27 May 2021, 20:27:38 UTC docs(core): describe interactions between view-encapsulated components (#42397) This commit adds information to the view encapsulation guide that describes the styling interactions between components that use differing view encapsulation modes. Closes #40715 PR Close #42397 08 June 2021, 17:39:53 UTC
1c4da09 MarsiBarsi 08 June 2021, 08:46:27 UTC docs: add Roman Sedov to contributors page (#42515) PR Close #42515 08 June 2021, 17:37:52 UTC
f217f01 iRealNirmal 08 June 2021, 12:30:29 UTC docs: updated collaborators and add angular dev's link (#42516) Existing trusted collaborators link is not working and now link is updated to one of angular.io page also it was missing angular dev's link so added it. Closes #42513. PR Close #42516 08 June 2021, 17:37:17 UTC
cba68e3 Teri Glover 19 May 2021, 20:20:35 UTC docs: Edits to remove jargon in Reference Observables, Dependency Injection (#42185) PR Close #42185 08 June 2021, 01:24:49 UTC
34dd3c3 Andrew Scott 03 June 2021, 22:15:16 UTC fix(language-service): fix autocomplete info display for some cases (#42472) Before this commit, attribute completion display parts were retrieved but not assigned. In addition, the switch case was non-exhaustive because it did not include `StructuralDirectiveAttribute`. PR Close #42472 07 June 2021, 19:25:53 UTC
8bb6fb7 George Kalpakas 07 June 2021, 17:44:08 UTC docs(router): fix code-example headers (#42507) Previously, the code-examples headers used in the "Creating custom route matches" tutorial contained the name of the example directory (`routing-with-urlmatcher`). This was confusing, because the user was previously instructed to create an app named `angular-custom-route-match` and switch to that directory. This commit fixes it by removing the root directory name from the headers, thus leaving the path of the file relative to the current working directory. This also aligns with code-examples in other guides. PR Close #42507 07 June 2021, 18:58:21 UTC
65d5930 Paul Gschwendtner 07 June 2021, 14:17:03 UTC build: remove unused no-strict tsconfig file (#42506) In the past, when we enabled `--strict` in the repository, we added another tsconfig for code not being migrated to be `--strict` compatible. This was done for the deprecated http and webworker packages. Since these are now removed, we can rmeove the logic. PR Close #42506 07 June 2021, 17:47:48 UTC
dbefba5 JoostK 05 June 2021, 18:52:19 UTC docs: clarify how type-only imports can be used to avoid NG3003 (#42491) Since #42453, type-only imports are not considered for cyclic imports. This commit adds a note to the NG3003 error documentation to mention using type-only imports to avoid the error. PR Close #42491 07 June 2021, 17:47:14 UTC
ba28a49 Andrew Kushnir 25 May 2021, 20:09:31 UTC docs: provide more info on the `NO_ERRORS_SCHEMA` schema (#42327) The `NO_ERRORS_SCHEMA` schema can be used to ignore errors related to unknown elements or properties, but since it suppresses these errors it may also hide real problems in a template. This commit updates the `NO_ERRORS_SCHEMA` docs to mention that. Closes #39454. PR Close #42327 07 June 2021, 17:46:35 UTC
f5d81d3 Pete Bacon Darwin 23 May 2021, 10:59:55 UTC docs(core): clarify deprecation of `entryComponents` (#42248) These may still be needed in View Engine libraries. Closes #39958 PR Close #42248 07 June 2021, 17:02:01 UTC
770883f Alex Inkin 05 June 2021, 11:05:24 UTC fix(docs-infra): fix search results font color (#42488) Use the same white constant for no results message PR Close #42488 07 June 2021, 16:38:06 UTC
f7609c3 Gourav102 06 June 2021, 15:00:17 UTC docs: Corrected spelling (#42493) Corrected spelling of 'Properties'. PR Close #42493 07 June 2021, 16:36:18 UTC
5f1d723 Gourav102 06 June 2021, 16:37:20 UTC docs: Updated the code snippet path (#42494) PR Close #42494 07 June 2021, 16:32:57 UTC
ad9dd2a Igor Minar 26 May 2021, 23:58:38 UTC docs: add node.js version info into the universal guide (#42375) Previously we didn't document what versions were supported. Since universal requires node.js I'm adding version information into the guide as a informative callout. Fixes #39436 PR Close #42375 04 June 2021, 22:21:22 UTC
6080db1 Joey Perrott 04 June 2021, 18:59:12 UTC build: suppress errors in git hooks (#42484) When errors occur in git hooks, we can safely supress them as they are validated on CI. This is primarily coming up as an issue related to needing to reinstall node_modules PR Close #42484 04 June 2021, 20:34:02 UTC
68ea6d8 Teri Glover 19 May 2021, 19:05:03 UTC docs: Edits to remove jargon in Reference NgModules (#42182) PR Close #42182 04 June 2021, 20:32:56 UTC
beae425 Joey Perrott 03 June 2021, 22:18:19 UTC ci: extend default timeout of karma tests for legacy saucelab tests (#42473) After testing, it seems that the flakyness we are experiencing in our legacy saucelabs job is caused by timeouts which happen due to the karma server being unable to serve all of the files needed for the tests fast enough while concurrent tests are being run. PR Close #42473 03 June 2021, 23:06:01 UTC
a3b01e8 Paul Gschwendtner 03 June 2021, 14:53:55 UTC test(dev-infra): always use same virtual git client instance in publish tests (#42468) With the recent refactorings to `GitClient`, where singletons are created and can be retrieved through a static method, the test has been updated to also install spies for the static methods of `GitClient`. This commit updates the spy installation so that the same mock git client is used that is also passed manually to the release actions. Having two separate instances of the mock git client could result in false-positive test results. PR Close #42468 03 June 2021, 21:34:33 UTC
0e058df Paul Gschwendtner 03 June 2021, 13:59:20 UTC refactor(dev-infra): improve type-safety of git client utility (#42468) Currently the `GitClient` accepts a generic parameter for determining whether the `githubToken` should be set or not. This worked fine so far in terms of distinguishing between an authenticated and non-authenticated git client instance, but if we intend to conditionally show methods only for authenticated instances, the generic parameter is not suitable. This commit splits up the `GitClient` into two classes. One for the base logic without any authorization, and a second class that extends the base logic with authentication logic. i.e. the `AuthenticatedGitClient`. This allows us to have specific methods only for the authenticated instance. e.g. * `hasOauthScopes` has been moved to only exist for authenticated instances. * the GraphQL functionality within `gitClient.github` is not accessible for non-authenticated instances. GraphQL API requires authentication as per Github. The initial motiviation for this was that we want to throw if `hasOAuthScopes` is called without the Octokit instance having a token configured. This should help avoiding issues as within https://github.com/angular/angular/commit/3b434ed94d9ed067e5d999c064ae5f12b3cb175c that prevented the caretaker process momentarily. Additionally, the Git client has moved from `index.ts` to `git-client.ts` for better discoverability in the codebase. PR Close #42468 03 June 2021, 21:34:33 UTC
3cb1c36 David Shevitz 28 May 2021, 00:08:55 UTC docs: update host and viewproviders section with correct logical tree representation (#42403) Fixes #38741 PR Close #42403 03 June 2021, 21:33:45 UTC
1fbe4fe George Kalpakas 01 June 2021, 15:29:32 UTC build(docs-infra): disable critical CSS inlining (#42435) Previously, the critical CSS inlining optimization (which is turned on by default in CLI v12+) was causing a Flash Of Unstyled Content (FOUC). This was caused by the combination of the following facts: - The way CSS inlining is implemented in the CLI makes loading the full styles asynchronous and non-render-blocking (so the app can bootstrap before the styles are fully downloaded). - Angular.io does not employ the [app shell][1] pattern in order to render pages at build time, resulting in very minimal CSS rules being recognized as critical (for the purpose of inlining). This commit fixes the FOUC by disabling the critical CSS inlining, while we consider a better way to approach this (in order to be able to rip the benefits of inlining without the FOUC). [1]: https://angular.io/guide/app-shell Fixes #42365 PR Close #42435 03 June 2021, 21:32:07 UTC
a6dec05 Paul Gschwendtner 03 June 2021, 18:36:38 UTC refactor(dev-infra): always use en-US locale for printing date in merge tool (#42470) In the dev-infra merge tool, a test fails locally if it runs on a system with a different system locale. We can either make the test more flexible, or update the merge tool to always print the date in `en-US` format. The latter is more reasonable given our console messages being in english anyway. PR Close #42470 03 June 2021, 20:19:04 UTC
66d3770 cindygk 02 June 2021, 13:11:06 UTC docs: offboard misko and annie from contributors page (#42467) PR Close #42467 03 June 2021, 20:17:45 UTC
ec3c0b4 George Kalpakas 03 June 2021, 13:43:03 UTC test(docs-infra): fix URL for a11y testing of angular.io (#42471) This commit fixes one of the URLs used for testing the accessibility of angular.io from `start-routing` to `start/start-routing`. The old URL is not correct and result in a "Page not found" error. This commit also increases some of the a11y scores. PR Close #42471 03 June 2021, 20:16:50 UTC
8f651f3 George Kalpakas 03 June 2021, 18:55:44 UTC build: update dependency lighthouse to v8 (#42471) Update LightHouse to v8.0.0 to take advantage of the latest fixes and improvements. PR Close #42471 03 June 2021, 20:16:50 UTC
50c87e8 iRealNirmal 29 May 2021, 04:51:30 UTC fix(forms): the `min` and `max` validators should work correctly with `0` as a value (#42412) Prior to this change the `min` and `max` validator directives would not set the `min` and `max` attributes on the host element. The problem was caused by the truthy check in host binding expression that was calculated as `false` when `0` is used as a value. This commit updates the logic to leverage nullish coalescing operator in these host binding expressions, so `0` is treated as a valid value, thus the `min` and `max` attributes are set correctly. Partially closes #42267 PR Close #42412 03 June 2021, 18:34:46 UTC
200cc31 JoostK 07 May 2021, 20:28:18 UTC fix(common): infer correct type when `trackBy` is used in `ngFor` (#41995) When a `trackBy` function is used that accepts a supertype of the iterated array's type, the loop variable would undesirably be inferred as the supertype instead of the array's item type. This commit adds an inferred type parameter to `TrackByFunction` to allow an extra degree of freedom, enabling the loop value to be inferred as the most narrow type. Fixes #40125 PR Close #41995 03 June 2021, 18:33:27 UTC
d69b91b JoostK 07 May 2021, 19:49:31 UTC test(compiler-cli): move `TrackByFunction` from `fake_common` to `fake_core` (#41995) The `TrackByFunction` is declared in `@angular/core` so it should also be included in `fake_core` instead of `fake_common`. PR Close #41995 03 June 2021, 18:33:27 UTC
4f7245f JoostK 07 May 2021, 19:48:06 UTC test(compiler-cli): load type declarations from fake_common (#41995) The ngtsc test targets have fake declarations files for `@angular/core` and `@angular/common` and the template type checking tests can leverage the fake common declarations instead of declaring its own types. PR Close #41995 03 June 2021, 18:33:27 UTC
b6d6a34 JoostK 02 June 2021, 15:27:03 UTC fix(compiler-cli): exclude type-only imports from cycle analysis (#42453) Type-only imports are known to be elided by TypeScript, so the compiler can be certain that such imports do not contribute to potential import cycles. As such, type-only imports are no longer considered during cycle analysis. Regular import statements that would eventually be fully elided by TypeScript during emit if none of the imported symbols are used in a value position continue to be included in the cycle analysis, as the cycle analyzer is unaware of these elision opportunities. Only explicit `import type` statements are excluded. PR Close #42453 03 June 2021, 18:31:59 UTC
0dad375 Vahid Mohammadi 05 May 2021, 07:14:18 UTC fix(common): initialize currencyCode in currencyPipe (#40505) currencyCode should be initialized with the injected default currency code PR Close #40505 03 June 2021, 17:52:29 UTC
dc6011b mgechev 03 June 2021, 16:17:40 UTC ci: update the sha of the feature request process bot (#42469) Use the latest version of the feature request process bot that incorporates the latest fixes. PR Close #42469 03 June 2021, 17:43:47 UTC
6238c45 Paul Gschwendtner 24 May 2021, 15:07:07 UTC ci: do not update shared dev-infra package in components-repo-unit-tests job (#42268) The shared dev-infra package from `HEAD` should not be installed when running the `components-repo-unit-tests` job. This is done because otherwise changes to the dev-infra package can result in build setup issues for the CI job (while the goal of the CI job is to test the framework) PR Close #42268 03 June 2021, 17:37:42 UTC
06e3475 Paul Gschwendtner 24 May 2021, 14:17:27 UTC refactor(dev-infra): move shared browser bazel setup into dedicated bazel folder (#42268) This change moves the `dev-infra/browsers` folder into `dev-infra/bazel`. The browser folder is providing custom configuration for Bazel, so it should live within the `bazel` folder for a more well-structured `dev-infra` folder. PR Close #42268 03 June 2021, 17:37:42 UTC
bae7ac3 Paul Gschwendtner 28 May 2021, 12:20:18 UTC refactor(dev-infra): remove duplicate method that checks for uncommitted changes (#42409) Removes the duplicate `hasLocalChanges` method from the Git client. We already have `hasUncommittedChanges`. Also removes a TODO for adding `assertNoLocalChanges` as it seems more flexible to manually check (i.e. better messaging with context on the current tool; e.g. "cannot perform rebase") PR Close #42409 03 June 2021, 17:36:40 UTC
e153b9f David Shevitz 03 June 2021, 05:27:49 UTC docs: update link to jasmine documentation about spies (#42463) PR Close #42463 03 June 2021, 17:34:24 UTC
0a1d8e5 Kristiyan Kostadinov 02 June 2021, 16:37:13 UTC refactor(docs-infra): clean up AIO Sass files (#42442) Cleans up AIO's Sass files by: * Switching them all over to the `@use`-based API from Angular Material. * Removing the import of the Material theming API in a bunch of places that weren't using it. * Migrating the new usages of Sass utility functions to the new syntax (e.g. `map.get` vs `map-get`). * Fixing a few files that were using 4 spaces for indentation instead of 2. PR Close #42442 02 June 2021, 20:25:43 UTC
830c861 Alex 02 June 2021, 18:04:57 UTC docs: fix typo in the Router guide (#42455) PR Close #42455 02 June 2021, 20:24:31 UTC
5dabdf9 Paul Gschwendtner 02 June 2021, 17:06:26 UTC feat(dev-infra): prevent deprecations from being merged into patch branch (#42454) As per SemVer, deprecations should only be released if the minor version is incremented. This means that we should error if commits w/ deprecations target an upcoming patch, LTS release. Additionally, we also error if deprecations are made as part of an upcoming release-candidate. PR Close #42454 02 June 2021, 20:23:55 UTC
b812f11 Paul Gschwendtner 02 June 2021, 16:47:01 UTC refactor(dev-infra): add JSDoc throws description to assertion functions (#42454) Adds the JSDoc `@throws` annotation to functions that would throw within in the ng-dev tool. We want to add `@throws` so clearly communicate if the invocation of a function results in errors or not. This helps if IDEs show the `@throws` annotation on invocation, or if TS ever lands a feature like Java `throws`, with more fine-grained and typed error handling. PR Close #42454 02 June 2021, 20:23:55 UTC
446815e Paul Gschwendtner 02 June 2021, 16:33:10 UTC fix(dev-infra): breaking change and deprecation notes incorrectly picked up (#42436) If a commit message currently mentions the breaking change or deprecation note keywords, the commit message parse logic accidentally picks up the note. This could then accidentally prevent the commit from being merged (e.g. if the commit targets the patch branch but mentioned the `BREAKING CHANGE: ` marker). This commit switches the commit message notes pattern to only capture notes at the beginning of a line (also allowing accidental whitespace). This matches with the format we describe in our contribution guide, as well as with our commit message validation logic that also assumes notes at the beginning of a line. PR Close #42436 02 June 2021, 20:22:55 UTC
6ce4045 Paul Gschwendtner 01 June 2021, 19:00:22 UTC feat(dev-infra): validate deprecation notes in commit messages (#42436) Currently the commit message validation tool from `ng-dev` validates the `BREAKING CHANGE:` commit message notes. This commit adds a similar check for `DEPRECATED:` commit message notes. Additionally, the check for breaking changes is reworked slightly to be more tolerant (i.e. if there is only a single line break after the summary; this is acceptable as per the parser and commonly done in the COMP repo). The checks have been updated to capture wrong keywords that are commonly used instead of the correct one. e.g. if a commit message uses `DEPRECATIONS:` instead of `DEPRECATED:`, the validation will fail. This prevents changelog generation issues where breaking change notes, or deprecations are missing. This happened in the COMP repo where the `DEPRECATED:` keyword was used incorrectly. See: https://github.com/angular/components/commit/99391e79391d20c6ef2f95a3ea4fd6901dcb631d PR Close #42436 02 June 2021, 20:22:55 UTC
fa0e88d Sam Severance 02 June 2021, 00:28:57 UTC docs: remove unused imports from unit tests (#42441) PR Close #42441 02 June 2021, 20:22:09 UTC
4286a40 Sam Severance 02 June 2021, 00:26:25 UTC docs: refactor `WelcomeComponent` unit test (#42441) PR Close #42441 02 June 2021, 20:22:09 UTC
2c0912b Igor Minar 28 May 2021, 01:12:04 UTC docs: clarify the wording around live examples for all testing guides (#42406) We should primarily point readers to the stackblitz that contains the spec files and runs them. The application stackblitz is secondary (and doesn't actually contain the spec files, which is confusing). Fixes #38535 PR Close #42406 02 June 2021, 20:20:13 UTC
3508d59 Igor Minar 26 May 2021, 00:54:24 UTC docs: add a note about javascript mime-types to the deployment guide (#42339) Some servers don't serve the .js files with the correnct headers. This change documents the requirement. Fixes #30835 PR Close #42339 02 June 2021, 20:17:36 UTC
1a971a9 Paul Gschwendtner 02 June 2021, 19:39:22 UTC fix(dev-infra): github oauth token not picked up by Octokit (#42457) We recently updated `@octokit/rest` to a more recent version. For this the Github client had to be refactored to account for new types of Octokit. With the refactorings the authentication of the Github client broke as we used an incorrect option for setting the OAuth token. The TS transpilation did not fail because the Octokit types support arbitrary options in the constructor. This is not solvable on our side, so we cannot prevent similar issues in the future unfortunately. Adding tests for authentication is not a reasonable option either. PR Close #42457 02 June 2021, 20:14:30 UTC
495a213 Andrew Kushnir 02 June 2021, 17:43:07 UTC release: cut the v12.0.3 release 02 June 2021, 17:43:07 UTC
e937f77 David Pfeiffer 01 June 2021, 21:18:25 UTC docs: specify correct interceptor class type (#42437) In the "Interceptor order" section of the HTTP guide there is a typo which incorrectly lists the same service twice when referring to two different services. The order that these services are listed is important, and this commit fixes the typo by listing the services in the correct order. PR Close #42437 01 June 2021, 23:36:59 UTC
7abea4f Andrew Scott 24 May 2021, 17:39:22 UTC docs: change Navigation from type to interface (#42281) Navigation type should be interface so it can be documented on aio site. fixes #37384 PR Close #42281 01 June 2021, 21:13:22 UTC
8bdcca1 Alex Rickabaugh 20 May 2021, 20:39:17 UTC fix(compiler-cli): better detect classes that are indirectly exported (#42207) The compiler flag `compileNonExportedClasses` allows the Angular compiler to process classes which are not exported at the top level of a source file. This is often used to allow for AOT compilation of test classes inside `it()` test blocks, for example. Previously, the compiler would identify exported classes by looking for an `export` modifier on the class declaration itself. This works for the trivial case, but fails for indirectly exported classes: ```typescript // Component is declared unexported. @Component({...}) class FooCmp {...} // Indirect export of FooCmp export {FooCmp}; ``` This is not an immediate problem for most application builds, since the default value for `compileNonExportedClasses` is `true` and therefore such classes get compiled regardless. However, in the Angular Language Service now, `compileNonExportedClasses` is forcibly overridden to `false`. That's because the tsconfig used by the IDE and Language Service is often far broader than the application build's configuration, and pulls in test files that can contain unexported classes not designed with AOT compilation in mind. Therefore, the Language Service has trouble working with such structures. In this commit, the `ReflectionHost` gains a new API for detecting whether a class is exported. The implementation of this method now not only considers the `export` modifier, but also scans the `ts.SourceFile` for indirect exports like the example above. This ensures the above case will be processed directly in the Language Service. This new operation is cached using an expando symbol on the `ts.SourceFile`, ensuring good performance even when scanning large source files with lots of exports (e.g. a FESM file under `ngcc`). Fixes #42184. PR Close #42207 01 June 2021, 19:16:47 UTC
b0293c6 JoostK 29 May 2021, 17:10:35 UTC docs: clarify how declaration files can be installed (#42417) The documentation suggested that `@types/*` scoped packages would automatically be recognized, however the CLI configures a project such that the package has to be explicitly added to the TypeScript configuration files. Closes #37572 PR Close #42417 01 June 2021, 17:17:33 UTC
f38b0b7 Kristiyan Kostadinov 29 May 2021, 11:25:53 UTC build: fix linting against jasmine focus functions (#42415) We were linting against usages of `fdescribe` and `fit` by referencing the `no-jasmine-focus` rule which isn't installed, causing tslint to log the following: ``` Could not find implementations for the following rules specified in the configuration: no-jasmine-focus Try upgrading TSLint and/or ensuring that you have all necessary custom rules installed. If TSLint was recently upgraded, you may have old rules configured which need to be cleaned ``` These changes switch to using the built-in `ban` rule. PR Close #42415 01 June 2021, 17:16:56 UTC
a31e55e George Kalpakas 30 May 2021, 19:11:26 UTC docs(docs-infra): document the implementation of styles (incl. theming) in angular.io (#42396) PR Close #42396 01 June 2021, 17:16:22 UTC
c98b232 George Kalpakas 30 May 2021, 19:11:26 UTC fix(docs-infra): improve homepage layout in print mode (#42396) In #41129, the `.hero-logo` image was changed from an `<img>` element to a `<div>` with an image background. As a result, in print mode (where browsers often omit backgrounds to save ink) the logo was not present. This commit fixes this by ensuring the word `Angular` is displayed as a title instead of the logo in print mode. It also hides the `Get started` button in print mode, since it doesn't add any value. Before: ![homepage-print before][1] After: ![homepage-print after][2] [1]: https://user-images.githubusercontent.com/8604205/120068867-889e6080-c08b-11eb-9bd5-233d8592f7ec.png [2]: https://user-images.githubusercontent.com/8604205/120068869-89cf8d80-c08b-11eb-8740-a68a5ef68c34.png PR Close #42396 01 June 2021, 17:16:22 UTC
9c798e2 George Kalpakas 30 May 2021, 19:11:25 UTC refactor(docs-infra): remove unused `_typography-theme.scss` file (#42396) This commit removes the `_typography-theme.scss` file that is currently not used. The file contains a single Sass mixin (`docs-site-typography-theme()`), which is never called. PR Close #42396 01 June 2021, 17:16:21 UTC
c750953 George Kalpakas 30 May 2021, 19:11:25 UTC refactor(docs-infra): minor refactorings/style changes (#42396) This commit includes some minor refactorings and style changes as a follow-up to PR #41129. (The changes were minor enough that didn't warrant blocking the PR.) PR Close #42396 01 June 2021, 17:16:21 UTC
c655810 Joey Perrott 27 May 2021, 19:14:36 UTC refactor(dev-infra): update to later version of @octokit/rest and remove class extenstion of Octokit (#42395) Update @octokit/rest and remove the usage of a class extension of Octokit as the class does not have a class define constructor. PR Close #42395 01 June 2021, 17:14:48 UTC
466d367 George Kalpakas 27 May 2021, 13:48:45 UTC build: allow Node.js v15 and above for local development (#42387) This commit changes the `engines` rules in the root `package.json` as well as the `package.json` used when working on docs example to also accept Node.js versions greater than v14. This aligns them with `aio/package.json` and allows using Node.js v15 and v16 (current) for local development in the `angular/angular` repo. Related to #42367. PR Close #42387 01 June 2021, 17:14:08 UTC
89954fe Dylan Hunn 27 May 2021, 01:34:42 UTC docs(forms): make the forms validation guide specify more clearly what happens when mixing HTML5 native validators with Angular forms. (#42377) Previously, the docs didn't say anything about the fact that the `novalidate` attribute is added to the enclosing form, or how to override that behavior. I have added a couple lines in the appropriate spot clarifying this issue. PR Close #42377 01 June 2021, 17:13:37 UTC
50188bb Doug Parker 26 May 2021, 21:56:27 UTC docs: update CLI builder to be platform agnostic (#42371) Fixes #35373. This changes the example from "run an arbitrary process" to "copy a file". This should make it a bit easier to follow, require less background knowledge to understand, and not use any platform-specific commands that won't work for Windows users. The most glaring issue with this change is that this doc does not explictly specify how to build and run a builder. I've updated some of the files to hint at this a bit more (such as the `"implementation": "./dist/my-builder.js"`), but another pass is required to figure out the best way to compile a builder and how we want to structure this example to best communicate that. PR Close #42371 01 June 2021, 17:13:03 UTC
dd8f458 Doug Parker 26 May 2021, 18:10:40 UTC docs: minor cleanup (#42371) Mainly just fixing some spacing and adding `.prototype` for non-static properties. PR Close #42371 01 June 2021, 17:13:03 UTC
bf931d3 Andrew Scott 26 May 2021, 21:25:16 UTC docs: list supported values for `read` in decorator metadata (#42370) fixes #20927 PR Close #42370 01 June 2021, 17:12:24 UTC
35ec0f9 George Kalpakas 27 May 2021, 15:22:37 UTC build(docs-infra): fix linting warnings (#42359) This commit fixes some linting warning that were printed when running `ng lint`. The warnings can be seen in the `lint` step of [this CI job][1]. Most of the warnings were related to the deprecation of passing context to Jasmine matchers in favor of using the [withContext()][2] matcher (introduced in Jasmine v3.3.0). [1]: https://circleci.com/gh/angular/angular/995543 [2]: https://jasmine.github.io/api/3.3/matchers.html#withContext PR Close #42359 01 June 2021, 17:11:48 UTC
702765b Andrew Scott 25 May 2021, 21:26:42 UTC docs: add docs for DebugElement (#42352) fixes #36048 PR Close #42352 28 May 2021, 00:02:24 UTC
644ef7a Igor Minar 27 May 2021, 21:15:25 UTC docs: expand documentation for ROUTES (#42398) Previously the docs were very minimalistic. The most important thing missing from the docs was that people should primarily use higher level APIs instead of using ROUTES directly. It would be nice to holistically overhaul more of the router API docs, but that's out of scope of this change. Fixes #39350 PR Close #42398 27 May 2021, 23:47:39 UTC
2736465 Teri Glover 10 May 2021, 22:46:31 UTC docs: Edits to remove jargon in Reference section (#42033) PR Close #42033 27 May 2021, 23:47:06 UTC
d0cd45b Teri Glover 10 May 2021, 16:09:25 UTC docs: edits to remove jargon (#42025) PR Close #42025 27 May 2021, 23:46:12 UTC
5de31d6 Teri Glover 18 May 2021, 17:04:23 UTC docs: Edited to remove jargon, fixed issue (#42026) PR Close #42026 27 May 2021, 22:37:15 UTC
db9340b Teri Glover 10 May 2021, 17:51:50 UTC docs: Edits to remove jargon (#42026) PR Close #42026 27 May 2021, 22:37:14 UTC
46105af Teri Glover 07 May 2021, 04:28:01 UTC docs: Edited to remove jargon. (#41978) PR Close #41978 27 May 2021, 22:36:38 UTC
b60c9c1 Andrew Scott 27 May 2021, 17:57:24 UTC docs: clarify behavior of strict templates flags (#42392) fixes #39355 PR Close #42392 27 May 2021, 21:08:51 UTC
a261489 Andrew Scott 27 May 2021, 17:44:52 UTC docs: change markdown table to HTML table in template typecheck doc (#42392) PR Close #42392 27 May 2021, 21:08:50 UTC
eb6f6eb Joey Perrott 25 May 2021, 21:34:28 UTC docs: clarify the shortcomings of local variable technique for parent-child component interactions (#42331) Closes #38302 PR Close #42331 27 May 2021, 21:04:44 UTC
a86a6b9 AleksanderBodurri 09 March 2021, 04:27:16 UTC feat(docs-infra): implement dark mode (#41129) defines styles for a first iteration of an aio darkmode PR Close #41129 27 May 2021, 18:24:55 UTC
49efc4a AleksanderBodurri 09 March 2021, 04:02:24 UTC feat(docs-infra): create module theme files (#41129) creates theming files for the module styles in aio; done as part of the effor to make aio themeable PR Close #41129 27 May 2021, 18:24:55 UTC
df7e20c AleksanderBodurri 09 March 2021, 02:10:25 UTC feat(docs-infra): create typography and layout theme files (#41129) creates theming files for the aio typography styles; done as part of the effort to make aio themeable PR Close #41129 27 May 2021, 18:24:54 UTC
cfcb903 AleksanderBodurri 09 March 2021, 01:03:30 UTC refactor(docs-infra): grab scss mixins with scss use syntax instead of global imports (#41129) move away from global mixins because @import is going to be deprecated PR Close #41129 27 May 2021, 18:24:54 UTC
8496fb7 AleksanderBodurri 09 March 2021, 00:23:10 UTC refactor(docs-infra): grab scss constants using scss use syntax instead of the global imports (#41129) move away from using global constants in scss files because @import will be deprecated soon PR Close #41129 27 May 2021, 18:24:54 UTC
91210d1 AleksanderBodurri 09 March 2021, 00:03:03 UTC refactor(docs-infra): rename namespaced scss to index files (#41129) scss files were forwarded from files that were named without convention, changes these file names to follow conventions PR Close #41129 27 May 2021, 18:24:54 UTC
29f805c AleksanderBodurri 06 February 2021, 02:18:31 UTC feat(docs-infra): port over material io theming logic to angular io (#41129) brings in theming tools from material io into angular io in preparation of implementing darkmode PR Close #41129 27 May 2021, 18:24:54 UTC
back to top