Revision e068b3f8e4d6ec6d629b5e2b92d57dca3ab775d2 authored by Waleed Khan on 16 October 2019, 00:58:34 UTC, committed by Facebook Github Bot on 16 October 2019, 01:02:59 UTC
Summary: Most RPC errors are detected in the `do_rpc` function, and returned to the caller appropriately. However, the "initialize" method is not handled by `do_rpc` because the event loop isn't up and running yet -- it only becomes so after having successfully initialized. Errors happening at this point were dropped silently, and serverless IDE was treated as having succeeded in initializing even though every subsequent request would probably fail. This commit detects errors that happen when initializing, particularly the failure to load a saved-state. Reviewed By: jewelpit Differential Revision: D17916261 fbshipit-source-id: 264666c99a23bdb21d9c6eeda1d55e1023411700
1 parent d228e5c
| File | Mode | Size |
|---|---|---|
| CMake | ||
| hphp | ||
| patches | ||
| third-party @ 3a85355 | ||
| .gitignore | -rw-r--r-- | 1.5 KB |
| .gitmodules | -rw-r--r-- | 114 bytes |
| CMakeLists.txt | -rw-r--r-- | 3.8 KB |
| CODE_OF_CONDUCT.md | -rw-r--r-- | 3.3 KB |
| CONTRIBUTING.md | -rw-r--r-- | 3.3 KB |
| ISSUE_TEMPLATE.md | -rw-r--r-- | 637 bytes |
| LICENSE.PHP | -rw-r--r-- | 3.1 KB |
| LICENSE.ZEND | -rw-r--r-- | 2.7 KB |
| README.md | -rw-r--r-- | 2.9 KB |
| SECURITY.md | -rw-r--r-- | 449 bytes |
| configure | -rwxr-xr-x | 642 bytes |
Computing file changes ...
