Skip to main content

Browse the archive

https://github.com/git/git
05 April 2024, 19:32:26 UTC
Revision e1e12e97ac73ded85f7d000da1063a774b3cc14f authored by Patrick Steinhardt on 01 December 2022, 14:45:36 UTC, committed by Junio C Hamano on 05 December 2022, 06:14:16 UTC 
attr: fix integer overflow with more than INT_MAX macros
 
Attributes have a field that tracks the position in the `all_attrs`
array they're stored inside. This field gets set via `hashmap_get_size`
when adding the attribute to the global map of attributes. But while the
field is of type `int`, the value returned by `hashmap_get_size` is an
`unsigned int`. It can thus happen that the value overflows, where we
would now dereference teh `all_attrs` array at an out-of-bounds value.

We do have a sanity check for this overflow via an assert that verifies
the index matches the new hashmap's size. But asserts are not a proper
mechanism to detect against any such overflows as they may not in fact
be compiled into production code.

Fix this by using an `unsigned int` to track the index and convert the
assert to a call `die()`.

Reported-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 447ac90
History
Tip revision: e1e12e97ac73ded85f7d000da1063a774b3cc14f authored by Patrick Steinhardt on 01 December 2022, 14:45:36 UTC
attr: fix integer overflow with more than INT_MAX macros
Tip revision: e1e12e9
File Mode Size
config
util
install-dependencies.sh -rwxr-xr-x 2.7 KB
install-docker-dependencies.sh -rwxr-xr-x 441 bytes
lib.sh -rwxr-xr-x 6.9 KB
make-test-artifacts.sh -rwxr-xr-x 211 bytes
mount-fileshare.sh -rwxr-xr-x 505 bytes
print-test-failures.sh -rwxr-xr-x 2.7 KB
run-build-and-tests.sh -rwxr-xr-x 934 bytes
run-docker-build.sh -rwxr-xr-x 1.9 KB
run-docker.sh -rwxr-xr-x 1.0 KB
run-static-analysis.sh -rwxr-xr-x 497 bytes
run-test-slice.sh -rwxr-xr-x 347 bytes
test-documentation.sh -rwxr-xr-x 1.1 KB
back to top