Skip to main content

Browse the archive

Revision e26d574c47db36dfbc9277c33c7c64fcaa69d884 authored by Jonas Rembser on 05 April 2024, 13:21:19 UTC, committed by Jonas Rembser on 05 April 2024, 15:20:59 UTC 
[CMake] Fix ordering problem when checking and setting `cuda` flag
 
In the ROOT build system, `CheckCompiler` is included before
`RootBuildOptions`. The problem with this is that when building with
`-Dall=ON`, the `cuda` flag is only set in `RootBuildOptions`, which is
too late to find the CUDA compiler in `CheckCompiler`. This results in
issues like #15139:
```
CMake Error in roofit/batchcompute/CMakeLists.txt:
  Exporting the target "RooBatchCompute_CUDA" is not allowed since its linker
  language cannot be determined
```

This commit suggests a solution to this problem: just always enable the
CUDA language in CMake if it is found, and only set the `cuda` flag with
`-Dall=ON` if the CUDA language is enabled.
1 parent f409a6f
Raw File
.gitattributes 
# Set default behaviour, in case users don't have core.autocrlf set.
* text=auto

# Declare files that will always have CRLF line endings on checkout.
*.sln eol=crlf
*.dsp eol=crlf
*.dsw eol=crlf
*.bat eol=crlf
*.cs  eol=crlf
*.csproj eol=crlf
*.vsct  eol=crlf
*.resx  eol=crlf
*.vsixmanifest  eol=crlf
tree/dataframe/test/RCsvDS_test_win.csv  eol=crlf

# Files in the LLVM monorepo are not normalized, avoid whitespace diffs.
interpreter/llvm-project/** -text

# Denote all files that are truly binary and should not be modified.
*.png binary
*.jpg binary
*.pdf binary
*.root binary
*.fits binary
back to top