Revision e493f2f54e90bc6aa42c4708e32f88af6e4e4e1e authored by Igor Canadi on 19 March 2014, 23:01:25 UTC, committed by Igor Canadi on 19 March 2014, 23:01:25 UTC
Summary: We have an issue with internal service trying to run compaction with zero input files: 2014/02/07-02:26:58.386531 7f79117ec700 Compaction start summary: Base version 1420 Base level 3, seek compaction:0, inputs:[ϛ~^Qy^?],[] 2014/02/07-02:26:58.386539 7f79117ec700 Compacted 0@3 + 0@4 files => 0 bytes There are two issues: * inputsummary is printing out junk * it's constantly retrying (since I guess madeProgress is true), so it prints out a lot of data in the LOG file (40GB in one day). I read through the Level compaction picker and added some failure condition if input[0] is empty. I think PickCompaction() should not return compaction with zero input files with this change. I'm not confident enough to add an assertion though :) Test Plan: make check Reviewers: dhruba, haobo, sdong, kailiu Reviewed By: haobo CC: leveldb Differential Revision: https://reviews.facebook.net/D16005
1 parent 1ad0c2f
| File | Mode | Size |
|---|---|---|
| build_tools | ||
| coverage | ||
| db | ||
| doc | ||
| hdfs | ||
| helpers | ||
| include | ||
| linters | ||
| port | ||
| table | ||
| tools | ||
| util | ||
| utilities | ||
| .arcconfig | -rw-r--r-- | 246 bytes |
| .clang-format | -rw-r--r-- | 138 bytes |
| .gitignore | -rw-r--r-- | 240 bytes |
| CONTRIBUTING.md | -rw-r--r-- | 776 bytes |
| HISTORY.md | -rw-r--r-- | 3.3 KB |
| INSTALL.md | -rw-r--r-- | 3.2 KB |
| LICENSE | -rw-r--r-- | 1.6 KB |
| Makefile | -rw-r--r-- | 18.6 KB |
| PATENTS | -rw-r--r-- | 1.4 KB |
| README | -rw-r--r-- | 2.9 KB |
| README.fb | -rw-r--r-- | 96 bytes |
Computing file changes ...
