Skip to main content

Browse the archive

Revision e632abed41c5cd71507c4222e1e85987556b232c authored by David Douard on 13 May 2020, 15:03:01 UTC, committed by David Douard on 24 June 2020, 15:39:02 UTC 
Tag model entities with their "object_type"
 
this aims at preventing constant usage of isinstance() based dispatch
code when writing generic code handling model entities.

For example, the "object_type" argument of JournalWriter.write_addition() has
become superflous now we only pass model entities, etc.

This idea comes olasd's reading of mypy doc:

  https://mypy.readthedocs.io/en/latest/literal_types.html#tagged-unions

This comes with a refactoring of from_dict.DiskBackedContent to make
it *not* inherit from model.Content: object_type being Final, it cannot
be overloaded.
1 parent 661b7c2
Raw File
mypy.ini 
[mypy]
namespace_packages = True
warn_unused_ignores = True

# 3rd party libraries without stubs (yet)

[mypy-attrs_strict.*]  # a bit sad, but...
ignore_missing_imports = True

[mypy-django.*]  # false positive, only used my hypotesis' extras
ignore_missing_imports = True

[mypy-dulwich.*]
ignore_missing_imports = True

[mypy-iso8601.*]
ignore_missing_imports = True

[mypy-pkg_resources.*]
ignore_missing_imports = True

[mypy-pyblake2.*]
ignore_missing_imports = True

[mypy-pytest.*]
ignore_missing_imports = True
back to top