Skip to main content

Browse the archive

Revision e6567463ac838605f3386dd10f2c5a244706d47c authored by David Bimmler on 26 February 2024, 13:58:22 UTC, committed by Louis DeLosSantos on 27 February 2024, 14:34:49 UTC 
statedb/reflector: fix race condition in test
 
The test assumed that the initial list and watch of the underlying k8s
reflector would complete before the 'Get' query would establish, but
that wasn't guaranteed.

Instead, explicitly synchronise for this case.

Fixes: 0554ca6811 (statedb/reflector: Add Kubernetes to StateDB reflector)

Signed-off-by: David Bimmler <david.bimmler@isovalent.com>
1 parent 1eb12e0
Raw File
mcastmanager_test.go 
// SPDX-License-Identifier: Apache-2.0
// Copyright Authors of Cilium

package mcastmanager

import (
	"net/netip"
	"testing"

	. "github.com/cilium/checkmate"
	"github.com/vishvananda/netlink"
)

func Test(t *testing.T) { TestingT(t) }

type McastManagerSuite struct {
}

var _ = Suite(&McastManagerSuite{})

func (m *McastManagerSuite) TestAddRemoveEndpoint(c *C) {
	ifaces, err := netlink.LinkList()
	c.Assert(err, IsNil)

	if len(ifaces) == 0 {
		c.Skip("no interfaces to test")
	}

	mgr := New(ifaces[0].Attrs().Name)

	// Add first endpoint
	mgr.AddAddress(netip.MustParseAddr("f00d::1234"))

	c.Assert(mgr.state, HasLen, 1)
	_, ok := mgr.state[netip.MustParseAddr("ff02::1:ff00:1234")]
	c.Assert(ok, Equals, true)

	// Add another endpoint that shares the same maddr
	mgr.AddAddress(netip.MustParseAddr("f00d:aabb::1234"))

	c.Assert(mgr.state, HasLen, 1)

	// Remove the first endpoint
	mgr.RemoveAddress(netip.MustParseAddr("f00d::1234"))

	c.Assert(mgr.state, HasLen, 1)
	_, ok = mgr.state[netip.MustParseAddr("ff02::1:ff00:1234")]
	c.Assert(ok, Equals, true)

	// Remove the second endpoint
	mgr.RemoveAddress(netip.MustParseAddr("f00d:aabb::1234"))

	c.Assert(mgr.state, HasLen, 0)
	_, ok = mgr.state[netip.MustParseAddr("ff02::1:ff00:1234")]
	c.Assert(ok, Equals, false)
}

func (m *McastManagerSuite) TestAddRemoveNil(c *C) {
	ifaces, err := netlink.LinkList()
	c.Assert(err, IsNil)

	if len(ifaces) == 0 {
		c.Skip("no interfaces to test")
	}

	var (
		iface = ifaces[0]
		mgr   = New(iface.Attrs().Name)
	)

	mgr.AddAddress(netip.Addr{})
	c.Assert(mgr.state, HasLen, 0)
	mgr.RemoveAddress(netip.Addr{})
	c.Assert(mgr.state, HasLen, 0)
}
back to top