https://github.com/torvalds/linux
Revision e69a5c010246ca6a87c4e6f13d0a291954bdece8 authored by Zhengjun Xing on 01 June 2022, 15:25:44 UTC, committed by Arnaldo Carvalho de Melo on 03 June 2022, 19:12:34 UTC
For the hybrid system, the "slots" event changes to "cpu_core/slots/", need
extend API arch_evsel__must_be_in_group() to support hybrid systems.

In the origin code, for hybrid system event "cpu_core/slots/", the output
of the API arch_evsel__must_be_in_group() is "false" (in fact,it should be
"true"). Currently only one API evsel__remove_from_group() calls it. In
evsel__remove_from_group(), it adds the second condition to check, so the
output of evsel__remove_from_group() still is correct. That's the reason
why there isn't an instant error. I'd like to fix the issue found in API
arch_evsel__must_be_in_group() in case someone else using the function in
the other place.

Fixes: d98079c05b5a ("perf evlist: Keep topdown counters in weak group")
Signed-off-by: Zhengjun Xing <zhengjun.xing@linux.intel.com>
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Acked-by: Ian Rogers <irogers@google.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Link: https://lore.kernel.org/r/20220601152544.1842447-1-zhengjun.xing@linux.intel.com
Cc: peterz@infradead.org
Cc: adrian.hunter@intel.com
Cc: alexander.shishkin@intel.com
Cc: acme@kernel.org
Cc: ak@linux.intel.com
Cc: jolsa@redhat.com
Cc: mingo@redhat.com
Cc: linux-kernel@vger.kernel.org
Cc: linux-perf-users@vger.kernel.org
1 parent 9be4cbd
History
Tip revision: e69a5c010246ca6a87c4e6f13d0a291954bdece8 authored by Zhengjun Xing on 01 June 2022, 15:25:44 UTC
perf evlist: Extend arch_evsel__must_be_in_group to support hybrid systems
Tip revision: e69a5c0
File Mode Size
devices
joydev
event-codes.rst -rw-r--r-- 16.8 KB
ff.rst -rw-r--r-- 7.6 KB
gamepad.rst -rw-r--r-- 7.3 KB
gameport-programming.rst -rw-r--r-- 6.3 KB
index.rst -rw-r--r-- 254 bytes
input-programming.rst -rw-r--r-- 12.8 KB
input.rst -rw-r--r-- 8.9 KB
input_kapi.rst -rw-r--r-- 277 bytes
input_uapi.rst -rw-r--r-- 330 bytes
interactive.svg -rw-r--r-- 3.3 KB
multi-touch-protocol.rst -rw-r--r-- 17.5 KB
notifier.rst -rw-r--r-- 1.8 KB
shape.svg -rw-r--r-- 5.5 KB
uinput.rst -rw-r--r-- 6.6 KB
userio.rst -rw-r--r-- 2.9 KB

back to top