Revision e6da7c9fed111ba1243297ee6eda8e24ae11c384 authored by Eric Sandeen on 23 May 2009, 19:30:12 UTC, committed by Felix Blyakher on 02 June 2009, 03:59:38 UTC
In the case where growing a filesystem would leave the last AG too small, the fixup code has an overflow in the calculation of the new size with one fewer ag, because "nagcount" is a 32 bit number. If the new filesystem has > 2^32 blocks in it this causes a problem resulting in an EINVAL return from growfs: # xfs_io -f -c "truncate 19998630180864" fsfile # mkfs.xfs -f -bsize=4096 -dagsize=76288719b,size=3905982455b fsfile # mount -o loop fsfile /mnt # xfs_growfs /mnt meta-data=/dev/loop0 isize=256 agcount=52, agsize=76288719 blks = sectsz=512 attr=2 data = bsize=4096 blocks=3905982455, imaxpct=5 = sunit=0 swidth=0 blks naming =version 2 bsize=4096 ascii-ci=0 log =internal bsize=4096 blocks=32768, version=2 = sectsz=512 sunit=0 blks, lazy-count=0 realtime =none extsz=4096 blocks=0, rtextents=0 xfs_growfs: XFS_IOC_FSGROWFSDATA xfsctl failed: Invalid argument Reported-by: richard.ems@cape-horn-eng.com Signed-off-by: Eric Sandeen <sandeen@sandeen.net> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Felix Blyakher <felixb@sgi.com> Signed-off-by: Felix Blyakher <felixb@sgi.com>
1 parent 1f23920
File | Mode | Size |
---|---|---|
debugfs-pktcdvd | -rw-r--r-- | 415 bytes |
ima_policy | -rw-r--r-- | 1.9 KB |
procfs-diskstats | -rw-r--r-- | 654 bytes |
sysfs-block | -rw-r--r-- | 1.8 KB |
sysfs-bus-css | -rw-r--r-- | 1.4 KB |
sysfs-bus-pci | -rw-r--r-- | 4.9 KB |
sysfs-bus-umc | -rw-r--r-- | 1018 bytes |
sysfs-bus-usb | -rw-r--r-- | 5.3 KB |
sysfs-bus-usb-devices-usbsevseg | -rw-r--r-- | 1.5 KB |
sysfs-c2port | -rw-r--r-- | 2.9 KB |
sysfs-class | -rw-r--r-- | 520 bytes |
sysfs-class-bdi | -rw-r--r-- | 1.5 KB |
sysfs-class-pktcdvd | -rw-r--r-- | 2.7 KB |
sysfs-class-regulator | -rw-r--r-- | 10.1 KB |
sysfs-class-usb_host | -rw-r--r-- | 1.1 KB |
sysfs-class-uwb_rc | -rw-r--r-- | 5.1 KB |
sysfs-dev | -rw-r--r-- | 693 bytes |
sysfs-devices | -rw-r--r-- | 1021 bytes |
sysfs-devices-memory | -rw-r--r-- | 2.9 KB |
sysfs-firmware-acpi | -rw-r--r-- | 4.1 KB |
sysfs-firmware-memmap | -rw-r--r-- | 2.3 KB |
sysfs-firmware-sgi_uv | -rw-r--r-- | 889 bytes |
sysfs-fs-ext4 | -rw-r--r-- | 2.6 KB |
sysfs-gpio | -rw-r--r-- | 1.1 KB |
sysfs-ibft | -rw-r--r-- | 1022 bytes |
sysfs-kernel-mm | -rw-r--r-- | 202 bytes |
sysfs-kernel-mm-hugepages | -rw-r--r-- | 521 bytes |
sysfs-kernel-uids | -rw-r--r-- | 658 bytes |
sysfs-ocfs2 | -rw-r--r-- | 3.0 KB |
sysfs-power | -rw-r--r-- | 4.1 KB |
sysfs-profiling | -rw-r--r-- | 331 bytes |
sysfs-wusb_cbaf | -rw-r--r-- | 3.9 KB |
Computing file changes ...