Revision e6da7c9fed111ba1243297ee6eda8e24ae11c384 authored by Eric Sandeen on 23 May 2009, 19:30:12 UTC, committed by Felix Blyakher on 02 June 2009, 03:59:38 UTC
In the case where growing a filesystem would leave the last AG
too small, the fixup code has an overflow in the calculation
of the new size with one fewer ag, because "nagcount" is a 32
bit number.  If the new filesystem has > 2^32 blocks in it
this causes a problem resulting in an EINVAL return from growfs:

 # xfs_io -f -c "truncate 19998630180864" fsfile
 # mkfs.xfs -f -bsize=4096 -dagsize=76288719b,size=3905982455b fsfile
 # mount -o loop fsfile /mnt
 # xfs_growfs /mnt

meta-data=/dev/loop0             isize=256    agcount=52,
agsize=76288719 blks
         =                       sectsz=512   attr=2
data     =                       bsize=4096   blocks=3905982455, imaxpct=5
         =                       sunit=0      swidth=0 blks
naming   =version 2              bsize=4096   ascii-ci=0
log      =internal               bsize=4096   blocks=32768, version=2
         =                       sectsz=512   sunit=0 blks, lazy-count=0
realtime =none                   extsz=4096   blocks=0, rtextents=0
xfs_growfs: XFS_IOC_FSGROWFSDATA xfsctl failed: Invalid argument

Reported-by: richard.ems@cape-horn-eng.com
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Felix Blyakher <felixb@sgi.com>
Signed-off-by: Felix Blyakher <felixb@sgi.com>
1 parent 1f23920
History
File Mode Size
.gitignore -rw-r--r-- 35 bytes
Makefile -rw-r--r-- 7.3 KB
alsa-driver-api.tmpl -rw-r--r-- 3.1 KB
debugobjects.tmpl -rw-r--r-- 13.8 KB
device-drivers.tmpl -rw-r--r-- 13.5 KB
deviceiobook.tmpl -rw-r--r-- 11.0 KB
filesystems.tmpl -rw-r--r-- 13.0 KB
gadget.tmpl -rw-r--r-- 29.9 KB
genericirq.tmpl -rw-r--r-- 15.6 KB
kernel-api.tmpl -rw-r--r-- 8.7 KB
kernel-hacking.tmpl -rw-r--r-- 42.8 KB
kernel-locking.tmpl -rw-r--r-- 66.0 KB
kgdb.tmpl -rw-r--r-- 18.7 KB
libata.tmpl -rw-r--r-- 46.9 KB
librs.tmpl -rw-r--r-- 8.0 KB
lsm.tmpl -rw-r--r-- 12.0 KB
mac80211.tmpl -rw-r--r-- 10.8 KB
mcabook.tmpl -rw-r--r-- 3.0 KB
mtdnand.tmpl -rw-r--r-- 44.6 KB
networking.tmpl -rw-r--r-- 2.9 KB
procfs-guide.tmpl -rw-r--r-- 19.5 KB
procfs_example.c -rw-r--r-- 4.6 KB
rapidio.tmpl -rw-r--r-- 4.6 KB
regulator.tmpl -rw-r--r-- 9.8 KB
s390-drivers.tmpl -rw-r--r-- 5.4 KB
scsi.tmpl -rw-r--r-- 14.5 KB
sh.tmpl -rw-r--r-- 2.6 KB
stylesheet.xsl -rw-r--r-- 361 bytes
uio-howto.tmpl -rw-r--r-- 28.6 KB
usb.tmpl -rw-r--r-- 38.4 KB
writing-an-alsa-driver.tmpl -rw-r--r-- 200.1 KB
writing_usb_driver.tmpl -rw-r--r-- 17.0 KB
z8530book.tmpl -rw-r--r-- 14.7 KB

back to top