Revision e6da7c9fed111ba1243297ee6eda8e24ae11c384 authored by Eric Sandeen on 23 May 2009, 19:30:12 UTC, committed by Felix Blyakher on 02 June 2009, 03:59:38 UTC
In the case where growing a filesystem would leave the last AG too small, the fixup code has an overflow in the calculation of the new size with one fewer ag, because "nagcount" is a 32 bit number. If the new filesystem has > 2^32 blocks in it this causes a problem resulting in an EINVAL return from growfs: # xfs_io -f -c "truncate 19998630180864" fsfile # mkfs.xfs -f -bsize=4096 -dagsize=76288719b,size=3905982455b fsfile # mount -o loop fsfile /mnt # xfs_growfs /mnt meta-data=/dev/loop0 isize=256 agcount=52, agsize=76288719 blks = sectsz=512 attr=2 data = bsize=4096 blocks=3905982455, imaxpct=5 = sunit=0 swidth=0 blks naming =version 2 bsize=4096 ascii-ci=0 log =internal bsize=4096 blocks=32768, version=2 = sectsz=512 sunit=0 blks, lazy-count=0 realtime =none extsz=4096 blocks=0, rtextents=0 xfs_growfs: XFS_IOC_FSGROWFSDATA xfsctl failed: Invalid argument Reported-by: richard.ems@cape-horn-eng.com Signed-off-by: Eric Sandeen <sandeen@sandeen.net> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Felix Blyakher <felixb@sgi.com> Signed-off-by: Felix Blyakher <felixb@sgi.com>
1 parent 1f23920
File | Mode | Size |
---|---|---|
CREDITS | -rw-r--r-- | 7.2 KB |
URB.txt | -rw-r--r-- | 9.4 KB |
WUSB-Design-overview.txt | -rw-r--r-- | 17.8 KB |
acm.txt | -rw-r--r-- | 4.9 KB |
anchors.txt | -rw-r--r-- | 2.6 KB |
authorization.txt | -rw-r--r-- | 2.6 KB |
callbacks.txt | -rw-r--r-- | 4.7 KB |
dma.txt | -rw-r--r-- | 6.2 KB |
ehci.txt | -rw-r--r-- | 9.6 KB |
error-codes.txt | -rw-r--r-- | 5.9 KB |
gadget_printer.txt | -rw-r--r-- | 10.7 KB |
gadget_serial.txt | -rw-r--r-- | 13.1 KB |
hiddev.txt | -rw-r--r-- | 8.9 KB |
hotplug.txt | -rw-r--r-- | 6.3 KB |
iuu_phoenix.txt | -rw-r--r-- | 2.7 KB |
linux.inf | -rw-r--r-- | 6.2 KB |
misc_usbsevseg.txt | -rw-r--r-- | 1.5 KB |
mtouchusb.txt | -rw-r--r-- | 2.8 KB |
ohci.txt | -rw-r--r-- | 1.5 KB |
persist.txt | -rw-r--r-- | 7.4 KB |
power-management.txt | -rw-r--r-- | 23.8 KB |
proc_usb_info.txt | -rw-r--r-- | 14.7 KB |
rio.txt | -rw-r--r-- | 4.3 KB |
usb-help.txt | -rw-r--r-- | 495 bytes |
usb-serial.txt | -rw-r--r-- | 18.0 KB |
usbmon.txt | -rw-r--r-- | 14.4 KB |
wusb-cbaf | -rw-r--r-- | 3.2 KB |
Computing file changes ...