Revision e6da7c9fed111ba1243297ee6eda8e24ae11c384 authored by Eric Sandeen on 23 May 2009, 19:30:12 UTC, committed by Felix Blyakher on 02 June 2009, 03:59:38 UTC
In the case where growing a filesystem would leave the last AG
too small, the fixup code has an overflow in the calculation
of the new size with one fewer ag, because "nagcount" is a 32
bit number.  If the new filesystem has > 2^32 blocks in it
this causes a problem resulting in an EINVAL return from growfs:

 # xfs_io -f -c "truncate 19998630180864" fsfile
 # mkfs.xfs -f -bsize=4096 -dagsize=76288719b,size=3905982455b fsfile
 # mount -o loop fsfile /mnt
 # xfs_growfs /mnt

meta-data=/dev/loop0             isize=256    agcount=52,
agsize=76288719 blks
         =                       sectsz=512   attr=2
data     =                       bsize=4096   blocks=3905982455, imaxpct=5
         =                       sunit=0      swidth=0 blks
naming   =version 2              bsize=4096   ascii-ci=0
log      =internal               bsize=4096   blocks=32768, version=2
         =                       sectsz=512   sunit=0 blks, lazy-count=0
realtime =none                   extsz=4096   blocks=0, rtextents=0
xfs_growfs: XFS_IOC_FSGROWFSDATA xfsctl failed: Invalid argument

Reported-by: richard.ems@cape-horn-eng.com
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Felix Blyakher <felixb@sgi.com>
Signed-off-by: Felix Blyakher <felixb@sgi.com>
1 parent 1f23920
History
File Mode Size
bttv
cx2341x
cx88
.gitignore -rw-r--r-- 8 bytes
API.html -rw-r--r-- 738 bytes
CARDLIST.au0828 -rw-r--r-- 527 bytes
CARDLIST.bttv -rw-r--r-- 8.8 KB
CARDLIST.cx23885 -rw-r--r-- 1.3 KB
CARDLIST.cx88 -rw-r--r-- 5.5 KB
CARDLIST.em28xx -rw-r--r-- 4.4 KB
CARDLIST.ivtv -rw-r--r-- 1.1 KB
CARDLIST.saa7134 -rw-r--r-- 9.0 KB
CARDLIST.tuner -rw-r--r-- 2.8 KB
CARDLIST.usbvision -rw-r--r-- 4.8 KB
CQcam.txt -rw-r--r-- 6.9 KB
Makefile -rw-r--r-- 212 bytes
README.cpia -rw-r--r-- 7.1 KB
README.cpia2 -rw-r--r-- 5.6 KB
README.cx88 -rw-r--r-- 2.1 KB
README.ir -rw-r--r-- 2.3 KB
README.ivtv -rw-r--r-- 6.3 KB
README.pvrusb2 -rw-r--r-- 9.6 KB
README.saa7134 -rw-r--r-- 1.9 KB
Zoran -rw-r--r-- 22.3 KB
cafe_ccic -rw-r--r-- 2.4 KB
cpia2_overview.txt -rw-r--r-- 2.3 KB
cx18.txt -rw-r--r-- 810 bytes
et61x251.txt -rw-r--r-- 11.1 KB
extract_xc3028.pl -rw-r--r-- 23.7 KB
gspca.txt -rw-r--r-- 10.9 KB
hauppauge-wintv-cx88-ir.txt -rw-r--r-- 1.9 KB
ibmcam.txt -rw-r--r-- 13.6 KB
lifeview.txt -rw-r--r-- 1.5 KB
m5602.txt -rw-r--r-- 549 bytes
meye.txt -rw-r--r-- 4.5 KB
not-in-cx2388x-datasheet.txt -rw-r--r-- 953 bytes
ov511.txt -rw-r--r-- 10.7 KB
radiotrack.txt -rw-r--r-- 5.7 KB
se401.txt -rw-r--r-- 1.5 KB
si470x.txt -rw-r--r-- 4.6 KB
sn9c102.txt -rw-r--r-- 22.2 KB
soc-camera.txt -rw-r--r-- 4.7 KB
stv680.txt -rw-r--r-- 1.6 KB
v4l2-framework.txt -rw-r--r-- 24.7 KB
v4lgrab.c -rw-r--r-- 5.7 KB
w9966.txt -rw-r--r-- 1.2 KB
w9968cf.txt -rw-r--r-- 17.6 KB
zc0301.txt -rw-r--r-- 8.4 KB
zr364xx.txt -rw-r--r-- 3.3 KB

README.cpia

back to top