Revision e6da7c9fed111ba1243297ee6eda8e24ae11c384 authored by Eric Sandeen on 23 May 2009, 19:30:12 UTC, committed by Felix Blyakher on 02 June 2009, 03:59:38 UTC
In the case where growing a filesystem would leave the last AG
too small, the fixup code has an overflow in the calculation
of the new size with one fewer ag, because "nagcount" is a 32
bit number. If the new filesystem has > 2^32 blocks in it
this causes a problem resulting in an EINVAL return from growfs:
# xfs_io -f -c "truncate 19998630180864" fsfile
# mkfs.xfs -f -bsize=4096 -dagsize=76288719b,size=3905982455b fsfile
# mount -o loop fsfile /mnt
# xfs_growfs /mnt
meta-data=/dev/loop0 isize=256 agcount=52,
agsize=76288719 blks
= sectsz=512 attr=2
data = bsize=4096 blocks=3905982455, imaxpct=5
= sunit=0 swidth=0 blks
naming =version 2 bsize=4096 ascii-ci=0
log =internal bsize=4096 blocks=32768, version=2
= sectsz=512 sunit=0 blks, lazy-count=0
realtime =none extsz=4096 blocks=0, rtextents=0
xfs_growfs: XFS_IOC_FSGROWFSDATA xfsctl failed: Invalid argument
Reported-by: richard.ems@cape-horn-eng.com
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Felix Blyakher <felixb@sgi.com>
Signed-off-by: Felix Blyakher <felixb@sgi.com>
1 parent 1f23920
| File | Mode | Size |
|---|---|---|
| .gitignore | -rw-r--r-- | 9 bytes |
| 00-INDEX | -rw-r--r-- | 649 bytes |
| Makefile | -rw-r--r-- | 213 bytes |
| balance | -rw-r--r-- | 4.9 KB |
| hugetlbpage.txt | -rw-r--r-- | 11.4 KB |
| locking | -rw-r--r-- | 6.0 KB |
| numa | -rw-r--r-- | 2.2 KB |
| numa_memory_policy.txt | -rw-r--r-- | 22.6 KB |
| overcommit-accounting | -rw-r--r-- | 2.2 KB |
| page_migration | -rw-r--r-- | 6.5 KB |
| pagemap.txt | -rw-r--r-- | 2.8 KB |
| slabinfo.c | -rw-r--r-- | 32.2 KB |
| slub.txt | -rw-r--r-- | 9.7 KB |
| unevictable-lru.txt | -rw-r--r-- | 32.2 KB |
Computing file changes ...
