Revision e700898fa075c69b3ae02b702ab57fb75e1a82ec authored by Mike Kravetz on 12 December 2022, 23:50:41 UTC, committed by Andrew Morton on 21 December 2022, 22:31:52 UTC
Commit bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas")
removed the pmd sharable checks in the vma lock helper routines. However,
it left the functional version of helper routines behind #ifdef
CONFIG_ARCH_WANT_HUGE_PMD_SHARE. Therefore, the vma lock is not being
used for sharable vmas on architectures that do not support pmd sharing.
On these architectures, a potential fault/truncation race is exposed that
could leave pages in a hugetlb file past i_size until the file is removed.
Move the functional vma lock helpers outside the ifdef, and remove the
non-functional stubs. Since the vma lock is not just for pmd sharing,
rename the routine __vma_shareable_flags_pmd.
Link: https://lkml.kernel.org/r/20221212235042.178355-1-mike.kravetz@oracle.com
Fixes: bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas")
Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: James Houghton <jthoughton@google.com>
Cc: Mina Almasry <almasrymina@google.com>
Cc: Muchun Song <songmuchun@bytedance.com>
Cc: Naoya Horiguchi <naoya.horiguchi@linux.dev>
Cc: Peter Xu <peterx@redhat.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 7ba594d
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 2.8 KB |
| Makefile | -rw-r--r-- | 823 bytes |
| README | -rw-r--r-- | 956 bytes |
| TODO | -rw-r--r-- | 96 bytes |
| bcma_private.h | -rw-r--r-- | 6.2 KB |
| core.c | -rw-r--r-- | 3.6 KB |
| driver_chipcommon.c | -rw-r--r-- | 10.3 KB |
| driver_chipcommon_b.c | -rw-r--r-- | 1.4 KB |
| driver_chipcommon_nflash.c | -rw-r--r-- | 1.7 KB |
| driver_chipcommon_pflash.c | -rw-r--r-- | 1.1 KB |
| driver_chipcommon_pmu.c | -rw-r--r-- | 19.4 KB |
| driver_chipcommon_sflash.c | -rw-r--r-- | 4.2 KB |
| driver_gmac_cmn.c | -rw-r--r-- | 265 bytes |
| driver_gpio.c | -rw-r--r-- | 5.7 KB |
| driver_mips.c | -rw-r--r-- | 9.5 KB |
| driver_pci.c | -rw-r--r-- | 8.2 KB |
| driver_pci_host.c | -rw-r--r-- | 17.4 KB |
| driver_pcie2.c | -rw-r--r-- | 5.6 KB |
| host_pci.c | -rw-r--r-- | 9.7 KB |
| host_soc.c | -rw-r--r-- | 5.5 KB |
| main.c | -rw-r--r-- | 16.0 KB |
| scan.c | -rw-r--r-- | 13.8 KB |
| scan.h | -rw-r--r-- | 1.7 KB |
| sprom.c | -rw-r--r-- | 20.9 KB |
Computing file changes ...
