Revision e700898fa075c69b3ae02b702ab57fb75e1a82ec authored by Mike Kravetz on 12 December 2022, 23:50:41 UTC, committed by Andrew Morton on 21 December 2022, 22:31:52 UTC
Commit bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas")
removed the pmd sharable checks in the vma lock helper routines.  However,
it left the functional version of helper routines behind #ifdef
CONFIG_ARCH_WANT_HUGE_PMD_SHARE.  Therefore, the vma lock is not being
used for sharable vmas on architectures that do not support pmd sharing. 
On these architectures, a potential fault/truncation race is exposed that
could leave pages in a hugetlb file past i_size until the file is removed.

Move the functional vma lock helpers outside the ifdef, and remove the
non-functional stubs.  Since the vma lock is not just for pmd sharing,
rename the routine __vma_shareable_flags_pmd.

Link: https://lkml.kernel.org/r/20221212235042.178355-1-mike.kravetz@oracle.com
Fixes: bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas")
Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: James Houghton <jthoughton@google.com>
Cc: Mina Almasry <almasrymina@google.com>
Cc: Muchun Song <songmuchun@bytedance.com>
Cc: Naoya Horiguchi <naoya.horiguchi@linux.dev>
Cc: Peter Xu <peterx@redhat.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 7ba594d
History
File Mode Size
Kconfig -rw-r--r-- 13.4 KB
Makefile -rw-r--r-- 1.7 KB
ath3k.c -rw-r--r-- 14.9 KB
bcm203x.c -rw-r--r-- 6.0 KB
bfusb.c -rw-r--r-- 14.9 KB
bluecard_cs.c -rw-r--r-- 19.7 KB
bpa10x.c -rw-r--r-- 8.8 KB
bt3c_cs.c -rw-r--r-- 14.7 KB
btbcm.c -rw-r--r-- 17.6 KB
btbcm.h -rw-r--r-- 2.5 KB
btintel.c -rw-r--r-- 68.8 KB
btintel.h -rw-r--r-- 7.2 KB
btmrvl_debugfs.c -rw-r--r-- 4.7 KB
btmrvl_drv.h -rw-r--r-- 4.2 KB
btmrvl_main.c -rw-r--r-- 17.5 KB
btmrvl_sdio.c -rw-r--r-- 40.8 KB
btmrvl_sdio.h -rw-r--r-- 2.6 KB
btmtk.c -rw-r--r-- 6.6 KB
btmtk.h -rw-r--r-- 2.9 KB
btmtksdio.c -rw-r--r-- 35.2 KB
btmtkuart.c -rw-r--r-- 23.9 KB
btqca.c -rw-r--r-- 17.9 KB
btqca.h -rw-r--r-- 4.7 KB
btqcomsmd.c -rw-r--r-- 4.5 KB
btrsi.c -rw-r--r-- 4.5 KB
btrtl.c -rw-r--r-- 24.4 KB
btrtl.h -rw-r--r-- 3.0 KB
btsdio.c -rw-r--r-- 7.8 KB
btusb.c -rw-r--r-- 118.8 KB
dtl1_cs.c -rw-r--r-- 12.4 KB
h4_recv.h -rw-r--r-- 2.9 KB
hci_ag6xx.c -rw-r--r-- 7.1 KB
hci_ath.c -rw-r--r-- 5.3 KB
hci_bcm.c -rw-r--r-- 38.2 KB
hci_bcm4377.c -rw-r--r-- 71.4 KB
hci_bcsp.c -rw-r--r-- 18.2 KB
hci_h4.c -rw-r--r-- 5.4 KB
hci_h5.c -rw-r--r-- 25.5 KB
hci_intel.c -rw-r--r-- 29.6 KB
hci_ldisc.c -rw-r--r-- 19.8 KB
hci_ll.c -rw-r--r-- 19.3 KB
hci_mrvl.c -rw-r--r-- 9.4 KB
hci_nokia.c -rw-r--r-- 18.0 KB
hci_qca.c -rw-r--r-- 60.6 KB
hci_serdev.c -rw-r--r-- 9.3 KB
hci_uart.h -rw-r--r-- 4.8 KB
hci_vhci.c -rw-r--r-- 12.2 KB
virtio_bt.c -rw-r--r-- 8.8 KB

back to top