Revision e700898fa075c69b3ae02b702ab57fb75e1a82ec authored by Mike Kravetz on 12 December 2022, 23:50:41 UTC, committed by Andrew Morton on 21 December 2022, 22:31:52 UTC
Commit bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas")
removed the pmd sharable checks in the vma lock helper routines.  However,
it left the functional version of helper routines behind #ifdef
CONFIG_ARCH_WANT_HUGE_PMD_SHARE.  Therefore, the vma lock is not being
used for sharable vmas on architectures that do not support pmd sharing. 
On these architectures, a potential fault/truncation race is exposed that
could leave pages in a hugetlb file past i_size until the file is removed.

Move the functional vma lock helpers outside the ifdef, and remove the
non-functional stubs.  Since the vma lock is not just for pmd sharing,
rename the routine __vma_shareable_flags_pmd.

Link: https://lkml.kernel.org/r/20221212235042.178355-1-mike.kravetz@oracle.com
Fixes: bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas")
Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: James Houghton <jthoughton@google.com>
Cc: Mina Almasry <almasrymina@google.com>
Cc: Muchun Song <songmuchun@bytedance.com>
Cc: Naoya Horiguchi <naoya.horiguchi@linux.dev>
Cc: Peter Xu <peterx@redhat.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 7ba594d
History
File Mode Size
fsl-mc
mhi
Kconfig -rw-r--r-- 8.2 KB
Makefile -rw-r--r-- 1.3 KB
arm-cci.c -rw-r--r-- 15.5 KB
arm-integrator-lm.c -rw-r--r-- 3.1 KB
brcmstb_gisb.c -rw-r--r-- 13.3 KB
bt1-apb.c -rw-r--r-- 9.2 KB
bt1-axi.c -rw-r--r-- 7.1 KB
da8xx-mstpri.c -rw-r--r-- 5.9 KB
hisi_lpc.c -rw-r--r-- 18.0 KB
imx-weim.c -rw-r--r-- 9.6 KB
intel-ixp4xx-eb.c -rw-r--r-- 11.1 KB
mips_cdmm.c -rw-r--r-- 19.4 KB
moxtet.c -rw-r--r-- 18.6 KB
mvebu-mbus.c -rw-r--r-- 35.9 KB
omap-ocp2scp.c -rw-r--r-- 3.1 KB
omap_l3_noc.c -rw-r--r-- 10.2 KB
omap_l3_noc.h -rw-r--r-- 11.9 KB
omap_l3_smx.c -rw-r--r-- 7.1 KB
omap_l3_smx.h -rw-r--r-- 7.3 KB
qcom-ebi2.c -rw-r--r-- 10.5 KB
qcom-ssc-block-bus.c -rw-r--r-- 10.4 KB
simple-pm-bus.c -rw-r--r-- 2.7 KB
sun50i-de2.c -rw-r--r-- 1.1 KB
sunxi-rsb.c -rw-r--r-- 20.8 KB
tegra-aconnect.c -rw-r--r-- 2.9 KB
tegra-gmi.c -rw-r--r-- 8.1 KB
ti-pwmss.c -rw-r--r-- 1.2 KB
ti-sysc.c -rw-r--r-- 86.5 KB
ts-nbus.c -rw-r--r-- 8.8 KB
uniphier-system-bus.c -rw-r--r-- 7.3 KB
vexpress-config.c -rw-r--r-- 10.0 KB

back to top