Revision e700898fa075c69b3ae02b702ab57fb75e1a82ec authored by Mike Kravetz on 12 December 2022, 23:50:41 UTC, committed by Andrew Morton on 21 December 2022, 22:31:52 UTC
Commit bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas") removed the pmd sharable checks in the vma lock helper routines. However, it left the functional version of helper routines behind #ifdef CONFIG_ARCH_WANT_HUGE_PMD_SHARE. Therefore, the vma lock is not being used for sharable vmas on architectures that do not support pmd sharing. On these architectures, a potential fault/truncation race is exposed that could leave pages in a hugetlb file past i_size until the file is removed. Move the functional vma lock helpers outside the ifdef, and remove the non-functional stubs. Since the vma lock is not just for pmd sharing, rename the routine __vma_shareable_flags_pmd. Link: https://lkml.kernel.org/r/20221212235042.178355-1-mike.kravetz@oracle.com Fixes: bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas") Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com> Reviewed-by: Miaohe Lin <linmiaohe@huawei.com> Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> Cc: David Hildenbrand <david@redhat.com> Cc: James Houghton <jthoughton@google.com> Cc: Mina Almasry <almasrymina@google.com> Cc: Muchun Song <songmuchun@bytedance.com> Cc: Naoya Horiguchi <naoya.horiguchi@linux.dev> Cc: Peter Xu <peterx@redhat.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 7ba594d
File | Mode | Size |
---|---|---|
governors | ||
Kconfig | -rw-r--r-- | 2.2 KB |
Kconfig.arm | -rw-r--r-- | 3.9 KB |
Kconfig.mips | -rw-r--r-- | 658 bytes |
Kconfig.powerpc | -rw-r--r-- | 520 bytes |
Kconfig.riscv | -rw-r--r-- | 438 bytes |
Makefile | -rw-r--r-- | 1.7 KB |
coupled.c | -rw-r--r-- | 25.2 KB |
cpuidle-arm.c | -rw-r--r-- | 4.0 KB |
cpuidle-at91.c | -rw-r--r-- | 1.5 KB |
cpuidle-big_little.c | -rw-r--r-- | 6.6 KB |
cpuidle-calxeda.c | -rw-r--r-- | 1.6 KB |
cpuidle-clps711x.c | -rw-r--r-- | 1.2 KB |
cpuidle-cps.c | -rw-r--r-- | 4.2 KB |
cpuidle-exynos.c | -rw-r--r-- | 3.3 KB |
cpuidle-haltpoll.c | -rw-r--r-- | 3.1 KB |
cpuidle-kirkwood.c | -rw-r--r-- | 2.0 KB |
cpuidle-mvebu-v7.c | -rw-r--r-- | 3.3 KB |
cpuidle-powernv.c | -rw-r--r-- | 10.3 KB |
cpuidle-psci-domain.c | -rw-r--r-- | 4.6 KB |
cpuidle-psci.c | -rw-r--r-- | 10.2 KB |
cpuidle-psci.h | -rw-r--r-- | 672 bytes |
cpuidle-pseries.c | -rw-r--r-- | 12.5 KB |
cpuidle-qcom-spm.c | -rw-r--r-- | 4.5 KB |
cpuidle-riscv-sbi.c | -rw-r--r-- | 14.2 KB |
cpuidle-tegra.c | -rw-r--r-- | 9.2 KB |
cpuidle-ux500.c | -rw-r--r-- | 3.0 KB |
cpuidle-zynq.c | -rw-r--r-- | 1.5 KB |
cpuidle.c | -rw-r--r-- | 18.6 KB |
cpuidle.h | -rw-r--r-- | 2.2 KB |
driver.c | -rw-r--r-- | 9.6 KB |
dt_idle_genpd.c | -rw-r--r-- | 3.6 KB |
dt_idle_genpd.h | -rw-r--r-- | 990 bytes |
dt_idle_states.c | -rw-r--r-- | 6.3 KB |
dt_idle_states.h | -rw-r--r-- | 216 bytes |
governor.c | -rw-r--r-- | 2.7 KB |
poll_state.c | -rw-r--r-- | 1.3 KB |
sysfs.c | -rw-r--r-- | 19.0 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...