Revision e700898fa075c69b3ae02b702ab57fb75e1a82ec authored by Mike Kravetz on 12 December 2022, 23:50:41 UTC, committed by Andrew Morton on 21 December 2022, 22:31:52 UTC
Commit bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas") removed the pmd sharable checks in the vma lock helper routines. However, it left the functional version of helper routines behind #ifdef CONFIG_ARCH_WANT_HUGE_PMD_SHARE. Therefore, the vma lock is not being used for sharable vmas on architectures that do not support pmd sharing. On these architectures, a potential fault/truncation race is exposed that could leave pages in a hugetlb file past i_size until the file is removed. Move the functional vma lock helpers outside the ifdef, and remove the non-functional stubs. Since the vma lock is not just for pmd sharing, rename the routine __vma_shareable_flags_pmd. Link: https://lkml.kernel.org/r/20221212235042.178355-1-mike.kravetz@oracle.com Fixes: bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas") Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com> Reviewed-by: Miaohe Lin <linmiaohe@huawei.com> Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> Cc: David Hildenbrand <david@redhat.com> Cc: James Houghton <jthoughton@google.com> Cc: Mina Almasry <almasrymina@google.com> Cc: Muchun Song <songmuchun@bytedance.com> Cc: Naoya Horiguchi <naoya.horiguchi@linux.dev> Cc: Peter Xu <peterx@redhat.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 7ba594d
File | Mode | Size |
---|---|---|
arm_ffa | ||
arm_scmi | ||
broadcom | ||
cirrus | ||
efi | ||
imx | ||
meson | ||
psci | ||
smccc | ||
tegra | ||
xilinx | ||
Kconfig | -rw-r--r-- | 11.6 KB |
Makefile | -rw-r--r-- | 1.3 KB |
arm_scpi.c | -rw-r--r-- | 26.4 KB |
arm_sdei.c | -rw-r--r-- | 23.1 KB |
dmi-id.c | -rw-r--r-- | 7.2 KB |
dmi-sysfs.c | -rw-r--r-- | 17.0 KB |
dmi_scan.c | -rw-r--r-- | 29.2 KB |
edd.c | -rw-r--r-- | 19.3 KB |
iscsi_ibft.c | -rw-r--r-- | 20.9 KB |
iscsi_ibft_find.c | -rw-r--r-- | 2.1 KB |
memmap.c | -rw-r--r-- | 11.6 KB |
mtk-adsp-ipc.c | -rw-r--r-- | 3.4 KB |
pcdp.c | -rw-r--r-- | 3.2 KB |
pcdp.h | -rw-r--r-- | 2.5 KB |
qcom_scm-legacy.c | -rw-r--r-- | 6.9 KB |
qcom_scm-smc.c | -rw-r--r-- | 3.7 KB |
qcom_scm.c | -rw-r--r-- | 37.1 KB |
qcom_scm.h | -rw-r--r-- | 4.3 KB |
qemu_fw_cfg.c | -rw-r--r-- | 25.1 KB |
raspberrypi.c | -rw-r--r-- | 10.0 KB |
scpi_pm_domain.c | -rw-r--r-- | 3.8 KB |
stratix10-rsu.c | -rw-r--r-- | 19.5 KB |
stratix10-svc.c | -rw-r--r-- | 35.7 KB |
sysfb.c | -rw-r--r-- | 3.5 KB |
sysfb_simplefb.c | -rw-r--r-- | 3.6 KB |
ti_sci.c | -rw-r--r-- | 99.4 KB |
ti_sci.h | -rw-r--r-- | 53.1 KB |
trusted_foundations.c | -rw-r--r-- | 4.0 KB |
turris-mox-rwtm.c | -rw-r--r-- | 14.0 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...