Revision e700898fa075c69b3ae02b702ab57fb75e1a82ec authored by Mike Kravetz on 12 December 2022, 23:50:41 UTC, committed by Andrew Morton on 21 December 2022, 22:31:52 UTC
Commit bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas") removed the pmd sharable checks in the vma lock helper routines. However, it left the functional version of helper routines behind #ifdef CONFIG_ARCH_WANT_HUGE_PMD_SHARE. Therefore, the vma lock is not being used for sharable vmas on architectures that do not support pmd sharing. On these architectures, a potential fault/truncation race is exposed that could leave pages in a hugetlb file past i_size until the file is removed. Move the functional vma lock helpers outside the ifdef, and remove the non-functional stubs. Since the vma lock is not just for pmd sharing, rename the routine __vma_shareable_flags_pmd. Link: https://lkml.kernel.org/r/20221212235042.178355-1-mike.kravetz@oracle.com Fixes: bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas") Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com> Reviewed-by: Miaohe Lin <linmiaohe@huawei.com> Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> Cc: David Hildenbrand <david@redhat.com> Cc: James Houghton <jthoughton@google.com> Cc: Mina Almasry <almasrymina@google.com> Cc: Muchun Song <songmuchun@bytedance.com> Cc: Naoya Horiguchi <naoya.horiguchi@linux.dev> Cc: Peter Xu <peterx@redhat.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 7ba594d
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 10.2 KB |
Makefile | -rw-r--r-- | 1.5 KB |
apple-mailbox.c | -rw-r--r-- | 12.3 KB |
arm_mhu.c | -rw-r--r-- | 3.8 KB |
arm_mhu_db.c | -rw-r--r-- | 8.3 KB |
arm_mhuv2.c | -rw-r--r-- | 29.4 KB |
armada-37xx-rwtm-mailbox.c | -rw-r--r-- | 5.1 KB |
bcm-flexrm-mailbox.c | -rw-r--r-- | 44.7 KB |
bcm-pdc-mailbox.c | -rw-r--r-- | 47.7 KB |
bcm2835-mailbox.c | -rw-r--r-- | 5.3 KB |
hi3660-mailbox.c | -rw-r--r-- | 7.4 KB |
hi6220-mailbox.c | -rw-r--r-- | 8.9 KB |
imx-mailbox.c | -rw-r--r-- | 26.5 KB |
mailbox-altera.c | -rw-r--r-- | 8.4 KB |
mailbox-mpfs.c | -rw-r--r-- | 6.4 KB |
mailbox-sti.c | -rw-r--r-- | 12.9 KB |
mailbox-test.c | -rw-r--r-- | 10.8 KB |
mailbox-xgene-slimpro.c | -rw-r--r-- | 6.4 KB |
mailbox.c | -rw-r--r-- | 16.2 KB |
mailbox.h | -rw-r--r-- | 326 bytes |
mtk-adsp-mailbox.c | -rw-r--r-- | 4.6 KB |
mtk-cmdq-mailbox.c | -rw-r--r-- | 18.1 KB |
omap-mailbox.c | -rw-r--r-- | 21.6 KB |
pcc.c | -rw-r--r-- | 20.0 KB |
pl320-ipc.c | -rw-r--r-- | 4.6 KB |
platform_mhu.c | -rw-r--r-- | 4.4 KB |
qcom-apcs-ipc-mailbox.c | -rw-r--r-- | 5.5 KB |
qcom-ipcc.c | -rw-r--r-- | 9.0 KB |
rockchip-mailbox.c | -rw-r--r-- | 6.3 KB |
sprd-mailbox.c | -rw-r--r-- | 11.5 KB |
stm32-ipcc.c | -rw-r--r-- | 9.6 KB |
sun6i-msgbox.c | -rw-r--r-- | 8.6 KB |
tegra-hsp.c | -rw-r--r-- | 23.1 KB |
ti-msgmgr.c | -rw-r--r-- | 26.0 KB |
zynqmp-ipi-mailbox.c | -rw-r--r-- | 19.2 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...