Revision e700898fa075c69b3ae02b702ab57fb75e1a82ec authored by Mike Kravetz on 12 December 2022, 23:50:41 UTC, committed by Andrew Morton on 21 December 2022, 22:31:52 UTC
Commit bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas")
removed the pmd sharable checks in the vma lock helper routines.  However,
it left the functional version of helper routines behind #ifdef
CONFIG_ARCH_WANT_HUGE_PMD_SHARE.  Therefore, the vma lock is not being
used for sharable vmas on architectures that do not support pmd sharing. 
On these architectures, a potential fault/truncation race is exposed that
could leave pages in a hugetlb file past i_size until the file is removed.

Move the functional vma lock helpers outside the ifdef, and remove the
non-functional stubs.  Since the vma lock is not just for pmd sharing,
rename the routine __vma_shareable_flags_pmd.

Link: https://lkml.kernel.org/r/20221212235042.178355-1-mike.kravetz@oracle.com
Fixes: bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas")
Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: James Houghton <jthoughton@google.com>
Cc: Mina Almasry <almasrymina@google.com>
Cc: Muchun Song <songmuchun@bytedance.com>
Cc: Naoya Horiguchi <naoya.horiguchi@linux.dev>
Cc: Peter Xu <peterx@redhat.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 7ba594d
History
File Mode Size
altera-stapl
bcm-vk
c2port
cardreader
cb710
cxl
echo
eeprom
genwqe
habanalabs
ibmasm
lis3lv02d
lkdtm
mchp_pci1xxxx
mei
ocxl
pvpanic
sgi-gru
sgi-xp
ti-st
uacce
vmw_vmci
Kconfig -rw-r--r-- 17.8 KB
Makefile -rw-r--r-- 2.4 KB
ad525x_dpot-i2c.c -rw-r--r-- 2.6 KB
ad525x_dpot-spi.c -rw-r--r-- 2.8 KB
ad525x_dpot.c -rw-r--r-- 20.2 KB
ad525x_dpot.h -rw-r--r-- 7.9 KB
apds9802als.c -rw-r--r-- 7.0 KB
apds990x.c -rw-r--r-- 33.2 KB
atmel-ssc.c -rw-r--r-- 5.9 KB
bh1770glc.c -rw-r--r-- 36.7 KB
cs5535-mfgpt.c -rw-r--r-- 10.0 KB
ds1682.c -rw-r--r-- 6.9 KB
dummy-irq.c -rw-r--r-- 1.4 KB
dw-xdata-pcie.c -rw-r--r-- 9.7 KB
enclosure.c -rw-r--r-- 18.3 KB
fastrpc.c -rw-r--r-- 57.6 KB
gehc-achc.c -rw-r--r-- 12.6 KB
hi6421v600-irq.c -rw-r--r-- 7.5 KB
hisi_hikey_usb.c -rw-r--r-- 7.3 KB
hmc6352.c -rw-r--r-- 3.4 KB
hpilo.c -rw-r--r-- 22.0 KB
hpilo.h -rw-r--r-- 5.5 KB
ibmvmc.c -rw-r--r-- 60.8 KB
ibmvmc.h -rw-r--r-- 5.2 KB
ics932s401.c -rw-r--r-- 12.5 KB
isl29003.c -rw-r--r-- 10.9 KB
isl29020.c -rw-r--r-- 4.9 KB
kgdbts.c -rw-r--r-- 30.6 KB
lattice-ecp3-config.c -rw-r--r-- 5.6 KB
open-dice.c -rw-r--r-- 5.4 KB
pch_phub.c -rw-r--r-- 27.0 KB
pci_endpoint_test.c -rw-r--r-- 24.8 KB
phantom.c -rw-r--r-- 13.0 KB
qcom-coincell.c -rw-r--r-- 3.6 KB
smpro-errmon.c -rw-r--r-- 13.8 KB
smpro-misc.c -rw-r--r-- 3.2 KB
sram-exec.c -rw-r--r-- 3.3 KB
sram.c -rw-r--r-- 11.4 KB
sram.h -rw-r--r-- 1.2 KB
tifm_7xx1.c -rw-r--r-- 10.7 KB
tifm_core.c -rw-r--r-- 8.1 KB
tsl2550.c -rw-r--r-- 9.9 KB
vcpu_stall_detector.c -rw-r--r-- 6.0 KB
vmw_balloon.c -rw-r--r-- 53.4 KB
xilinx_sdfec.c -rw-r--r-- 38.0 KB

back to top