Revision e700898fa075c69b3ae02b702ab57fb75e1a82ec authored by Mike Kravetz on 12 December 2022, 23:50:41 UTC, committed by Andrew Morton on 21 December 2022, 22:31:52 UTC
Commit bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas")
removed the pmd sharable checks in the vma lock helper routines.  However,
it left the functional version of helper routines behind #ifdef
CONFIG_ARCH_WANT_HUGE_PMD_SHARE.  Therefore, the vma lock is not being
used for sharable vmas on architectures that do not support pmd sharing. 
On these architectures, a potential fault/truncation race is exposed that
could leave pages in a hugetlb file past i_size until the file is removed.

Move the functional vma lock helpers outside the ifdef, and remove the
non-functional stubs.  Since the vma lock is not just for pmd sharing,
rename the routine __vma_shareable_flags_pmd.

Link: https://lkml.kernel.org/r/20221212235042.178355-1-mike.kravetz@oracle.com
Fixes: bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas")
Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: James Houghton <jthoughton@google.com>
Cc: Mina Almasry <almasrymina@google.com>
Cc: Muchun Song <songmuchun@bytedance.com>
Cc: Naoya Horiguchi <naoya.horiguchi@linux.dev>
Cc: Peter Xu <peterx@redhat.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 7ba594d
History
File Mode Size
Kconfig -rw-r--r-- 291 bytes
Makefile -rw-r--r-- 198 bytes
backend.h -rw-r--r-- 1.8 KB
common.h -rw-r--r-- 9.0 KB
cxl_hw.c -rw-r--r-- 4.3 KB
lunmgt.c -rw-r--r-- 7.2 KB
main.c -rw-r--r-- 105.9 KB
main.h -rw-r--r-- 3.2 KB
ocxl_hw.c -rw-r--r-- 33.6 KB
ocxl_hw.h -rw-r--r-- 2.3 KB
sislite.h -rw-r--r-- 19.1 KB
superpipe.c -rw-r--r-- 60.7 KB
superpipe.h -rw-r--r-- 4.5 KB
vlun.c -rw-r--r-- 36.1 KB
vlun.h -rw-r--r-- 2.6 KB

back to top