Skip to main content

Browse the archive

Revision e700898fa075c69b3ae02b702ab57fb75e1a82ec authored by Mike Kravetz on 12 December 2022, 23:50:41 UTC, committed by Andrew Morton on 21 December 2022, 22:31:52 UTC 
hugetlb: really allocate vma lock for all sharable vmas
 
Commit bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas")
removed the pmd sharable checks in the vma lock helper routines.  However,
it left the functional version of helper routines behind #ifdef
CONFIG_ARCH_WANT_HUGE_PMD_SHARE.  Therefore, the vma lock is not being
used for sharable vmas on architectures that do not support pmd sharing. 
On these architectures, a potential fault/truncation race is exposed that
could leave pages in a hugetlb file past i_size until the file is removed.

Move the functional vma lock helpers outside the ifdef, and remove the
non-functional stubs.  Since the vma lock is not just for pmd sharing,
rename the routine __vma_shareable_flags_pmd.

Link: https://lkml.kernel.org/r/20221212235042.178355-1-mike.kravetz@oracle.com
Fixes: bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas")
Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: James Houghton <jthoughton@google.com>
Cc: Mina Almasry <almasrymina@google.com>
Cc: Muchun Song <songmuchun@bytedance.com>
Cc: Naoya Horiguchi <naoya.horiguchi@linux.dev>
Cc: Peter Xu <peterx@redhat.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 7ba594d
Raw File
backend.h 
/* SPDX-License-Identifier: GPL-2.0-or-later */
/*
 * CXL Flash Device Driver
 *
 * Written by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>, IBM Corporation
 *             Uma Krishnan <ukrishn@linux.vnet.ibm.com>, IBM Corporation
 *
 * Copyright (C) 2018 IBM Corporation
 */

#ifndef _CXLFLASH_BACKEND_H
#define _CXLFLASH_BACKEND_H

extern const struct cxlflash_backend_ops cxlflash_cxl_ops;
extern const struct cxlflash_backend_ops cxlflash_ocxl_ops;

struct cxlflash_backend_ops {
	struct module *module;
	void __iomem * (*psa_map)(void *ctx_cookie);
	void (*psa_unmap)(void __iomem *addr);
	int (*process_element)(void *ctx_cookie);
	int (*map_afu_irq)(void *ctx_cookie, int num, irq_handler_t handler,
			   void *cookie, char *name);
	void (*unmap_afu_irq)(void *ctx_cookie, int num, void *cookie);
	u64 (*get_irq_objhndl)(void *ctx_cookie, int irq);
	int (*start_context)(void *ctx_cookie);
	int (*stop_context)(void *ctx_cookie);
	int (*afu_reset)(void *ctx_cookie);
	void (*set_master)(void *ctx_cookie);
	void * (*get_context)(struct pci_dev *dev, void *afu_cookie);
	void * (*dev_context_init)(struct pci_dev *dev, void *afu_cookie);
	int (*release_context)(void *ctx_cookie);
	void (*perst_reloads_same_image)(void *afu_cookie, bool image);
	ssize_t (*read_adapter_vpd)(struct pci_dev *dev, void *buf,
				    size_t count);
	int (*allocate_afu_irqs)(void *ctx_cookie, int num);
	void (*free_afu_irqs)(void *ctx_cookie);
	void * (*create_afu)(struct pci_dev *dev);
	void (*destroy_afu)(void *afu_cookie);
	struct file * (*get_fd)(void *ctx_cookie, struct file_operations *fops,
				int *fd);
	void * (*fops_get_context)(struct file *file);
	int (*start_work)(void *ctx_cookie, u64 irqs);
	int (*fd_mmap)(struct file *file, struct vm_area_struct *vm);
	int (*fd_release)(struct inode *inode, struct file *file);
};

#endif /* _CXLFLASH_BACKEND_H */
back to top