Revision e700898fa075c69b3ae02b702ab57fb75e1a82ec authored by Mike Kravetz on 12 December 2022, 23:50:41 UTC, committed by Andrew Morton on 21 December 2022, 22:31:52 UTC
Commit bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas")
removed the pmd sharable checks in the vma lock helper routines.  However,
it left the functional version of helper routines behind #ifdef
CONFIG_ARCH_WANT_HUGE_PMD_SHARE.  Therefore, the vma lock is not being
used for sharable vmas on architectures that do not support pmd sharing. 
On these architectures, a potential fault/truncation race is exposed that
could leave pages in a hugetlb file past i_size until the file is removed.

Move the functional vma lock helpers outside the ifdef, and remove the
non-functional stubs.  Since the vma lock is not just for pmd sharing,
rename the routine __vma_shareable_flags_pmd.

Link: https://lkml.kernel.org/r/20221212235042.178355-1-mike.kravetz@oracle.com
Fixes: bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas")
Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: James Houghton <jthoughton@google.com>
Cc: Mina Almasry <almasrymina@google.com>
Cc: Muchun Song <songmuchun@bytedance.com>
Cc: Naoya Horiguchi <naoya.horiguchi@linux.dev>
Cc: Peter Xu <peterx@redhat.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 7ba594d
History
File Mode Size
Kconfig -rw-r--r-- 327 bytes
Makefile -rw-r--r-- 215 bytes
ql4_83xx.c -rw-r--r-- 43.3 KB
ql4_83xx.h -rw-r--r-- 9.5 KB
ql4_attr.c -rw-r--r-- 9.9 KB
ql4_bsg.c -rw-r--r-- 24.0 KB
ql4_bsg.h -rw-r--r-- 950 bytes
ql4_dbg.c -rw-r--r-- 6.3 KB
ql4_dbg.h -rw-r--r-- 1.6 KB
ql4_def.h -rw-r--r-- 27.9 KB
ql4_fw.h -rw-r--r-- 44.7 KB
ql4_glbl.h -rw-r--r-- 14.5 KB
ql4_init.c -rw-r--r-- 35.2 KB
ql4_inline.h -rw-r--r-- 2.3 KB
ql4_iocb.c -rw-r--r-- 14.0 KB
ql4_isr.c -rw-r--r-- 44.7 KB
ql4_mbx.c -rw-r--r-- 71.3 KB
ql4_nvram.c -rw-r--r-- 6.1 KB
ql4_nvram.h -rw-r--r-- 6.8 KB
ql4_nx.c -rw-r--r-- 114.5 KB
ql4_nx.h -rw-r--r-- 35.5 KB
ql4_os.c -rw-r--r-- 283.2 KB
ql4_version.h -rw-r--r-- 170 bytes

back to top