Revision e700898fa075c69b3ae02b702ab57fb75e1a82ec authored by Mike Kravetz on 12 December 2022, 23:50:41 UTC, committed by Andrew Morton on 21 December 2022, 22:31:52 UTC
Commit bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas") removed the pmd sharable checks in the vma lock helper routines. However, it left the functional version of helper routines behind #ifdef CONFIG_ARCH_WANT_HUGE_PMD_SHARE. Therefore, the vma lock is not being used for sharable vmas on architectures that do not support pmd sharing. On these architectures, a potential fault/truncation race is exposed that could leave pages in a hugetlb file past i_size until the file is removed. Move the functional vma lock helpers outside the ifdef, and remove the non-functional stubs. Since the vma lock is not just for pmd sharing, rename the routine __vma_shareable_flags_pmd. Link: https://lkml.kernel.org/r/20221212235042.178355-1-mike.kravetz@oracle.com Fixes: bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas") Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com> Reviewed-by: Miaohe Lin <linmiaohe@huawei.com> Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> Cc: David Hildenbrand <david@redhat.com> Cc: James Houghton <jthoughton@google.com> Cc: Mina Almasry <almasrymina@google.com> Cc: Muchun Song <songmuchun@bytedance.com> Cc: Naoya Horiguchi <naoya.horiguchi@linux.dev> Cc: Peter Xu <peterx@redhat.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 7ba594d
File | Mode | Size |
---|---|---|
Makefile | -rw-r--r-- | 315 bytes |
cq_desc.h | -rw-r--r-- | 1.8 KB |
cq_enet_desc.h | -rw-r--r-- | 578 bytes |
snic.h | -rw-r--r-- | 10.7 KB |
snic_attrs.c | -rw-r--r-- | 1.8 KB |
snic_ctl.c | -rw-r--r-- | 6.4 KB |
snic_debugfs.c | -rw-r--r-- | 12.5 KB |
snic_disc.c | -rw-r--r-- | 12.8 KB |
snic_disc.h | -rw-r--r-- | 2.3 KB |
snic_fwint.h | -rw-r--r-- | 13.3 KB |
snic_io.c | -rw-r--r-- | 13.2 KB |
snic_io.h | -rw-r--r-- | 2.8 KB |
snic_isr.c | -rw-r--r-- | 4.4 KB |
snic_main.c | -rw-r--r-- | 22.7 KB |
snic_res.c | -rw-r--r-- | 6.6 KB |
snic_res.h | -rw-r--r-- | 2.4 KB |
snic_scsi.c | -rw-r--r-- | 65.8 KB |
snic_stats.h | -rw-r--r-- | 3.7 KB |
snic_trc.c | -rw-r--r-- | 3.1 KB |
snic_trc.h | -rw-r--r-- | 2.6 KB |
vnic_cq.c | -rw-r--r-- | 1.9 KB |
vnic_cq.h | -rw-r--r-- | 2.5 KB |
vnic_cq_fw.h | -rw-r--r-- | 1.0 KB |
vnic_dev.c | -rw-r--r-- | 16.2 KB |
vnic_dev.h | -rw-r--r-- | 3.1 KB |
vnic_devcmd.h | -rw-r--r-- | 7.3 KB |
vnic_intr.c | -rw-r--r-- | 1.1 KB |
vnic_intr.h | -rw-r--r-- | 2.1 KB |
vnic_resource.h | -rw-r--r-- | 1.4 KB |
vnic_snic.h | -rw-r--r-- | 1.0 KB |
vnic_stats.h | -rw-r--r-- | 1.1 KB |
vnic_wq.c | -rw-r--r-- | 4.8 KB |
vnic_wq.h | -rw-r--r-- | 4.1 KB |
wq_enet_desc.h | -rw-r--r-- | 3.1 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...