Revision e700898fa075c69b3ae02b702ab57fb75e1a82ec authored by Mike Kravetz on 12 December 2022, 23:50:41 UTC, committed by Andrew Morton on 21 December 2022, 22:31:52 UTC
Commit bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas")
removed the pmd sharable checks in the vma lock helper routines.  However,
it left the functional version of helper routines behind #ifdef
CONFIG_ARCH_WANT_HUGE_PMD_SHARE.  Therefore, the vma lock is not being
used for sharable vmas on architectures that do not support pmd sharing. 
On these architectures, a potential fault/truncation race is exposed that
could leave pages in a hugetlb file past i_size until the file is removed.

Move the functional vma lock helpers outside the ifdef, and remove the
non-functional stubs.  Since the vma lock is not just for pmd sharing,
rename the routine __vma_shareable_flags_pmd.

Link: https://lkml.kernel.org/r/20221212235042.178355-1-mike.kravetz@oracle.com
Fixes: bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas")
Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: James Houghton <jthoughton@google.com>
Cc: Mina Almasry <almasrymina@google.com>
Cc: Muchun Song <songmuchun@bytedance.com>
Cc: Naoya Horiguchi <naoya.horiguchi@linux.dev>
Cc: Peter Xu <peterx@redhat.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 7ba594d
History
File Mode Size
sisusbvga
Kconfig -rw-r--r-- 10.7 KB
Makefile -rw-r--r-- 1.4 KB
adutux.c -rw-r--r-- 21.3 KB
apple-mfi-fastcharge.c -rw-r--r-- 5.7 KB
appledisplay.c -rw-r--r-- 8.7 KB
brcmstb-usb-pinmap.c -rw-r--r-- 8.3 KB
chaoskey.c -rw-r--r-- 13.3 KB
cypress_cy7c63.c -rw-r--r-- 6.3 KB
cytherm.c -rw-r--r-- 8.4 KB
ehset.c -rw-r--r-- 5.6 KB
emi26.c -rw-r--r-- 7.5 KB
emi62.c -rw-r--r-- 7.7 KB
ezusb.c -rw-r--r-- 4.1 KB
ftdi-elan.c -rw-r--r-- 77.7 KB
idmouse.c -rw-r--r-- 10.6 KB
iowarrior.c -rw-r--r-- 25.7 KB
isight_firmware.c -rw-r--r-- 3.1 KB
ldusb.c -rw-r--r-- 24.3 KB
legousbtower.c -rw-r--r-- 24.2 KB
lvstest.c -rw-r--r-- 11.7 KB
onboard_usb_hub.c -rw-r--r-- 10.5 KB
onboard_usb_hub.h -rw-r--r-- 1.2 KB
onboard_usb_hub_pdevs.c -rw-r--r-- 4.4 KB
qcom_eud.c -rw-r--r-- 5.8 KB
trancevibrator.c -rw-r--r-- 2.9 KB
usb251xb.c -rw-r--r-- 21.9 KB
usb3503.c -rw-r--r-- 9.9 KB
usb4604.c -rw-r--r-- 3.4 KB
usb_u132.h -rw-r--r-- 5.0 KB
usblcd.c -rw-r--r-- 11.2 KB
usbsevseg.c -rw-r--r-- 9.4 KB
usbtest.c -rw-r--r-- 78.4 KB
uss720.c -rw-r--r-- 21.8 KB
yurex.c -rw-r--r-- 12.7 KB

back to top