Revision e700898fa075c69b3ae02b702ab57fb75e1a82ec authored by Mike Kravetz on 12 December 2022, 23:50:41 UTC, committed by Andrew Morton on 21 December 2022, 22:31:52 UTC
Commit bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas")
removed the pmd sharable checks in the vma lock helper routines.  However,
it left the functional version of helper routines behind #ifdef
CONFIG_ARCH_WANT_HUGE_PMD_SHARE.  Therefore, the vma lock is not being
used for sharable vmas on architectures that do not support pmd sharing. 
On these architectures, a potential fault/truncation race is exposed that
could leave pages in a hugetlb file past i_size until the file is removed.

Move the functional vma lock helpers outside the ifdef, and remove the
non-functional stubs.  Since the vma lock is not just for pmd sharing,
rename the routine __vma_shareable_flags_pmd.

Link: https://lkml.kernel.org/r/20221212235042.178355-1-mike.kravetz@oracle.com
Fixes: bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas")
Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: James Houghton <jthoughton@google.com>
Cc: Mina Almasry <almasrymina@google.com>
Cc: Muchun Song <songmuchun@bytedance.com>
Cc: Naoya Horiguchi <naoya.horiguchi@linux.dev>
Cc: Peter Xu <peterx@redhat.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 7ba594d
History
File Mode Size
Kconfig -rw-r--r-- 1.6 KB
Makefile -rw-r--r-- 662 bytes
mtu3.h -rw-r--r-- 12.5 KB
mtu3_core.c -rw-r--r-- 26.8 KB
mtu3_debug.h -rw-r--r-- 1.3 KB
mtu3_debugfs.c -rw-r--r-- 13.5 KB
mtu3_dr.c -rw-r--r-- 8.3 KB
mtu3_dr.h -rw-r--r-- 2.8 KB
mtu3_gadget.c -rw-r--r-- 17.8 KB
mtu3_gadget_ep0.c -rw-r--r-- 21.1 KB
mtu3_host.c -rw-r--r-- 8.3 KB
mtu3_hw_regs.h -rw-r--r-- 17.2 KB
mtu3_plat.c -rw-r--r-- 13.8 KB
mtu3_qmu.c -rw-r--r-- 16.8 KB
mtu3_qmu.h -rw-r--r-- 934 bytes
mtu3_trace.c -rw-r--r-- 450 bytes
mtu3_trace.h -rw-r--r-- 6.8 KB

back to top