Revision e700898fa075c69b3ae02b702ab57fb75e1a82ec authored by Mike Kravetz on 12 December 2022, 23:50:41 UTC, committed by Andrew Morton on 21 December 2022, 22:31:52 UTC
Commit bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas")
removed the pmd sharable checks in the vma lock helper routines.  However,
it left the functional version of helper routines behind #ifdef
CONFIG_ARCH_WANT_HUGE_PMD_SHARE.  Therefore, the vma lock is not being
used for sharable vmas on architectures that do not support pmd sharing. 
On these architectures, a potential fault/truncation race is exposed that
could leave pages in a hugetlb file past i_size until the file is removed.

Move the functional vma lock helpers outside the ifdef, and remove the
non-functional stubs.  Since the vma lock is not just for pmd sharing,
rename the routine __vma_shareable_flags_pmd.

Link: https://lkml.kernel.org/r/20221212235042.178355-1-mike.kravetz@oracle.com
Fixes: bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas")
Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: James Houghton <jthoughton@google.com>
Cc: Mina Almasry <almasrymina@google.com>
Cc: Muchun Song <songmuchun@bytedance.com>
Cc: Naoya Horiguchi <naoya.horiguchi@linux.dev>
Cc: Peter Xu <peterx@redhat.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 7ba594d
History
File Mode Size
Kconfig -rw-r--r-- 4.4 KB
Makefile -rw-r--r-- 1.3 KB
cppi_dma.h -rw-r--r-- 3.4 KB
da8xx.c -rw-r--r-- 17.1 KB
jz4740.c -rw-r--r-- 8.5 KB
mediatek.c -rw-r--r-- 13.3 KB
mpfs.c -rw-r--r-- 6.6 KB
musb_core.c -rw-r--r-- 78.5 KB
musb_core.h -rw-r--r-- 15.7 KB
musb_cppi41.c -rw-r--r-- 21.4 KB
musb_debug.h -rw-r--r-- 942 bytes
musb_debugfs.c -rw-r--r-- 8.7 KB
musb_dma.h -rw-r--r-- 6.6 KB
musb_dsps.c -rw-r--r-- 26.1 KB
musb_gadget.c -rw-r--r-- 53.0 KB
musb_gadget.h -rw-r--r-- 3.0 KB
musb_gadget_ep0.c -rw-r--r-- 25.6 KB
musb_host.c -rw-r--r-- 73.7 KB
musb_host.h -rw-r--r-- 3.7 KB
musb_io.h -rw-r--r-- 1.9 KB
musb_regs.h -rw-r--r-- 10.6 KB
musb_trace.c -rw-r--r-- 457 bytes
musb_trace.h -rw-r--r-- 9.4 KB
musb_virthub.c -rw-r--r-- 10.9 KB
musbhsdma.c -rw-r--r-- 12.1 KB
omap2430.c -rw-r--r-- 14.9 KB
omap2430.h -rw-r--r-- 1.1 KB
sunxi.c -rw-r--r-- 22.9 KB
tusb6010.c -rw-r--r-- 34.2 KB
tusb6010.h -rw-r--r-- 8.9 KB
tusb6010_omap.c -rw-r--r-- 16.3 KB
ux500.c -rw-r--r-- 8.3 KB
ux500_dma.c -rw-r--r-- 11.1 KB

back to top