Skip to main content

Browse the archive

https://github.com/torvalds/linux
05 April 2024, 19:05:47 UTC
Revision e72022e13d659bece2fc9cb2dd97afa67047dbca authored by Stephen Tweedie on 18 May 2005, 15:22:31 UTC, committed by Linus Torvalds on 18 May 2005, 16:10:02 UTC 
[PATCH] Fix filp being passed through raw ioctl handler
 
Don't pass meaningless file handles to block device ioctls.

The recent raw IO ioctl-passthrough fix started passing the raw file
handle into the block device ioctl handler.  That's unlikely to be
useful, as the file handle is actually open on a character-mode raw
device, not a block device, so dereferencing it is not going to yield
useful results to a block device ioctl handler.

Previously we just passed NULL; also not a value that can usefully
be dereferenced, but at least if it does happen, we'll oops instead of
silently pretending that the file is a block device, so NULL is the more
defensive option here.  This patch reverts to that behaviour.

Noticed by Al Viro.

Signed-off-by: Stephen Tweedie <sct@redhat.com>
Acked-by: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
1 parent d1ded20
History
Tip revision: e72022e13d659bece2fc9cb2dd97afa67047dbca authored by Stephen Tweedie on 18 May 2005, 15:22:31 UTC
[PATCH] Fix filp being passed through raw ioctl handler
Tip revision: e72022e
File Mode Size
Documentation
arch
crypto
drivers
fs
include
init
ipc
kernel
lib
mm
net
scripts
security
sound
usr
COPYING -rw-r--r-- 18.3 KB
CREDITS -rw-r--r-- 87.1 KB
MAINTAINERS -rw-r--r-- 55.8 KB
Makefile -rw-r--r-- 43.2 KB
README -rw-r--r-- 13.6 KB
REPORTING-BUGS -rw-r--r-- 2.9 KB

README

back to top