Revision e72022e13d659bece2fc9cb2dd97afa67047dbca authored by Stephen Tweedie on 18 May 2005, 15:22:31 UTC, committed by Linus Torvalds on 18 May 2005, 16:10:02 UTC
Don't pass meaningless file handles to block device ioctls.

The recent raw IO ioctl-passthrough fix started passing the raw file
handle into the block device ioctl handler.  That's unlikely to be
useful, as the file handle is actually open on a character-mode raw
device, not a block device, so dereferencing it is not going to yield
useful results to a block device ioctl handler.

Previously we just passed NULL; also not a value that can usefully
be dereferenced, but at least if it does happen, we'll oops instead of
silently pretending that the file is a block device, so NULL is the more
defensive option here.  This patch reverts to that behaviour.

Noticed by Al Viro.

Signed-off-by: Stephen Tweedie <sct@redhat.com>
Acked-by: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
1 parent d1ded20
History
File Mode Size
Makefile -rw-r--r-- 237 bytes
compat.c -rw-r--r-- 17.3 KB
compat_mq.c -rw-r--r-- 4.0 KB
mqueue.c -rw-r--r-- 29.1 KB
msg.c -rw-r--r-- 18.9 KB
msgutil.c -rw-r--r-- 2.4 KB
sem.c -rw-r--r-- 33.7 KB
shm.c -rw-r--r-- 21.3 KB
util.c -rw-r--r-- 13.2 KB
util.h -rw-r--r-- 2.3 KB

back to top