https://github.com/torvalds/linux
Revision e76018cb604ace486de9cf85898c14bb2b47faff authored by Gustavo A. R. Silva on 23 March 2020, 21:48:10 UTC, committed by Gustavo A. R. Silva on 18 April 2020, 20:44:54 UTC
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by
this change:
"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
1 parent 5a58ec8
Tip revision: e76018cb604ace486de9cf85898c14bb2b47faff authored by Gustavo A. R. Silva on 23 March 2020, 21:48:10 UTC
can: dev: peak_canfd.h: Replace zero-length array with flexible-array member
can: dev: peak_canfd.h: Replace zero-length array with flexible-array member
Tip revision: e76018c
| File | Mode | Size |
|---|---|---|
| ccids | ||
| Kconfig | -rw-r--r-- | 1.1 KB |
| Makefile | -rw-r--r-- | 878 bytes |
| ackvec.c | -rw-r--r-- | 12.2 KB |
| ackvec.h | -rw-r--r-- | 4.5 KB |
| ccid.c | -rw-r--r-- | 5.1 KB |
| ccid.h | -rw-r--r-- | 8.6 KB |
| dccp.h | -rw-r--r-- | 16.0 KB |
| diag.c | -rw-r--r-- | 2.1 KB |
| feat.c | -rw-r--r-- | 47.0 KB |
| feat.h | -rw-r--r-- | 4.4 KB |
| input.c | -rw-r--r-- | 21.7 KB |
| ipv4.c | -rw-r--r-- | 28.5 KB |
| ipv6.c | -rw-r--r-- | 30.3 KB |
| ipv6.h | -rw-r--r-- | 608 bytes |
| minisocks.c | -rw-r--r-- | 7.3 KB |
| options.c | -rw-r--r-- | 16.2 KB |
| output.c | -rw-r--r-- | 20.2 KB |
| proto.c | -rw-r--r-- | 30.2 KB |
| qpolicy.c | -rw-r--r-- | 3.2 KB |
| sysctl.c | -rw-r--r-- | 2.6 KB |
| timer.c | -rw-r--r-- | 7.1 KB |
| trace.h | -rw-r--r-- | 2.2 KB |
Computing file changes ...
