https://github.com/torvalds/linux
Revision e76018cb604ace486de9cf85898c14bb2b47faff authored by Gustavo A. R. Silva on 23 March 2020, 21:48:10 UTC, committed by Gustavo A. R. Silva on 18 April 2020, 20:44:54 UTC
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by
this change:
"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
1 parent 5a58ec8
Tip revision: e76018cb604ace486de9cf85898c14bb2b47faff authored by Gustavo A. R. Silva on 23 March 2020, 21:48:10 UTC
can: dev: peak_canfd.h: Replace zero-length array with flexible-array member
can: dev: peak_canfd.h: Replace zero-length array with flexible-array member
Tip revision: e76018c
| File | Mode | Size |
|---|---|---|
| Makefile | -rw-r--r-- | 457 bytes |
| auth_gss.c | -rw-r--r-- | 55.9 KB |
| gss_generic_token.c | -rw-r--r-- | 6.1 KB |
| gss_krb5_crypto.c | -rw-r--r-- | 27.1 KB |
| gss_krb5_keys.c | -rw-r--r-- | 8.8 KB |
| gss_krb5_mech.c | -rw-r--r-- | 19.2 KB |
| gss_krb5_seal.c | -rw-r--r-- | 6.6 KB |
| gss_krb5_seqnum.c | -rw-r--r-- | 4.9 KB |
| gss_krb5_unseal.c | -rw-r--r-- | 6.7 KB |
| gss_krb5_wrap.c | -rw-r--r-- | 17.5 KB |
| gss_mech_switch.c | -rw-r--r-- | 10.1 KB |
| gss_rpc_upcall.c | -rw-r--r-- | 9.3 KB |
| gss_rpc_upcall.h | -rw-r--r-- | 875 bytes |
| gss_rpc_xdr.c | -rw-r--r-- | 16.6 KB |
| gss_rpc_xdr.h | -rw-r--r-- | 6.7 KB |
| svcauth_gss.c | -rw-r--r-- | 47.8 KB |
| trace.c | -rw-r--r-- | 260 bytes |
Computing file changes ...
