https://github.com/torvalds/linux
Revision e76018cb604ace486de9cf85898c14bb2b47faff authored by Gustavo A. R. Silva on 23 March 2020, 21:48:10 UTC, committed by Gustavo A. R. Silva on 18 April 2020, 20:44:54 UTC
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by
this change:
"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
1 parent 5a58ec8
Tip revision: e76018cb604ace486de9cf85898c14bb2b47faff authored by Gustavo A. R. Silva on 23 March 2020, 21:48:10 UTC
can: dev: peak_canfd.h: Replace zero-length array with flexible-array member
can: dev: peak_canfd.h: Replace zero-length array with flexible-array member
Tip revision: e76018c
| File | Mode | Size |
|---|---|---|
| auth_gss | ||
| xprtrdma | ||
| Kconfig | -rw-r--r-- | 2.4 KB |
| Makefile | -rw-r--r-- | 628 bytes |
| addr.c | -rw-r--r-- | 8.7 KB |
| auth.c | -rw-r--r-- | 20.7 KB |
| auth_null.c | -rw-r--r-- | 2.7 KB |
| auth_unix.c | -rw-r--r-- | 5.3 KB |
| backchannel_rqst.c | -rw-r--r-- | 11.0 KB |
| cache.c | -rw-r--r-- | 46.0 KB |
| clnt.c | -rw-r--r-- | 72.7 KB |
| debugfs.c | -rw-r--r-- | 7.2 KB |
| netns.h | -rw-r--r-- | 976 bytes |
| rpc_pipe.c | -rw-r--r-- | 35.8 KB |
| rpcb_clnt.c | -rw-r--r-- | 30.5 KB |
| sched.c | -rw-r--r-- | 33.8 KB |
| socklib.c | -rw-r--r-- | 7.9 KB |
| socklib.h | -rw-r--r-- | 470 bytes |
| stats.c | -rw-r--r-- | 8.6 KB |
| sunrpc.h | -rw-r--r-- | 1.7 KB |
| sunrpc_syms.c | -rw-r--r-- | 2.8 KB |
| svc.c | -rw-r--r-- | 41.0 KB |
| svc_xprt.c | -rw-r--r-- | 38.5 KB |
| svcauth.c | -rw-r--r-- | 4.6 KB |
| svcauth_unix.c | -rw-r--r-- | 21.8 KB |
| svcsock.c | -rw-r--r-- | 37.3 KB |
| sysctl.c | -rw-r--r-- | 3.6 KB |
| timer.c | -rw-r--r-- | 2.9 KB |
| xdr.c | -rw-r--r-- | 40.5 KB |
| xprt.c | -rw-r--r-- | 51.2 KB |
| xprtmultipath.c | -rw-r--r-- | 13.3 KB |
| xprtsock.c | -rw-r--r-- | 82.1 KB |
Computing file changes ...
