Skip to main content

Browse the archive

Revision e7820e39b7d19b9fe1928fc19de9361b44150ca6 authored by Eric Dumazet on 21 November 2014, 19:47:16 UTC, committed by David S. Miller on 21 November 2014, 20:26:32 UTC 
net: Revert "net: avoid one atomic operation in skb_clone()"
 
Not sure what I was thinking, but doing anything after
releasing a refcount is suicidal or/and embarrassing.

By the time we set skb->fclone to SKB_FCLONE_FREE, another cpu
could have released last reference and freed whole skb.

We potentially corrupt memory or trap if CONFIG_DEBUG_PAGEALLOC is set.

Reported-by: Chris Mason <clm@fb.com>
Fixes: ce1a4ea3f1258 ("net: avoid one atomic operation in skb_clone()")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 892d6eb
Raw File
gcc-ld 
#!/bin/sh
# run gcc with ld options
# used as a wrapper to execute link time optimizations
# yes virginia, this is not pretty

ARGS="-nostdlib"

while [ "$1" != "" ] ; do
	case "$1" in
	-save-temps|-m32|-m64) N="$1" ;;
	-r) N="$1" ;;
	-[Wg]*) N="$1" ;;
	-[olv]|-[Ofd]*|-nostdlib) N="$1" ;;
	--end-group|--start-group)
		 N="-Wl,$1" ;;
	-[RTFGhIezcbyYu]*|\
--script|--defsym|-init|-Map|--oformat|-rpath|\
-rpath-link|--sort-section|--section-start|-Tbss|-Tdata|-Ttext|\
--version-script|--dynamic-list|--version-exports-symbol|--wrap|-m)
		A="$1" ; shift ; N="-Wl,$A,$1" ;;
	-[m]*) N="$1" ;;
	-*) N="-Wl,$1" ;;
	*)  N="$1" ;;
	esac
	ARGS="$ARGS $N"
	shift
done

exec $CC $ARGS
back to top