Revision e7c243c925f6d9dcb898504ff24d6650b5cbb3b1 authored by Evgeniy Polyakov on 25 August 2007, 06:36:29 UTC, committed by David S. Miller on 27 August 2007, 01:35:47 UTC
I tried to preserve bridging code as it was before, but logic is quite strange - I think we should free skb on error, since it is already unshared and thus will just leak. Herbert Xu states: > + if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL) > + goto out; If this happens it'll be a double-free on skb since we'll return NF_DROP which makes the caller free it too. We could return NF_STOLEN to prevent that but I'm not sure whether that's correct netfilter semantics. Patrick, could you please make a call on this? Patrick McHardy states: NF_STOLEN should work fine here. Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 7c8347a
| File | Mode | Size |
|---|---|---|
| busses | ||
| chips | ||
| dev-interface | -rw-r--r-- | 5.9 KB |
| functionality | -rw-r--r-- | 5.3 KB |
| i2c-protocol | -rw-r--r-- | 2.4 KB |
| i2c-stub | -rw-r--r-- | 1.7 KB |
| porting-clients | -rw-r--r-- | 7.2 KB |
| smbus-protocol | -rw-r--r-- | 6.4 KB |
| summary | -rw-r--r-- | 3.3 KB |
| ten-bit-addresses | -rw-r--r-- | 1.1 KB |
| writing-clients | -rw-r--r-- | 22.9 KB |
Computing file changes ...
