Revision e7c243c925f6d9dcb898504ff24d6650b5cbb3b1 authored by Evgeniy Polyakov on 25 August 2007, 06:36:29 UTC, committed by David S. Miller on 27 August 2007, 01:35:47 UTC
I tried to preserve bridging code as it was before, but logic is quite strange - I think we should free skb on error, since it is already unshared and thus will just leak. Herbert Xu states: > + if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL) > + goto out; If this happens it'll be a double-free on skb since we'll return NF_DROP which makes the caller free it too. We could return NF_STOLEN to prevent that but I'm not sure whether that's correct netfilter semantics. Patrick, could you please make a call on this? Patrick McHardy states: NF_STOLEN should work fine here. Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 7c8347a
| File | Mode | Size |
|---|---|---|
| platform | ||
| acconfig.h | -rw-r--r-- | 7.2 KB |
| acdebug.h | -rw-r--r-- | 6.5 KB |
| acdisasm.h | -rw-r--r-- | 12.9 KB |
| acdispat.h | -rw-r--r-- | 10.8 KB |
| acevents.h | -rw-r--r-- | 6.5 KB |
| acexcep.h | -rw-r--r-- | 13.0 KB |
| acglobal.h | -rw-r--r-- | 13.5 KB |
| achware.h | -rw-r--r-- | 4.2 KB |
| acinterp.h | -rw-r--r-- | 15.9 KB |
| aclocal.h | -rw-r--r-- | 31.2 KB |
| acmacros.h | -rw-r--r-- | 27.6 KB |
| acnames.h | -rw-r--r-- | 3.4 KB |
| acnamesp.h | -rw-r--r-- | 9.2 KB |
| acobject.h | -rw-r--r-- | 15.3 KB |
| acopcode.h | -rw-r--r-- | 21.8 KB |
| acoutput.h | -rw-r--r-- | 8.0 KB |
| acparser.h | -rw-r--r-- | 7.2 KB |
| acpi.h | -rw-r--r-- | 3.1 KB |
| acpi_bus.h | -rw-r--r-- | 10.4 KB |
| acpi_drivers.h | -rw-r--r-- | 5.4 KB |
| acpi_numa.h | -rw-r--r-- | 522 bytes |
| acpiosxf.h | -rw-r--r-- | 7.8 KB |
| acpixf.h | -rw-r--r-- | 9.6 KB |
| acresrc.h | -rw-r--r-- | 10.8 KB |
| acstruct.h | -rw-r--r-- | 7.6 KB |
| actables.h | -rw-r--r-- | 4.0 KB |
| actbl.h | -rw-r--r-- | 14.1 KB |
| actbl1.h | -rw-r--r-- | 19.7 KB |
| actypes.h | -rw-r--r-- | 35.7 KB |
| acutils.h | -rw-r--r-- | 16.8 KB |
| amlcode.h | -rw-r--r-- | 18.5 KB |
| amlresrc.h | -rw-r--r-- | 9.7 KB |
| container.h | -rw-r--r-- | 198 bytes |
| pdc_intel.h | -rw-r--r-- | 935 bytes |
| processor.h | -rw-r--r-- | 8.2 KB |
Computing file changes ...
