Revision e7c243c925f6d9dcb898504ff24d6650b5cbb3b1 authored by Evgeniy Polyakov on 25 August 2007, 06:36:29 UTC, committed by David S. Miller on 27 August 2007, 01:35:47 UTC
I tried to preserve bridging code as it was before, but logic is quite strange - I think we should free skb on error, since it is already unshared and thus will just leak. Herbert Xu states: > + if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL) > + goto out; If this happens it'll be a double-free on skb since we'll return NF_DROP which makes the caller free it too. We could return NF_STOLEN to prevent that but I'm not sure whether that's correct netfilter semantics. Patrick, could you please make a call on this? Patrick McHardy states: NF_STOLEN should work fine here. Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 7c8347a
dma.h
#ifndef __ASM_SH64_DMA_H
#define __ASM_SH64_DMA_H
/*
* This file is subject to the terms and conditions of the GNU General Public
* License. See the file "COPYING" in the main directory of this archive
* for more details.
*
* include/asm-sh64/dma.h
*
* Copyright (C) 2000, 2001 Paolo Alberelli
* Copyright (C) 2003 Paul Mundt
*
*/
#include <linux/mm.h>
#include <asm/io.h>
#include <asm/pgtable.h>
#define MAX_DMA_CHANNELS 4
/*
* SH5 can DMA in any memory area.
*
* The static definition is dodgy because it should limit
* the highest DMA-able address based on the actual
* Physical memory available. This is actually performed
* at run time in defining the memory allowed to DMA_ZONE.
*/
#define MAX_DMA_ADDRESS ~(NPHYS_MASK)
#define DMA_MODE_READ 0
#define DMA_MODE_WRITE 1
#ifdef CONFIG_PCI
extern int isa_dma_bridge_buggy;
#else
#define isa_dma_bridge_buggy (0)
#endif
#endif /* __ASM_SH64_DMA_H */
Computing file changes ...
