Revision e7c243c925f6d9dcb898504ff24d6650b5cbb3b1 authored by Evgeniy Polyakov on 25 August 2007, 06:36:29 UTC, committed by David S. Miller on 27 August 2007, 01:35:47 UTC
I tried to preserve bridging code as it was before, but logic is quite strange - I think we should free skb on error, since it is already unshared and thus will just leak. Herbert Xu states: > + if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL) > + goto out; If this happens it'll be a double-free on skb since we'll return NF_DROP which makes the caller free it too. We could return NF_STOLEN to prevent that but I'm not sure whether that's correct netfilter semantics. Patrick, could you please make a call on this? Patrick McHardy states: NF_STOLEN should work fine here. Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 7c8347a
| File | Mode | Size |
|---|---|---|
| bbm.h | -rw-r--r-- | 4.3 KB |
| blktrans.h | -rw-r--r-- | 1.9 KB |
| cfi.h | -rw-r--r-- | 12.1 KB |
| cfi_endian.h | -rw-r--r-- | 1.3 KB |
| compatmac.h | -rw-r--r-- | 332 bytes |
| concat.h | -rw-r--r-- | 514 bytes |
| doc2000.h | -rw-r--r-- | 5.4 KB |
| flashchip.h | -rw-r--r-- | 2.2 KB |
| ftl.h | -rw-r--r-- | 2.6 KB |
| gen_probe.h | -rw-r--r-- | 560 bytes |
| inftl.h | -rw-r--r-- | 1.5 KB |
| jedec.h | -rw-r--r-- | 1.9 KB |
| map.h | -rw-r--r-- | 11.9 KB |
| mtd.h | -rw-r--r-- | 7.9 KB |
| nand.h | -rw-r--r-- | 21.3 KB |
| nand_ecc.h | -rw-r--r-- | 809 bytes |
| ndfc.h | -rw-r--r-- | 2.2 KB |
| nftl.h | -rw-r--r-- | 1.5 KB |
| onenand.h | -rw-r--r-- | 5.5 KB |
| onenand_regs.h | -rw-r--r-- | 6.1 KB |
| partitions.h | -rw-r--r-- | 2.4 KB |
| physmap.h | -rw-r--r-- | 1.5 KB |
| plat-ram.h | -rw-r--r-- | 822 bytes |
| pmc551.h | -rw-r--r-- | 2.2 KB |
| super.h | -rw-r--r-- | 855 bytes |
| ubi.h | -rw-r--r-- | 7.1 KB |
| xip.h | -rw-r--r-- | 2.7 KB |
Computing file changes ...
