Revision e9338abf0e186336022293d2e454c106761f262b authored by Linus Torvalds on 15 July 2021, 20:57:31 UTC, committed by Linus Torvalds on 15 July 2021, 20:57:31 UTC
Pull fallthrough fixes from Gustavo Silva: "This fixes many fall-through warnings when building with Clang and -Wimplicit-fallthrough, and also enables -Wimplicit-fallthrough for Clang, globally. It's also important to notice that since we have adopted the use of the pseudo-keyword macro fallthrough, we also want to avoid having more /* fall through */ comments being introduced. Contrary to GCC, Clang doesn't recognize any comments as implicit fall-through markings when the -Wimplicit-fallthrough option is enabled. So, in order to avoid having more comments being introduced, we use the option -Wimplicit-fallthrough=5 for GCC, which similar to Clang, will cause a warning in case a code comment is intended to be used as a fall-through marking. The patch for Makefile also enforces this. We had almost 4,000 of these issues for Clang in the beginning, and there might be a couple more out there when building some architectures with certain configurations. However, with the recent fixes I think we are in good shape and it is now possible to enable the warning for Clang" * tag 'Wimplicit-fallthrough-clang-5.14-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux: (27 commits) Makefile: Enable -Wimplicit-fallthrough for Clang powerpc/smp: Fix fall-through warning for Clang dmaengine: mpc512x: Fix fall-through warning for Clang usb: gadget: fsl_qe_udc: Fix fall-through warning for Clang powerpc/powernv: Fix fall-through warning for Clang MIPS: Fix unreachable code issue MIPS: Fix fall-through warnings for Clang ASoC: Mediatek: MT8183: Fix fall-through warning for Clang power: supply: Fix fall-through warnings for Clang dmaengine: ti: k3-udma: Fix fall-through warning for Clang s390: Fix fall-through warnings for Clang dmaengine: ipu: Fix fall-through warning for Clang iommu/arm-smmu-v3: Fix fall-through warning for Clang mmc: jz4740: Fix fall-through warning for Clang PCI: Fix fall-through warning for Clang scsi: libsas: Fix fall-through warning for Clang video: fbdev: Fix fall-through warning for Clang math-emu: Fix fall-through warning cpufreq: Fix fall-through warning for Clang drm/msm: Fix fall-through warning in msm_gem_new_impl() ...
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 9.7 KB |
| Kconfig.arm | -rw-r--r-- | 9.7 KB |
| Kconfig.powerpc | -rw-r--r-- | 1.6 KB |
| Kconfig.x86 | -rw-r--r-- | 8.8 KB |
| Makefile | -rw-r--r-- | 5.2 KB |
| acpi-cpufreq.c | -rw-r--r-- | 26.3 KB |
| amd_freq_sensitivity.c | -rw-r--r-- | 4.0 KB |
| armada-37xx-cpufreq.c | -rw-r--r-- | 16.0 KB |
| armada-8k-cpufreq.c | -rw-r--r-- | 4.9 KB |
| bmips-cpufreq.c | -rw-r--r-- | 4.3 KB |
| brcmstb-avs-cpufreq.c | -rw-r--r-- | 20.1 KB |
| cppc_cpufreq.c | -rw-r--r-- | 20.2 KB |
| cpufreq-dt-platdev.c | -rw-r--r-- | 5.5 KB |
| cpufreq-dt.c | -rw-r--r-- | 8.8 KB |
| cpufreq-dt.h | -rw-r--r-- | 608 bytes |
| cpufreq-nforce2.c | -rw-r--r-- | 9.0 KB |
| cpufreq.c | -rw-r--r-- | 75.0 KB |
| cpufreq_conservative.c | -rw-r--r-- | 8.7 KB |
| cpufreq_governor.c | -rw-r--r-- | 16.5 KB |
| cpufreq_governor.h | -rw-r--r-- | 5.5 KB |
| cpufreq_governor_attr_set.c | -rw-r--r-- | 2.1 KB |
| cpufreq_ondemand.c | -rw-r--r-- | 12.8 KB |
| cpufreq_ondemand.h | -rw-r--r-- | 655 bytes |
| cpufreq_performance.c | -rw-r--r-- | 1.2 KB |
| cpufreq_powersave.c | -rw-r--r-- | 1.0 KB |
| cpufreq_stats.c | -rw-r--r-- | 7.1 KB |
| cpufreq_userspace.c | -rw-r--r-- | 3.6 KB |
| davinci-cpufreq.c | -rw-r--r-- | 3.8 KB |
| e_powersaver.c | -rw-r--r-- | 10.7 KB |
| elanfreq.c | -rw-r--r-- | 5.5 KB |
| freq_table.c | -rw-r--r-- | 8.8 KB |
| gx-suspmod.c | -rw-r--r-- | 13.9 KB |
| highbank-cpufreq.c | -rw-r--r-- | 2.9 KB |
| ia64-acpi-cpufreq.c | -rw-r--r-- | 7.6 KB |
| imx-cpufreq-dt.c | -rw-r--r-- | 5.3 KB |
| imx6q-cpufreq.c | -rw-r--r-- | 14.6 KB |
| intel_pstate.c | -rw-r--r-- | 85.2 KB |
| kirkwood-cpufreq.c | -rw-r--r-- | 4.8 KB |
| longhaul.c | -rw-r--r-- | 25.3 KB |
| longhaul.h | -rw-r--r-- | 8.5 KB |
| longrun.c | -rw-r--r-- | 8.1 KB |
| loongson1-cpufreq.c | -rw-r--r-- | 5.5 KB |
| loongson2_cpufreq.c | -rw-r--r-- | 4.2 KB |
| maple-cpufreq.c | -rw-r--r-- | 6.5 KB |
| mediatek-cpufreq.c | -rw-r--r-- | 15.1 KB |
| mvebu-cpufreq.c | -rw-r--r-- | 2.6 KB |
| omap-cpufreq.c | -rw-r--r-- | 4.8 KB |
| p4-clockmod.c | -rw-r--r-- | 6.9 KB |
| pasemi-cpufreq.c | -rw-r--r-- | 6.0 KB |
| pcc-cpufreq.c | -rw-r--r-- | 15.7 KB |
| pmac32-cpufreq.c | -rw-r--r-- | 17.5 KB |
| pmac64-cpufreq.c | -rw-r--r-- | 17.5 KB |
| powernow-k6.c | -rw-r--r-- | 8.1 KB |
| powernow-k7.c | -rw-r--r-- | 15.8 KB |
| powernow-k7.h | -rw-r--r-- | 773 bytes |
| powernow-k8.c | -rw-r--r-- | 30.4 KB |
| powernow-k8.h | -rw-r--r-- | 6.5 KB |
| powernv-cpufreq.c | -rw-r--r-- | 30.4 KB |
| ppc_cbe_cpufreq.c | -rw-r--r-- | 3.6 KB |
| ppc_cbe_cpufreq.h | -rw-r--r-- | 1.0 KB |
| ppc_cbe_cpufreq_pervasive.c | -rw-r--r-- | 2.2 KB |
| ppc_cbe_cpufreq_pmi.c | -rw-r--r-- | 3.1 KB |
| pxa2xx-cpufreq.c | -rw-r--r-- | 8.7 KB |
| pxa3xx-cpufreq.c | -rw-r--r-- | 5.4 KB |
| qcom-cpufreq-hw.c | -rw-r--r-- | 11.8 KB |
| qcom-cpufreq-nvmem.c | -rw-r--r-- | 12.1 KB |
| qoriq-cpufreq.c | -rw-r--r-- | 6.9 KB |
| raspberrypi-cpufreq.c | -rw-r--r-- | 2.3 KB |
| s3c2410-cpufreq.c | -rw-r--r-- | 3.6 KB |
| s3c2412-cpufreq.c | -rw-r--r-- | 5.5 KB |
| s3c2416-cpufreq.c | -rw-r--r-- | 12.2 KB |
| s3c2440-cpufreq.c | -rw-r--r-- | 7.4 KB |
| s3c24xx-cpufreq-debugfs.c | -rw-r--r-- | 3.7 KB |
| s3c24xx-cpufreq.c | -rw-r--r-- | 15.5 KB |
| s3c64xx-cpufreq.c | -rw-r--r-- | 4.9 KB |
| s5pv210-cpufreq.c | -rw-r--r-- | 17.0 KB |
| sa1100-cpufreq.c | -rw-r--r-- | 6.3 KB |
| sa1110-cpufreq.c | -rw-r--r-- | 8.8 KB |
| sc520_freq.c | -rw-r--r-- | 2.8 KB |
| scmi-cpufreq.c | -rw-r--r-- | 7.6 KB |
| scpi-cpufreq.c | -rw-r--r-- | 5.5 KB |
| sh-cpufreq.c | -rw-r--r-- | 4.7 KB |
| sparc-us2e-cpufreq.c | -rw-r--r-- | 8.8 KB |
| sparc-us3-cpufreq.c | -rw-r--r-- | 4.9 KB |
| spear-cpufreq.c | -rw-r--r-- | 5.9 KB |
| speedstep-centrino.c | -rw-r--r-- | 13.8 KB |
| speedstep-ich.c | -rw-r--r-- | 9.1 KB |
| speedstep-lib.c | -rw-r--r-- | 11.6 KB |
| speedstep-lib.h | -rw-r--r-- | 1.7 KB |
| speedstep-smi.c | -rw-r--r-- | 9.5 KB |
| sti-cpufreq.c | -rw-r--r-- | 7.3 KB |
| sun50i-cpufreq-nvmem.c | -rw-r--r-- | 5.0 KB |
| tegra124-cpufreq.c | -rw-r--r-- | 4.9 KB |
| tegra186-cpufreq.c | -rw-r--r-- | 6.9 KB |
| tegra194-cpufreq.c | -rw-r--r-- | 11.3 KB |
| tegra20-cpufreq.c | -rw-r--r-- | 2.7 KB |
| ti-cpufreq.c | -rw-r--r-- | 11.3 KB |
| vexpress-spc-cpufreq.c | -rw-r--r-- | 14.6 KB |
Computing file changes ...
