Revision e9338abf0e186336022293d2e454c106761f262b authored by Linus Torvalds on 15 July 2021, 20:57:31 UTC, committed by Linus Torvalds on 15 July 2021, 20:57:31 UTC
Pull fallthrough fixes from Gustavo Silva: "This fixes many fall-through warnings when building with Clang and -Wimplicit-fallthrough, and also enables -Wimplicit-fallthrough for Clang, globally. It's also important to notice that since we have adopted the use of the pseudo-keyword macro fallthrough, we also want to avoid having more /* fall through */ comments being introduced. Contrary to GCC, Clang doesn't recognize any comments as implicit fall-through markings when the -Wimplicit-fallthrough option is enabled. So, in order to avoid having more comments being introduced, we use the option -Wimplicit-fallthrough=5 for GCC, which similar to Clang, will cause a warning in case a code comment is intended to be used as a fall-through marking. The patch for Makefile also enforces this. We had almost 4,000 of these issues for Clang in the beginning, and there might be a couple more out there when building some architectures with certain configurations. However, with the recent fixes I think we are in good shape and it is now possible to enable the warning for Clang" * tag 'Wimplicit-fallthrough-clang-5.14-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux: (27 commits) Makefile: Enable -Wimplicit-fallthrough for Clang powerpc/smp: Fix fall-through warning for Clang dmaengine: mpc512x: Fix fall-through warning for Clang usb: gadget: fsl_qe_udc: Fix fall-through warning for Clang powerpc/powernv: Fix fall-through warning for Clang MIPS: Fix unreachable code issue MIPS: Fix fall-through warnings for Clang ASoC: Mediatek: MT8183: Fix fall-through warning for Clang power: supply: Fix fall-through warnings for Clang dmaengine: ti: k3-udma: Fix fall-through warning for Clang s390: Fix fall-through warnings for Clang dmaengine: ipu: Fix fall-through warning for Clang iommu/arm-smmu-v3: Fix fall-through warning for Clang mmc: jz4740: Fix fall-through warning for Clang PCI: Fix fall-through warning for Clang scsi: libsas: Fix fall-through warning for Clang video: fbdev: Fix fall-through warning for Clang math-emu: Fix fall-through warning cpufreq: Fix fall-through warning for Clang drm/msm: Fix fall-through warning in msm_gem_new_impl() ...
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 9.5 KB |
| Makefile | -rw-r--r-- | 1.3 KB |
| altera_ps2.c | -rw-r--r-- | 3.6 KB |
| ambakmi.c | -rw-r--r-- | 4.2 KB |
| ams_delta_serio.c | -rw-r--r-- | 5.0 KB |
| apbps2.c | -rw-r--r-- | 5.4 KB |
| arc_ps2.c | -rw-r--r-- | 6.2 KB |
| ct82c710.c | -rw-r--r-- | 5.7 KB |
| gscps2.c | -rw-r--r-- | 11.3 KB |
| hil_mlc.c | -rw-r--r-- | 25.2 KB |
| hp_sdc.c | -rw-r--r-- | 28.4 KB |
| hp_sdc_mlc.c | -rw-r--r-- | 9.1 KB |
| hyperv-keyboard.c | -rw-r--r-- | 10.3 KB |
| i8042-io.h | -rw-r--r-- | 1.7 KB |
| i8042-ip22io.h | -rw-r--r-- | 1.3 KB |
| i8042-jazzio.h | -rw-r--r-- | 1.1 KB |
| i8042-snirm.h | -rw-r--r-- | 1.3 KB |
| i8042-sparcio.h | -rw-r--r-- | 3.5 KB |
| i8042-x86ia64io.h | -rw-r--r-- | 30.0 KB |
| i8042.c | -rw-r--r-- | 37.7 KB |
| i8042.h | -rw-r--r-- | 1.9 KB |
| ioc3kbd.c | -rw-r--r-- | 4.5 KB |
| libps2.c | -rw-r--r-- | 11.0 KB |
| maceps2.c | -rw-r--r-- | 5.2 KB |
| olpc_apsp.c | -rw-r--r-- | 7.0 KB |
| parkbd.c | -rw-r--r-- | 5.5 KB |
| pcips2.c | -rw-r--r-- | 4.6 KB |
| ps2-gpio.c | -rw-r--r-- | 10.5 KB |
| ps2mult.c | -rw-r--r-- | 6.6 KB |
| q40kbd.c | -rw-r--r-- | 3.7 KB |
| rpckbd.c | -rw-r--r-- | 3.3 KB |
| sa1111ps2.c | -rw-r--r-- | 8.1 KB |
| serio.c | -rw-r--r-- | 24.0 KB |
| serio_raw.c | -rw-r--r-- | 9.7 KB |
| serport.c | -rw-r--r-- | 7.1 KB |
| sun4i-ps2.c | -rw-r--r-- | 8.6 KB |
| userio.c | -rw-r--r-- | 6.5 KB |
| xilinx_ps2.c | -rw-r--r-- | 10.4 KB |
Computing file changes ...
